summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Merge "Disable form auto-complete on login form" into stable/yogastable/yogaZuul2023-05-121-2/+2
|\
| * Disable form auto-complete on login formDavid Hill2023-05-051-2/+2
| | | | | | | | | | | | | | | | Disable form auto-complete on login form with autocomplete="off" for the email/password field. Change-Id: Ie550eae36ece160d19186a404c0e688f2f6e785b (cherry picked from commit e4a13dbcde0df213f9b6e7d72f45c6610192204a)
* | Remove Description from Edit Image MetadataTatiana Ovchinnikova2023-05-051-0/+6
|/ | | | | | | | | | | | | | | Image description can be edited through Edit Image -> Image Detail, however it also appears as a property in Edit Image -> Metadata when the description is not empty. It's confusing to have it in two sections of one dialog form, and moreover, the Image Detail field always overwrites the Metadata field. This patch removes Description from Edit Metadata. Closes-Bug: #2017698 Change-Id: I041948b4b71f00894f03cc30cfa4592df4a100c3 (cherry picked from commit 283b38e4f10b14c61dff42936c80ae3987f017cf)
* Fix instance error with attribute cells.Jan Jasek2023-04-061-0/+10
| | | | | | | | Selenium read data faster than the data are loaded. Added wait until element is visible. Change-Id: I2975ea5836a898d113a2baaab6a8f9bf8af8d742 (cherry picked from commit b14958df8bbf93c5c8623b6e367dfba607d795d1)
* Merge "Fix rescue of volume-based instances" into stable/yogaZuul2023-03-302-3/+7
|\
| * Fix rescue of volume-based instancesJan Hartkopf2022-10-262-3/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Rescue of volume-based instances is supported since Nova microversion 2.87. However, Horizon does not use this microversion when requesting rescue of any instances, causing a Nova exception for volume- based ones. The patch fixes this by explicitly setting the required microversion. Closes-Bug: #1941744 Signed-off-by: Jan Hartkopf <jhartkopf@inovex.de> Change-Id: Ic0cdfd326475882f839fd218cd7b4bfa62a2a76b (cherry picked from commit 05dd53a3cf3e1ced265d23d1c02765abd468a483) (cherry picked from commit 761e466e7a0628ae939dd654152f615732ad4f79)
* | Merge "Fix delete image tests." into stable/yogaZuul2023-03-292-0/+17
|\ \
| * | Fix delete image tests.Jan Jasek2023-03-072-0/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add wait until checkbox is in active state. Fix edit_image_description_and_name test. Add wait until the name text box is filled by default name (is not empty). In the other case selenium write new name into text box faster than default name is written there so default name then rewrite the new name. Change-Id: I56803e19dd80180cc432ca872a28a7ee7f41290d (cherry picked from commit I56803e19dd80180cc432ca872a28a7ee7f41290d) (cherry picked from commit 25c107d710a03024243463be7e1d8404f1375232)
* | | Merge "Add setup and teardown to the instances pagination tests" into ↵Zuul2023-03-221-151/+170
|\ \ \ | | | | | | | | | | | | stable/yoga
| * | | Add setup and teardown to the instances pagination testsRadomir Dopieralski2023-02-171-151/+170
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Also delete any leftover instances before starting the tests Change-Id: I5a7e4e97e8b9ebd62a9dafb6c82edbff69cf23ba (cherry picked from commit 421df2451caf2b82e1158d600faf41dd4ffb1acd)
* | | | Merge "Make integration tests stop on first failure" into stable/yogaZuul2023-03-221-1/+1
|\ \ \ \ | |_|/ / |/| | |
| * | | Make integration tests stop on first failureRadomir Dopieralski2023-02-171-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This should save us some time and decrease the server load. If a single test failed, we already know the patch is bad (or the tests need to be rerun) so it makes no sense to execute the rest of the tests on the gate. Change-Id: Ic56d5e192487d444afd0cdf0bce5e1a691ba087c (cherry picked from commit 4eb24797e53a39ec42c70768c160a838400aeadb)
* | | | Merge "Add setup and teardown to the volumes pagination tests" into stable/yogaZuul2023-03-041-0/+9
|\ \ \ \
| * | | | Add setup and teardown to the volumes pagination testsRadomir Dopieralski2023-02-171-0/+9
| | |/ / | |/| | | | | | | | | | | | | | | | | | | | | | For now just delete the old volumes at the start Change-Id: I013da554f58e1638178d3655459c9742fd7f85ba (cherry picked from commit 81edf08676f2651f4343498c23d93b000fca7127)
* | | | Merge "Integration test navigation machinery for Angular pages" into stable/yogaZuul2023-03-0310-235/+483
|\ \ \ \
| * | | | Integration test navigation machinery for Angular pagesTatiana Ovchinnikova2023-02-1710-235/+483
| | |/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There's an implementation of navigation modules for pages written in Angular. Legacy tests for images page are rewritten to work with the new navigation. Change-Id: Ib8a40f0adb0a46c9d646c6796a4242988eefa6e3 (cherry picked from commit 4743c6c748be79c3a80a350d05aeed7bbe63c577)
* | | | Merge "Fix instance table behavior after deleting an instance" into stable/yogaZuul2023-03-011-3/+3
|\ \ \ \
| * | | | Fix instance table behavior after deleting an instanceHeather Lemon2023-02-021-3/+3
| | |/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | After deleting a VM from the instances table, all VMs above it in the table list disappear from the UI until the page is refreshed. Partial-Bug: #1859851 Change-Id: Icae04fd0f0c3f3fa5127309b64fc1b15e3bbc677 (cherry picked from commit c90c0b709c170fae299acc5917e7da69fb2ef2a8)
* | | | Use SetUp and cleanup for the network pagination testsRadomir Dopieralski2023-02-171-46/+69
| |/ / |/| | | | | | | | | | | | | | | | | Also fix the case where the last page is not full. Change-Id: Ia3cbb9a3683c335c301a9ffd8d3d04f222960fee (cherry picked from commit 4b2df0a684f8030ab8e065e6d765dd56dfcafaaf)
* | | Speed up integration testsRadomir Dopieralski2023-02-081-6/+2
|/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | We have a place in the form-handling code where we look for the blue form submit button, and if it's not found, we look for the red form submit button. It looks correct at first glance, however it takes 10 seconds to throw NoSuchElementException, because there is a delay that makes sure that the page loads fully before raising that exception. Replacing this with a selector that finds both the blue and the red buttons in one query speeds the whole integration tests suite by half an hour, because there is no more waiting on every delete confirmation dialog. Change-Id: Ie256118c0a84a8868393018b25b0aa049582a17d (cherry picked from commit 2e6eca294718deb7e82f50c071d332377c35085f)
* | Merge "Fix flavor id auto generation" into stable/yogaZuul2023-01-201-2/+2
|\ \
| * | Fix flavor id auto generationTatiana Ovchinnikova2022-12-081-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently the flavor creation form always check for the uniqueness of the UUID field, even when it is set to "auto". That means that if we create a flavor with UUID value of "auto", the check will fail. This patch disable the check when UUID is automatically generated. Change-Id: Ie31307d67cf3857e3bb80c124e92c81e0c6a2982 (cherry picked from commit af7e6c4f75299b9e47db059dc7ddbaf2e0b1a3fc)
* | | Pin tox<4 for stable branches testingmanchandavishal2023-01-121-0/+8
|/ / | | | | | | | | | | | | | | | | | | | | | | | | horizon npm jobs start failing due to some recent changes in tox4. As discussed on open-discuss ML, it is decided to keep testing the stable branch with the tox version that they release with and not with the tox 4. This patch set the 'ensure_tox_version' to use 4, which will tell zuul to install tox<4 if it's not present. For more info. please refer [1]. [1] https://lists.openstack.org/pipermail/openstack-discuss/2023-January/031668.html Change-Id: I3652d87d817030bcd3855d26bfa41b8b7061d08e
* | Merge "Make readonly metadata properties unable to edit" into stable/yogaZuul2022-12-022-0/+10
|\ \
| * | Make readonly metadata properties unable to editTatiana Ovchinnikova2022-11-252-0/+10
| |/ | | | | | | | | | | | | | | | | | | | | | | | | | | Image metadata properties os_hash_algo and os_hash_value are readonly, and attempts to edit them fail with unclear message. This patch makes these fields readonly in update metadata form. Also, if the existing metadata property is null, Horizon should consider it optional too, in addition to empty field fix: https://review.opendev.org/c/openstack/horizon/+/812009 Change-Id: I892465ca4688fce9f7123682d02f11c92c7d2c5c (cherry picked from commit 892080ec0ff6174d5fd5de221ec4802bd21371a6)
* | Fix preselection for launch Instance dialogTatiana Ovchinnikova2022-11-251-2/+11
|/ | | | | | | | | | | | | Launch instance from a volumes/volume snapshot/instance snapshot should open a dialog with preselected boot source. However the dialog shows Image as selected boot source in any case, discarding the preselection. This patch fixes it, explicitly changing the boot source according to the preselection. Change-Id: I1a5a46d7be12ed179474a6a74647d0872b27b492 (cherry picked from commit 452c37dd369d2fa4c0dac9da1aba53bf1da89a30)
* Merge "Don't try and update port security if its not changing" into stable/yogaZuul2022-10-253-4/+22
|\
| * Don't try and update port security if its not changingSam Morrison2022-09-243-4/+22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Default policy in neutron doesn't allow port security to change if network not owned by the user. To allow users to update other attributes of a port don't send port_security_enabled attribute to neutron unless it changes. If user tries to change port security on a port in a network not owned by them it will still error as it does now. Partial-Bug: #1841050 Change-Id: I301336103cabc3f1cab3ee72d7743385ff1a10d6 (cherry picked from commit d059b0bc40f04befc60657cd6504cc5711934b90)
* | Merge "Fix flavor specification at instance overview page" into stable/yogaZuul2022-10-252-5/+30
|\ \
| * | Fix flavor specification at instance overview pageTatiana Ovchinnikova2022-10-062-5/+30
| |/ | | | | | | | | | | | | | | | | | | The details page uses flavor id to resolve instance flavor, relying on legacy Nova API v2.46. This patch adds the current Nova API option, resolving instance flavor by flavor name, so flavor specification at instance overview page is displayed properly. Change-Id: I1fe45063c9d1cdd8682998329d81f843d30f80b3 (cherry picked from commit d0e9e976f2769b289196d481b0928893b702b011)
* | Fix app cred create without project_id for domain adminsRodrigo Barbieri2022-10-182-3/+58
| | | | | | | | | | | | | | | | | | | | | | | | Users with domain admin role that are not cloud admins are not able to get scoped context and create an application credential with project_id, so this change forces the scoped context in that particular case. Closes-bug: #1827120 Change-Id: I076a97a6f943ab74a2db8bc5179a7db194009db4 (cherry picked from commit 6eeaf9852478e25ff77c21117664ac126c5357a4) (cherry picked from commit 778a52e66aeab883b31db729e04944eeecfec6a2)
* | zuul: Declare queue at top levelTakashi Kajinami2022-10-171-1/+1
|/ | | | | | | | | | | | | | Zuul deprecated declaring shared queues at a pipeline level with release 4.1.0[1]. This updates the job definition to use the top level declaration instead. See [2] for details. [1] https://zuul-ci.org/docs/zuul/latest/releasenotes.html#relnotes-4-1-0-deprecation-notes [2] http://lists.openstack.org/pipermail/openstack-discuss/2022-May/028603.html Change-Id: Ie63dd3b161cb8fd9be89002027d699ce2c4a67a5 (cherry picked from commit 4212950a4a6b036f563a236cb005604e1c096f04)
* Make existing empty metadata properties optionalTatiana Ovchinnikova2022-06-142-1/+7
| | | | | | | | | | | | | Editing of snapshot image or updating its metadata from Horizon is not allowed until existing properties with empty values are set or removed from metadata tree. They are allowed to be None, therefore Horizon should consider them optional too. Closes-Bug: #1945706 Change-Id: Idfec71d209430c7d069133a40ca1a7d340163783 (cherry picked from commit 4e0f5a5a85467ca83743e6e8126cd570f329afb9)
* Do not assume keystone admin endpoint22.1.0Akihiro Motoki2022-03-253-11/+15
| | | | | | | | | | | | | | | | | keystone does not distinguish public and admin endpoints since Train [1], so there is no need to use a separate endpoint for keystone admin operations. admin endpoint still can be configured but there is no functional difference anymore from other endpoints. We do not need to require admin endpoint and can use an endpoint specified by OPENSTACK_ENDPOINT_TYPE for all API operations. This commit reverts commit f9bab3fe195eb13635aa70cb910d94df98d66cf3 as we no longer need the workaround. [1] https://review.opendev.org/c/openstack/keystone/+/664246 Closes-Bug: #1950659 Change-Id: I2660fd2df8081e1d2d9c84626037f94bd9d137a5
* Add SYSTEM_SCOPE_SERVICES setting that hides panelsRadomir Dopieralski2022-03-2420-3/+131
| | | | | | | | | | | Since not all services are ready to use the system scope token, we need a way to disable and enable the use of system scope token on a per-service basis. This setting let us configure which services should use the system scope token. By default the list is empty and system scope token is not used at all. Change-Id: I5e0cdc7288221571f183a37b800c19dc4cff5707 (cherry picked from commit 6c814b241d7465113a6edfc023fa6ef9314f4591)
* Update TOX_CONSTRAINTS_FILE for stable/yogaOpenStack Release Bot2022-03-231-2/+2
| | | | | | | | | | | | Update the URL to the upper-constraints file to point to the redirect rule on releases.openstack.org so that anyone working on this branch will switch to the correct upper-constraints list automatically when the requirements repository branches. Until the requirements repository has as stable/yoga branch, tests will continue to use the upper-constraints list on master. Change-Id: Ibc72b044a3d0788e3515c7ea1a02899206381010
* Update .gitreview for stable/yogaOpenStack Release Bot2022-03-231-0/+1
| | | | Change-Id: I712cb15d54255256f918acf46123332bf82334eb
* Sync default policy rules22.0.0manchandavishal2022-03-2112-3560/+4894
| | | | | | | | | | | This patch updates default policy-in-code rules in horizon based on nova/neutron/keystone/glance/cinder RC deliverables. It also bumps a few packages versions in lower-constraints.txt and requirements.txt to fix the failed lower-constraints job after updating policy rules. Change-Id: I168bb171076e3442b29670461a29d12c9988df52
* Merge "Address RemovedInDjango40Warning (7)"Zuul2022-03-1222-37/+96
|\
| * Address RemovedInDjango40Warning (7)Akihiro Motoki2022-02-0422-37/+96
| | | | | | | | | | | | | | | | | | | | | | | | | | HttpRequest.is_ajax() was marked as deprecated since Django 3.1 and will be removed in Django 4.0 [1]. While the current implementation of is_ajax() relies on a jQuery-specific way of signifying AJAX as noted in the Django relnotes, horizon works with this. Thus this commit copies the existing logic of HttpRequest.is_ajax() to the horizon repo (as horizon.utils.http.is_ajax()) and consumes it. https: //docs.djangoproject.com/en/4.0/releases/3.1/#features-deprecated-in-3-1 Change-Id: I3def53033524985818a891a1b9d4659fad4ba2ba
* | Merge "Address RemovedInDjango40Warning (6)"Zuul2022-03-122-9/+13
|\ \ | |/
| * Address RemovedInDjango40Warning (6)Akihiro Motoki2022-02-042-9/+13
| | | | | | | | | | | | | | | | Django 3.0 renamed is_safe_url() to url_has_allowed_host_and_scheme() and deprecated is_safe_url(). https: //docs.djangoproject.com/en/4.0/releases/3.0/#deprecated-features-3-0 Change-Id: Ic970a93a2083525139d8741a4150e643264be43b
* | Merge "Address RemovedInDjango40Warning (5)"Zuul2022-03-121-1/+1
|\ \ | |/
| * Address RemovedInDjango40Warning (5)Akihiro Motoki2022-02-041-1/+1
| | | | | | | | | | | | | | | | Django 3.1 deprecates {% ifequal %} template tag in favor of {% if %} as {% if %} covers all use cases. https: //docs.djangoproject.com/en/4.0/releases/3.1/#features-deprecated-in-3-1 Change-Id: Ief79fb4a08599ad94ed82f3e404620cc54a7eedf
* | Merge "Address RemovedInDjango40Warning (4)"Zuul2022-03-1015-60/+63
|\ \ | |/
| * Address RemovedInDjango40Warning (4)Akihiro Motoki2022-02-0415-60/+63
| | | | | | | | | | | | | | | | | | | | In Django 3.0, django.utils.http.urlquote(), urlquote_plus(), urlunquote(), and urlunquote_plus() are deprecated in favor of the functions that they’re aliases for: urllib.parse.quote(), quote_plus(), unquote(), and unquote_plus(). https: //docs.djangoproject.com/en/4.0/releases/3.0/ Change-Id: I37fcd917cbf87b4d3141cfbdd2675aa38f33f2a4
* | Merge "Address RemovedInDjango40Warning (3)"Zuul2022-03-1089-710/+725
|\ \ | |/
| * Address RemovedInDjango40Warning (3)Akihiro Motoki2022-02-0489-710/+725
| | | | | | | | | | | | | | | | | | In Django 3.1, django.conf.urls.url() is deprecated in favor of django.urls.re_path(). https://docs.djangoproject.com/en/4.0/releases/3.1/#id2 Change-Id: I484694f8718f61c022126a1935cf28fce075894b
* | instance UT: Recover mock_server_get.return_valueAkihiro Motoki2022-03-091-0/+1
| | | | | | | | | | | | | | https://review.opendev.org/c/openstack/horizon/+/830630 dropped mock_server_get.return_value by mistake. This commit recovers it. Change-Id: Icedb1d206aca1c8eeac51e76b3c92c26b40f0806
* | Merge "Add Python 3 only classifier"Zuul2022-03-082-0/+2
|\ \