diff options
author | Dmitry Tantsur <dtantsur@protonmail.com> | 2021-05-17 18:02:56 +0200 |
---|---|---|
committer | Dmitry Tantsur <dtantsur@protonmail.com> | 2021-05-18 12:59:28 +0200 |
commit | 51aa31070af9936ca6afa41678344cc4368359ef (patch) | |
tree | 6bd22457585445239d47cd76656ba795c6564145 | |
parent | 6fb4cec7aa0a3edc76b0e07cc9e7cc0b1d4a4e99 (diff) | |
download | ironic-python-agent-51aa31070af9936ca6afa41678344cc4368359ef.tar.gz |
Do not serialize command_params
The command params can be huge when configdrive is used. There is no
point in sending them back, Ironic does not use them anyhow.
Story: #2008904
Task: #42479
Change-Id: I6e3db5db2042ca3fb5dafacfacf036fd7fc2fc4c
-rw-r--r-- | ironic_python_agent/extensions/base.py | 2 | ||||
-rw-r--r-- | ironic_python_agent/tests/unit/test_agent.py | 6 | ||||
-rw-r--r-- | releasenotes/notes/command_params-869fa547b5be2236.yaml | 5 |
3 files changed, 6 insertions, 7 deletions
diff --git a/ironic_python_agent/extensions/base.py b/ironic_python_agent/extensions/base.py index 23e47c46..a158ee3c 100644 --- a/ironic_python_agent/extensions/base.py +++ b/ironic_python_agent/extensions/base.py @@ -42,7 +42,7 @@ class AgentCommandStatus(object): class BaseCommandResult(encoding.SerializableComparable): """Base class for command result.""" - serializable_fields = ('id', 'command_name', 'command_params', + serializable_fields = ('id', 'command_name', 'command_status', 'command_error', 'command_result') def __init__(self, command_name, command_params): diff --git a/ironic_python_agent/tests/unit/test_agent.py b/ironic_python_agent/tests/unit/test_agent.py index 22b010dd..646a852e 100644 --- a/ironic_python_agent/tests/unit/test_agent.py +++ b/ironic_python_agent/tests/unit/test_agent.py @@ -742,9 +742,6 @@ class TestBaseAgent(ironic_agent_base.IronicAgentTest): expected_result = { 'id': result.id, 'command_name': 'foo_command', - 'command_params': { - 'fail': False, - }, 'command_status': 'RUNNING', 'command_result': None, 'command_error': None, @@ -766,9 +763,6 @@ class TestBaseAgent(ironic_agent_base.IronicAgentTest): expected_result = { 'id': result.id, 'command_name': 'foo_command', - 'command_params': { - 'fail': True, - }, 'command_status': 'RUNNING', 'command_result': None, 'command_error': None, diff --git a/releasenotes/notes/command_params-869fa547b5be2236.yaml b/releasenotes/notes/command_params-869fa547b5be2236.yaml new file mode 100644 index 00000000..2526b39c --- /dev/null +++ b/releasenotes/notes/command_params-869fa547b5be2236.yaml @@ -0,0 +1,5 @@ +--- +fixes: + - | + The command params no longer appear in the command results. See `story + 2008904 <https://storyboard.openstack.org/#!/story/2008904>`_ for details. |