diff options
| author | Zuul <zuul@review.opendev.org> | 2021-05-18 14:58:42 +0000 |
|---|---|---|
| committer | Gerrit Code Review <review@openstack.org> | 2021-05-18 14:58:42 +0000 |
| commit | 6fc5a14760a298827e4f3c2229bd738dcfdd9e18 (patch) | |
| tree | 077440dc7de881d8722f8a4f77e146720d0bf966 | |
| parent | d6e4fbd8272bbd5129863c03712a3324eb7e48f9 (diff) | |
| parent | 51aa31070af9936ca6afa41678344cc4368359ef (diff) | |
| download | ironic-python-agent-6fc5a14760a298827e4f3c2229bd738dcfdd9e18.tar.gz | |
Merge "Do not serialize command_params"
| -rw-r--r-- | ironic_python_agent/extensions/base.py | 2 | ||||
| -rw-r--r-- | ironic_python_agent/tests/unit/test_agent.py | 6 | ||||
| -rw-r--r-- | releasenotes/notes/command_params-869fa547b5be2236.yaml | 5 |
3 files changed, 6 insertions, 7 deletions
diff --git a/ironic_python_agent/extensions/base.py b/ironic_python_agent/extensions/base.py index 23e47c46..a158ee3c 100644 --- a/ironic_python_agent/extensions/base.py +++ b/ironic_python_agent/extensions/base.py @@ -42,7 +42,7 @@ class AgentCommandStatus(object): class BaseCommandResult(encoding.SerializableComparable): """Base class for command result.""" - serializable_fields = ('id', 'command_name', 'command_params', + serializable_fields = ('id', 'command_name', 'command_status', 'command_error', 'command_result') def __init__(self, command_name, command_params): diff --git a/ironic_python_agent/tests/unit/test_agent.py b/ironic_python_agent/tests/unit/test_agent.py index 22b010dd..646a852e 100644 --- a/ironic_python_agent/tests/unit/test_agent.py +++ b/ironic_python_agent/tests/unit/test_agent.py @@ -742,9 +742,6 @@ class TestBaseAgent(ironic_agent_base.IronicAgentTest): expected_result = { 'id': result.id, 'command_name': 'foo_command', - 'command_params': { - 'fail': False, - }, 'command_status': 'RUNNING', 'command_result': None, 'command_error': None, @@ -766,9 +763,6 @@ class TestBaseAgent(ironic_agent_base.IronicAgentTest): expected_result = { 'id': result.id, 'command_name': 'foo_command', - 'command_params': { - 'fail': True, - }, 'command_status': 'RUNNING', 'command_result': None, 'command_error': None, diff --git a/releasenotes/notes/command_params-869fa547b5be2236.yaml b/releasenotes/notes/command_params-869fa547b5be2236.yaml new file mode 100644 index 00000000..2526b39c --- /dev/null +++ b/releasenotes/notes/command_params-869fa547b5be2236.yaml @@ -0,0 +1,5 @@ +--- +fixes: + - | + The command params no longer appear in the command results. See `story + 2008904 <https://storyboard.openstack.org/#!/story/2008904>`_ for details. |