diff options
| author | Doug Hellmann <dhellmann@redhat.com> | 2019-06-26 11:47:42 -0400 |
|---|---|---|
| committer | Julia Kreger <juliaashleykreger@gmail.com> | 2020-07-30 20:57:19 +0000 |
| commit | 8f8d4286b3d5b02bb6447a27536a2eb93f97f740 (patch) | |
| tree | dae6bad76dedbecd1e8e85eddcfd022cc60cf4c7 | |
| parent | 5a7cd9899821f0ca4654474e1ac6f565f671030f (diff) | |
| download | ironic-python-agent-8f8d4286b3d5b02bb6447a27536a2eb93f97f740.tar.gz | |
improve error messages during node lookup failures
The error messages reported on the console when the agent can't find
its node do not give enough information to debug the cause of the
failure. This change adds some basic details like the URL of the API
server and the addresses of the node being sought there.
Change-Id: Ia54faf05c80159d1d5fde0b222627c673f1cffe3
(cherry picked from commit f7740c7919584389e907f66bdfa1b4f31c75ead1)
| -rw-r--r-- | ironic_python_agent/ironic_api_client.py | 19 |
1 files changed, 15 insertions, 4 deletions
diff --git a/ironic_python_agent/ironic_api_client.py b/ironic_python_agent/ironic_api_client.py index 20779871..cadd6876 100644 --- a/ironic_python_agent/ironic_api_client.py +++ b/ironic_python_agent/ironic_api_client.py @@ -148,12 +148,19 @@ class APIClient(object): 'GET', self.lookup_api, headers=self._get_ironic_api_version_header(), params=params) - except Exception: - LOG.exception('Lookup failed') + except Exception as err: + LOG.exception( + 'Unhandled error looking up node with addresses %r at %s: %s', + params['addresses'], self.api_url, err, + ) return False if response.status_code != requests.codes.OK: - LOG.warning('Failure status code: %s', response.status_code) + LOG.warning( + 'Failed looking up node with addresses %r at %s, ' + 'status code: %s', + params['addresses'], self.api_url, response.status_code, + ) return False try: @@ -164,7 +171,11 @@ class APIClient(object): # Check for valid response data if 'node' not in content or 'uuid' not in content['node']: - LOG.warning('Got invalid node data from the API: %s', content) + LOG.warning( + 'Got invalid node data in response to query for node ' + 'with addresses %r from %s: %s', + params['addresses'], self.api_url, content, + ) return False if 'config' not in content: |