diff options
| author | Zuul <zuul@review.opendev.org> | 2020-08-09 12:12:24 +0000 |
|---|---|---|
| committer | Gerrit Code Review <review@openstack.org> | 2020-08-09 12:12:24 +0000 |
| commit | 86aead2f3540c0ded0b2141c99106b59f81f8aa6 (patch) | |
| tree | f0af3ada11d729ad2a8a212db62e9811ce4de326 | |
| parent | 9f6a5526143cdd36746d812ad9c8fe1be17b8fd4 (diff) | |
| parent | b549e791795b82b197520e3fdbd1b71a47738d52 (diff) | |
| download | ironic-python-agent-86aead2f3540c0ded0b2141c99106b59f81f8aa6.tar.gz | |
Merge "improve error messages during node lookup failures" into stable/stein
| -rw-r--r-- | ironic_python_agent/ironic_api_client.py | 19 |
1 files changed, 15 insertions, 4 deletions
diff --git a/ironic_python_agent/ironic_api_client.py b/ironic_python_agent/ironic_api_client.py index 20779871..cadd6876 100644 --- a/ironic_python_agent/ironic_api_client.py +++ b/ironic_python_agent/ironic_api_client.py @@ -148,12 +148,19 @@ class APIClient(object): 'GET', self.lookup_api, headers=self._get_ironic_api_version_header(), params=params) - except Exception: - LOG.exception('Lookup failed') + except Exception as err: + LOG.exception( + 'Unhandled error looking up node with addresses %r at %s: %s', + params['addresses'], self.api_url, err, + ) return False if response.status_code != requests.codes.OK: - LOG.warning('Failure status code: %s', response.status_code) + LOG.warning( + 'Failed looking up node with addresses %r at %s, ' + 'status code: %s', + params['addresses'], self.api_url, response.status_code, + ) return False try: @@ -164,7 +171,11 @@ class APIClient(object): # Check for valid response data if 'node' not in content or 'uuid' not in content['node']: - LOG.warning('Got invalid node data from the API: %s', content) + LOG.warning( + 'Got invalid node data in response to query for node ' + 'with addresses %r from %s: %s', + params['addresses'], self.api_url, content, + ) return False if 'config' not in content: |