summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDongcan Ye <hellochosen@gmail.com>2019-04-29 09:29:18 +0000
committerDongcan Ye <yedongcan@yeah.net>2019-05-08 02:06:29 +0000
commitb2f0539d9ca223e5186d05bd7f4a86a162bc377d (patch)
tree0b9f27ff894eb4db4be34e275b9fb6135d6a2a84
parent33384acabc79df2f8b7967a6600930b1bd3106ce (diff)
downloadironic-python-agent-b2f0539d9ca223e5186d05bd7f4a86a162bc377d.tar.gz
Add more channel number for detecting BMC IP address
IPMI SPEC[1] assignment channel number 1-11 for vendors implementation(We an search "Channel Numbers" in section 6.3). We met an baremetal product, like H3C, use number 8 as LAN channel. Current code limit channel number to 1~7, I think this can increase to 1~11. [1] https://www.intel.com/content/dam/www/public/us/en/documents/product-briefs/ipmi-second-gen-interface-spec-v2-rev1-1.pdf Change-Id: I63a6ff91d702b990ef09da13e6e2e269e7274cce Task: 30654 Story: 2005528 (cherry picked from commit 66d3c8e453a58c01740581079045e9b4368c4bde)
-rw-r--r--ironic_python_agent/hardware.py7
-rw-r--r--releasenotes/notes/add-more-lan-channels-8f5197ed5f057c25.yaml7
2 files changed, 11 insertions, 3 deletions
diff --git a/ironic_python_agent/hardware.py b/ironic_python_agent/hardware.py
index 92a9db54..e3cea844 100644
--- a/ironic_python_agent/hardware.py
+++ b/ironic_python_agent/hardware.py
@@ -1108,9 +1108,10 @@ class GenericHardwareManager(HardwareManager):
utils.try_execute('modprobe', 'ipmi_si')
try:
- # From all the channels 0-15, only 1-7 can be assigned to different
- # types of communication media and protocols and effectively used
- for channel in range(1, 8):
+ # From all the channels 0-15, only 1-11 can be assigned to
+ # different types of communication media and protocols and
+ # effectively used
+ for channel in range(1, 12):
out, e = utils.execute(
"ipmitool lan print {} | awk '/IP Address[ \\t]*:/"
" {{print $4}}'".format(channel), shell=True)
diff --git a/releasenotes/notes/add-more-lan-channels-8f5197ed5f057c25.yaml b/releasenotes/notes/add-more-lan-channels-8f5197ed5f057c25.yaml
new file mode 100644
index 00000000..b659e386
--- /dev/null
+++ b/releasenotes/notes/add-more-lan-channels-8f5197ed5f057c25.yaml
@@ -0,0 +1,7 @@
+---
+fixes:
+ - |
+ From IPMI specification v2.0, channel number 1-Bh(1-11) can
+ be used for various types of communications channels.
+ The respectively available channels depend on the specific
+ IPMI implementation for a specific server system.