summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDmitry Tantsur <dtantsur@protonmail.com>2021-08-27 12:19:23 +0200
committerDmitry Tantsur <dtantsur@protonmail.com>2021-08-27 12:19:28 +0200
commit07ff3b8bbc8c043ba1469aba1147bba81f8997ee (patch)
tree028b2d61a05160d35d56355a5f1576c33b8d9d10
parent438a1f44451ce3902971137e1a0427cd89897783 (diff)
downloadironic-python-agent-07ff3b8bbc8c043ba1469aba1147bba81f8997ee.tar.gz
Trivial: better debugging in list_all_block_devices
One debug message only specified "Skipping" without any details. Another did not log the whole line from lsblk. Fix both. Change-Id: I9f8f4edad88ba2df5abc6a45a74ebdb3c7afcf97
-rw-r--r--ironic_python_agent/hardware.py7
1 files changed, 5 insertions, 2 deletions
diff --git a/ironic_python_agent/hardware.py b/ironic_python_agent/hardware.py
index e963059f..fb743744 100644
--- a/ironic_python_agent/hardware.py
+++ b/ironic_python_agent/hardware.py
@@ -447,7 +447,7 @@ def list_all_block_devices(block_type='disk',
# media, however USB devices are also flagged as removable media.
# we have to explicitly do this as floppy disks are type disk.
if ignore_floppy and str(device.get('KNAME')).startswith('fd'):
- LOG.debug('Ignoring floppy disk device %s', device)
+ LOG.debug('Ignoring floppy disk device: %s', line)
continue
# Search for raid in the reply type, as RAID is a
@@ -456,7 +456,10 @@ def list_all_block_devices(block_type='disk',
# lvm, part, rom, loop
if devtype != block_type:
if devtype is None or ignore_raid:
- LOG.debug("Skipping: %s", line)
+ LOG.debug(
+ "TYPE did not match. Wanted: %(block_type)s but found: "
+ "%(line)s (RAID devices are ignored)",
+ {'block_type': block_type, 'line': line})
continue
elif ('raid' in devtype
and block_type in ['raid', 'disk']):