diff options
| author | Mark Goddard <mark@stackhpc.com> | 2022-06-24 16:47:18 +0100 |
|---|---|---|
| committer | Mark Goddard <mark@stackhpc.com> | 2022-12-12 15:07:12 +0000 |
| commit | de4cf64c1c156abdde05ca72eb06c200d625ebfc (patch) | |
| tree | ef3aab534253bbd123908584d96985a7ce09f0d7 | |
| parent | 57f1e5309ee90209611d0db0b71b7b1842b7043f (diff) | |
| download | ironic-python-agent-de4cf64c1c156abdde05ca72eb06c200d625ebfc.tar.gz | |
Warn when smartctl not found
Currently, if smartctl is not found by IPA, it will silently skip ATA
secure erase and proceed to shred (if enabled). This is supposedly for
backwards compatibility, but is quite hard to diagnose.
This change adds a warning message to make it more obvious what is
happening.
TrivialFix
Change-Id: I03a381e99de79f201ec7e9a388777c3d48457e93
(cherry picked from commit b68fa6b2e13774dbde5d0b81f6bf0b0095536aa4)
| -rw-r--r-- | ironic_python_agent/hardware.py | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/ironic_python_agent/hardware.py b/ironic_python_agent/hardware.py index bc0eeff9..07494d9c 100644 --- a/ironic_python_agent/hardware.py +++ b/ironic_python_agent/hardware.py @@ -1807,10 +1807,11 @@ class GenericHardwareManager(HardwareManager): 'ATA commands via the `smartctl` utility with device ' '%s do not succeed.', block_device.name) return False - except OSError: + except OSError as e: # Processutils can raise OSError if a path is not found, # and it is okay that we tollerate that since it was the # prior behavior. + LOG.warning('Unable to execute `smartctl` utility: %s', e) return True def _ata_erase(self, block_device): |