diff options
| author | Mark Goddard <mark@stackhpc.com> | 2022-06-24 16:47:18 +0100 |
|---|---|---|
| committer | Mark Goddard <mark@stackhpc.com> | 2022-06-24 16:58:37 +0100 |
| commit | b68fa6b2e13774dbde5d0b81f6bf0b0095536aa4 (patch) | |
| tree | 8b2cee7776b7cbe1e38d14685ffab927b8ef1676 | |
| parent | f08f70134d24a23355511e9c8feac9987f2e62e4 (diff) | |
| download | ironic-python-agent-b68fa6b2e13774dbde5d0b81f6bf0b0095536aa4.tar.gz | |
Warn when smartctl not found
Currently, if smartctl is not found by IPA, it will silently skip ATA
secure erase and proceed to shred (if enabled). This is supposedly for
backwards compatibility, but is quite hard to diagnose.
This change adds a warning message to make it more obvious what is
happening.
TrivialFix
Change-Id: I03a381e99de79f201ec7e9a388777c3d48457e93
| -rw-r--r-- | ironic_python_agent/hardware.py | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/ironic_python_agent/hardware.py b/ironic_python_agent/hardware.py index 54de8d72..c697911f 100644 --- a/ironic_python_agent/hardware.py +++ b/ironic_python_agent/hardware.py @@ -1653,10 +1653,11 @@ class GenericHardwareManager(HardwareManager): 'ATA commands via the `smartctl` utility with device ' '%s do not succeed.', block_device.name) return False - except OSError: + except OSError as e: # Processutils can raise OSError if a path is not found, # and it is okay that we tollerate that since it was the # prior behavior. + LOG.warning('Unable to execute `smartctl` utility: %s', e) return True def _ata_erase(self, block_device): |