diff options
author | Sam Betts <sam@code-smash.net> | 2017-02-15 16:31:33 +0000 |
---|---|---|
committer | Dmitry Tantsur <divius.inside@gmail.com> | 2018-05-24 12:29:27 +0200 |
commit | 3538cd6bc67e1ab8d904a5f96ec729ba50d5316d (patch) | |
tree | 216e438dd655807dd5098ecf7a34cdf56bdaf3b5 /releasenotes/notes/LLDP-ignore-NICs-that-are-not-plugged-in-29213f0a701a72e4.yaml | |
parent | 2cd1367451e5e27d1ca76be88f413bea675ba82a (diff) | |
download | ironic-python-agent-3538cd6bc67e1ab8d904a5f96ec729ba50d5316d.tar.gz |
[LLDP] Skip NICs that say they are ready but are unreadable.
While listening for LLDP packets, if one of the sockets marks itself as
ready to read then our code will try to read data from that socket, but
if something goes wrong while reading that data then it causes IPA to
raise out of the loop skipping any other of the other NICs which might
have worked. This patch adds code to catch and LOG any exception that is
raised while we are trying to read data from one of the sockets so that
we can proceed to process all the NICs.
Conflicts:
ironic_python_agent/tests/unit/test_netutils.py
Change-Id: I8546097f5ae23755a5fdb448902007a2d823b7bf
Closes-Bug: #1665025
(cherry picked from commit b536fbba616d958e58b110c8f86ea569f8834d7c)
Diffstat (limited to 'releasenotes/notes/LLDP-ignore-NICs-that-are-not-plugged-in-29213f0a701a72e4.yaml')
-rw-r--r-- | releasenotes/notes/LLDP-ignore-NICs-that-are-not-plugged-in-29213f0a701a72e4.yaml | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/releasenotes/notes/LLDP-ignore-NICs-that-are-not-plugged-in-29213f0a701a72e4.yaml b/releasenotes/notes/LLDP-ignore-NICs-that-are-not-plugged-in-29213f0a701a72e4.yaml new file mode 100644 index 00000000..1f54af9b --- /dev/null +++ b/releasenotes/notes/LLDP-ignore-NICs-that-are-not-plugged-in-29213f0a701a72e4.yaml @@ -0,0 +1,7 @@ +--- +fixes: + - | + Fixes bug in LLDP discovery code which lead to no LLDP information being + discovered for any network interface if one network interface raised an + exception, for example if the network interface incorrectly indicates its + ready to read. `<https://bugs.launchpad.net/ironic-python-agent/+bug/1665025>`_ |