summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Fix: make Intel CNA hardware manager none genericqueens-eolstable/queensQianbiao.NG2020-10-123-35/+35
| | | | | | | | | | | | | | Currently, IntelCnaHardwareManager inherits GenericHardwareManager which makes it a new "GenericHardwareManager" with "MAINLINE" priority. This causes all other hardware-managers with lower priority than "MAINLINE" never be used. To fix this, make IntelCnaHardwareManager inherit basic HardwareManager. Change-Id: I28b665d8841b0b2e83b132e1f25df95e03e7ba10 Story: 2008142 Task: 40882 (cherry picked from commit dc63d2f240698148e1de6c43251b89c7e5cfdf33) (cherry picked from commit fad38ee376b8fe7679f54c6ddfe984cd8f5ae6b7)
* Merge "Fix TypeError on agent lookup failure" into stable/queensZuul2020-08-093-4/+84
|\
| * Fix TypeError on agent lookup failureJulia Kreger2020-08-073-4/+84
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Agent lookups can fail as we presently use logging.exception, better known in our code as LOG.exception, which can also generate other fun issues on journald based systems where additional errors could be raised resulting in us being unable to troubleshoot the the actual issue. Because of the mis-use of LOG.exception and the default behavior of the backoff retry handler, the retry logic was also not functional as any error no matter how small caused IPA to just exit. Change-Id: Ic4608b7c6ff9773d1403926efb3d59869c71343b Story: 2007968 Task: 40465 (cherry picked from commit 5eab9bced63b2b9a6753cbbf594dda7ef9d03a3a) (cherry picked from commit e45ee3f64221962ad243f7df8bc123510c632935) (cherry picked from commit 9fe5cb92be3c3b0342612a0317e34254fc551cda) (cherry picked from commit 47a8ae6744fb80e3eb51fac4021d637e4379984a)
* | Merge "improve error messages during node lookup failures" into stable/queensZuul2020-08-091-4/+15
|\ \ | |/
| * improve error messages during node lookup failuresDoug Hellmann2020-07-301-4/+15
| | | | | | | | | | | | | | | | | | | | The error messages reported on the console when the agent can't find its node do not give enough information to debug the cause of the failure. This change adds some basic details like the URL of the API server and the addresses of the node being sought there. Change-Id: Ia54faf05c80159d1d5fde0b222627c673f1cffe3 (cherry picked from commit f7740c7919584389e907f66bdfa1b4f31c75ead1)
* | Pin Ironic Tempest PluginJulia Kreger2020-08-063-10/+7
|/ | | | | | | | | | | | | | | | | | | | | Pin the ironic-tempest-plugin to an older version so we don't run the net set of tests with wholedisk + partition testing. Also removes CoreOS jobs as CoreOS is EOL and no longer receiving any updates. And also signals to the user to try and manually install python-pip as opposed to install the package from the package manager as older mirrors have older versions at this point and we are risking breaking things by automatically doing so. This should fix test jobs on ubuntu-xenial as there is a conflict in the repositories. python-pip : Depends: python-pip-whl (= 8.1.1-2ubuntu0.4) but 9.0.1-3~3 is to be installed Change-Id: I6b689bd16dfe6fa849e876f056f1c5cfd1937764 (cherry picked from commit c7b3d9f062f6ca23c8a394aa528d5097d3b6b9f4)
* Fix compatibility with Pint 0.5queens-em3.2.4Dmitry Tantsur2019-09-252-1/+6
| | | | | | | Conversion from Quantity to int/long was added only in 0.5.2. Change-Id: I23f93d29a0624b77f4624c6af530971eb6a4c01b (cherry picked from commit 386654f602c86495515811dd741652a3b0292fd3)
* Merge "Stop logging lshw output, collect it with other logs instead" into ↵Zuul2019-07-034-5/+13
|\ | | | | | | stable/queens
| * Stop logging lshw output, collect it with other logs insteadDmitry Tantsur2019-06-184-5/+13
| | | | | | | | | | | | | | | | | | | | The lshw output is huge even on virtual machines, and it pollutes the debug logging. This change silences it. Instead, the lshw output is collected as part of the ramdisk logs. Depends-On: https://review.opendev.org/#/c/665635/ Change-Id: I6a3015b2d8d09f6f48b5cbd39dc84bd75b72f909 (cherry picked from commit 94048fe97e93af3ad6902c3c1aa4ec5d92b41747)
* | Correct formatting of a warning when lshw cannot be runDmitry Tantsur2019-06-271-1/+1
|/ | | | | Change-Id: I7c55aee4b3b52cb414a595cf548e1f22e954f619 (cherry picked from commit 69064a8610134f7e6777083375487f15f7dbbc7b)
* Merge "Fix download upper constraints" into stable/queens3.2.3Zuul2019-05-211-1/+1
|\
| * Fix download upper constraintsRiccardo Pittau2019-04-251-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | We use the url from tox.ini to download the upper constraints and recently that has changed to a redirect and curl doesn't correctly follows redirects by default but stops at the first page. Adding -L option to curl command makes curl follows the redirect until the final location is found and should allow the correct file to be downloaded. Change-Id: I25c724ffe189d414643c910be0ef61c550f802b7 (cherry picked from commit a88e61959bc41a10de5f58f8a1ffc34ae6f1e822)
* | Merge "Ironic python agent does not extract correct available memory" into ↵Zuul2019-05-213-12/+231
|\ \ | | | | | | | | | stable/queens
| * | Ironic python agent does not extract correct available memoryUros Orozel2019-04-163-12/+231
| | | | | | | | | | | | | | | | | | | | | | | | | | | This patch fixes parsing of memory class output of lshw output. Task: 30201 Story: 2005308 Change-Id: I0e7ff9f86a266d2f798457136fed0100c78569e2 (cherry picked from commit d8018b9f35172b22475984a921fadd439c5239cc)
* | | Merge "Bind mount /run into chroot when installing grub" into stable/queensZuul2019-05-213-1/+17
|\ \ \
| * | | Bind mount /run into chroot when installing grubDerek Higgins2019-05-083-1/+17
| | |/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | grub-mkconfig runs a lvs command that attempts to access /run/lvm once for each block device, currently it times out after 10 seconds for each device and moves on. Multiple 10 second delays become a problem (causing IPA API timeouts) when multiple block devices are present. Bind mounting in /run avoids the delay and the timeouts. Task: 30616 Story: 2005507 Change-Id: Iae8b7808a35bff121f64971aadd4bd36b5f5bb71 (cherry picked from commit 9c35f0279209ce233a7562f2d9310ded1e0edba5)
* | | Fixes for building images with CoreOSRiccardo Pittau2019-05-141-7/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This patch includes various fixes for building the IPA image using CoreOS: - switch to Debian Stretch as Jessie is no longer supported and its repo is not available anymore. - install setuptools into the environment explicitly, since some dependencies fail to install without it. - Remove metadata_csum option when creating filesystems since cirros doesn't support it. (cherry picked from commit ac4904ed960dabe94a4b6a3ceff9b4038e61f24f) (cherry picked from commit 4e086f9f0fa2cfdd215994c76025bdb7954e3610) Change-Id: I6772e455f5d1ee7587c2dc43203b02e5e54cb714
* | | Merge "Fetch upper constraints from opendev.org" into stable/queensZuul2019-04-291-1/+1
|\ \ \ | |/ / |/| |
| * | Fetch upper constraints from opendev.orgPavlo Shchelokovskyy2019-04-221-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | the imagebuild/common/generate_upper_constraints.sh is currently failing as the curl command in this file does not handle redirects. Instead of allowing redirects, use the proper current link to the upper constraints file. Change-Id: I92c5bfa65ba149687f61172c2a89ff38660a58cf (cherry picked from commit 93dae93d52c8eec10d4e94f16b460443075ec129)
* | | OpenDev Migration PatchOpenDev Sysadmins2019-04-1915-61/+61
| |/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | This commit was bulk generated and pushed by the OpenDev sysadmins as a part of the Git hosting and code review systems migration detailed in these mailing list posts: http://lists.openstack.org/pipermail/openstack-discuss/2019-March/003603.html http://lists.openstack.org/pipermail/openstack-discuss/2019-April/004920.html Attempts have been made to correct repository namespaces and hostnames based on simple pattern matching, but it's possible some were updated incorrectly or missed entirely. Please reach out to us via the contact information listed at https://opendev.org/ with any questions you may have.
* | Replace openstack.org git:// URLs with https://Ian Wienand2019-03-2413-25/+25
|/ | | | | | | | | | | | | | | | | This is a mechanically generated change to replace openstack.org git:// URLs with https:// equivalents. This is in aid of a planned future move of the git hosting infrastructure to a self-hosted instance of gitea (https://gitea.io), which does not support the git wire protocol at this stage. This update should result in no functional change. For more information see the thread at http://lists.openstack.org/pipermail/openstack-discuss/2019-March/003825.html Change-Id: I0725774c81b85b53d692bad1fb30220c44b25333
* Refuse secure erase if ATA command does not workJulia Kreger2019-02-215-3/+164
| | | | | | | | | | | | | | | | | | | | Adds dependency upon smartmontools's binary smartctl to query the block devices via ATA mode which fails on pass-thru buses such as ATA over SCSI and ATA over USB, in an effort to prevent the initiation of ATA secure erase with one of these interfaces in place which may render the disk unreachable after security options are enabled for ATA Secure Erase or upon the Secure Erase command being sent to the Hard Disk. Conflicts: Dockerfile Change-Id: I7635a197eb000650e919fac386b38ac15ef17041 Story: #2002546 Task: #22109 Depends-On: Ibbfd168844524d91927bdd6e67d973e0bd519bf2 (cherry picked from commit aef703b87995cc33087c972492c8b8723a76677e)
* Try to unlock failed device before proceedingJulia Kreger2019-02-213-22/+53
| | | | | | | | | | | | | When a hard error has occured with secure erase, we should attempt an unlock of the device becuase the current mode can prevent disk IO. This may upset some things like raid controllers even if they are in a pass-through mode. Change-Id: I32e1d962fbbb4a305d5dbebea92ac48ebd9b67ca Story: #2002546 Task: #22107 (cherry picked from commit 0f7b5a0896cf1b3080b7679278ff97a8dff0be80)
* rework ATA secure eraseWill Szumski2019-02-212-47/+105
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | hdparm versions prior to 9.51 interpret the value, NULL, as a password with string value: "NULL". Example output of hdparm with NULL password: [root@localhost ~]# hdparm --user-master u --security-unlock NULL /dev/sda security_password="NULL" /dev/sda: Issuing SECURITY_UNLOCK command, password="NULL", user=user SECURITY_UNLOCK: Input/output error Example output of hdparm with "" as password: [root@localhost ~]# hdparm --user-master u --security-unlock "" /dev/sda security_password="" /dev/sda: Issuing SECURITY_UNLOCK command, password="", user=user Note the values of security_password in the output above. The output was observed on a CentOS 7 system, which ships hdparm 9.43 in the offical repositories. This change attempts to unlock the drive with the empty string if an unlock with NULL was unsucessful. Issuing a security-unlock will cause a state transition from SEC4 (security enabled, locked, not frozen) to SEC5 (security enabled, unlocked, not frozen). In order to check that a password unlock attempt was successful it makes sense to check that the drive is in the unlocked state (a necessary condition for SEC5). Only after all unlock attempts fail, do we consider the drive out of our control. The conditions to check the drive is in the right state have been adjusted to ensure that the drive is in the SEC5 state prior to issuing a secure erase. Previously, on the "recovery from previous fail" path, the security state was asserted to be "not enabled" after an unlock - this could never have been the case. A good overview of the ATA security states can be found here: http://www.admin-magazine.com/Archive/2014/19/Using-the-ATA-security-features-of-modern-hard-disks-and-SSDs Change-Id: Ic24b706a04ff6c08d750b9e3d79eb79eab2952ad Story: 2001762 Task: 12161 Story: 2001763 Task: 12162 (cherry picked from commit aaf76e2cfb88c6cae50c8b46c65edce0a30e6a8f)
* Fix BMC IP address detection on CoreOS images3.2.2Pierre Riteau2018-10-222-1/+7
| | | | | | | | | | | | | | | | | | On CoreOS images, IPA runs in a Debian Jessie chroot which uses mawk as its default awk implementation. However, mawk doesn't support POSIX character classes such as [:space:], which means get_bmc_address() fails to parse the BMC IP address from the output of ipmitool. This patch replaces the use of [[:space:]] by [ \t] which is equivalent for the purpose of parsing the output of ipmitool. Note that matching on tab characters is not strictly required as the packaged version of ipmitool only uses space characters, but is left in case tabs are used in other versions. Change-Id: I0e3306a4d4584ca28e03608e9f7270b770960a39 Story: #2004121 Task: #27571 (cherry picked from commit 8eecadb0a8a36eb541b96d6d2fcce12dbb121181)
* Add missing dependencies to CoreOS IPA docker imagePierre Riteau2018-10-171-1/+2
| | | | | | | | | | | | | | | | | The iptables and lshw utilities are both required for IPA: iptables is used when collecting system logs and lshw is used to get the total physical memory and system details. However, they were not installed in the docker image embedded in CoreOS IPA images. Since the docker image is used as a chroot to run IPA, it cannot access binaries available outside in the main CoreOS file system. Conflicts: Dockerfile Change-Id: Ic2188b49e717c62315db6c33b74b2e161436b052 Story: #2004092 Task: #27494 (cherry picked from commit c6ea17d413ec5e379e7eb9dcef39f5181a36380c)
* import zuul job settings from project-configDoug Hellmann2018-08-161-0/+6
| | | | | | | | | | | | | | | | | | | | This is a mechanically generated patch to complete step 1 of moving the zuul job settings out of project-config and into each project repository. Because there will be a separate patch on each branch, the branch specifiers for branch-specific jobs have been removed. Because this patch is generated by a script, there may be some cosmetic changes to the layout of the YAML file(s) as the contents are normalized. See the python3-first goal document for details: https://governance.openstack.org/tc/goals/stein/python3-first.html Change-Id: Ib70576a4f4e91bee2a7063716eed60259bdf337f Story: #2002586 Task: #24302
* fix uname mock arguments for get-pip.pyJulia Kreger2018-07-251-0/+5
| | | | | Change-Id: I36b3c8c7b0dfca41db54490306f47ddbf8eec836 (cherry picked from commit baa076837d25bf7b2290211b248a0bbe5f48d55c)
* Switch from sourceforge to github for ipmitoolYolanda Robla2018-06-262-2/+9
| | | | | | | | | | | | | | Currently CI fails on build ipa image on xenial, because downloading with wget from sourceforce is giving SSL error. Start using the github mirror, that is not having this problem. Additionally added autoconf, autogen, automake, and libtool to the build requirements as the new ipmitool package is based off of repository commit history tags and did not contain a pregenerated configure file. Change-Id: I139679db835b7a87c55f69a4d807ff8ec9099e3a (cherry picked from commit 80be07ae791980a1c444b3b0d685775c1688ca34)
* Merge "Stop using slave_scripts/install-distro-packages.sh" into stable/queens3.2.1Zuul2018-06-112-10/+6
|\
| * Stop using slave_scripts/install-distro-packages.shPaul Belanger2018-06-052-10/+6
| | | | | | | | | | | | | | | | | | | | Migrate the legacy job to start using our bindep role from zuul-jobs. This will allow openstack-infra to delete slave_scripts/install-distro-packages.sh in the future. Change-Id: If4a5b5c1d85e1491c1544378479c0fc82ad2af03 Signed-off-by: Paul Belanger <pabelanger@redhat.com> (cherry picked from commit ec9369b1679a49b365fa914527f47c9b59a986d5)
* | Fix for fatal error when GPT was used and only MBR was cleanedOlivier Bourdon2018-06-081-1/+1
|/ | | | | | | | | | | | | | | | | | You can generate this error if after having provisioned a node using GPT partitioning, you clean its MBR using say dd if=/dev/zero bs=1024 count=1 of=/dev/sda and then cleanup all Ironic/Bifrost informations to get it reprovisioned. In this case sgdisk -Z returns an error and last_error field in Ironic contains: Error writing image to device: Writing image to device /dev/sda failed with exit code 2 Caution: invalid main GPT header, but valid backup; regenerating main header\nfrom backup!\n \nInvalid partition data!\ Change-Id: Ib617737fff5e40cb376edda0232e0726d9c71231 (cherry picked from commit 5fcf3f066ccdbcc081ae35ab25f1c18737b94778)
* Fix Dockerfile for Debian JessieJulia Kreger2018-06-011-3/+4
| | | | | | | | | | | As we learned in I488445dfd261b7bca322a0be7b4d8ca6105750a3 that the the docker file needed to change, this is a targeted change to address the docker file contents and not update the coreos version that is built. This is being done to fix the stable branch builds. Change-Id: I7251dc7deac788716adad7b596f25fd1633cf289
* Gate fix: Cap hacking to avoid gate failureghanshyam2018-05-272-2/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | hacking is not capped in g-r and it is in blacklist for requirement as hacking new version can break the gate jobs. Hacking can break gate jobs because of various reasons: - There might be new rule addition in hacking - Some rules becomes default from non-default - Updates in pycodestyle etc That was the main reason it was not added in g-r auto sync also. Most of the project maintained the compatible and cap the hacking version in test-requirements.txt and update to new version when project is ready. Bumping new version might need code fix also on project side depends on what new in that version. If project does not have cap the hacking version then, there is possibility of gate failure whenever new hacking version is released by QA team. Example of such failure in recent release of hacking 1.1.0 - http://lists.openstack.org/pipermail/openstack-dev/2018-May/130282.html Also includes commit c09634ad80988e960af2bcaca737be3e87ba7592 from master to ignore W503, otherwise the CI does not pass. Change-Id: I2c84d3368bd6675c28ebba695e0c1afdd2867588 (cherry picked from commit a69ccee2879abe3ac658f3fcbb564b254d84803d) (cherry picked from commit c09634ad80988e960af2bcaca737be3e87ba7592)
* Update UPPER_CONSTRAINTS_FILE for stable/queensOpenStack Release Bot2018-02-081-1/+1
| | | | | | | | | | | | | | | | | | The new stable upper-constraints file is only available after the openstack/requirements repository is branched. This will happen around the RC1 timeframe. Recheck and merge this change once the requirements repository has been branched. The CI system will work with this patch before the requirements repository is branched because zuul configues the job to run with a local copy of the file and defaults to the master branch. However, accepting the patch will break the test configuration on developers' local systems, so please wait until after the requirements repository is branched to merge the patch. Change-Id: I242e6fac493b710e4c61d80f8b594a6c84277fa3
* Update .gitreview for stable/queensOpenStack Release Bot2018-02-081-0/+1
| | | | Change-Id: I59affec52aa71d5f8b515f01899e655f0985d786
* Merge "When ouputting to /dev/null should open in write mode"3.2.0Zuul2018-02-071-1/+1
|\
| * When ouputting to /dev/null should open in write modeJohn L. Villalovos2018-02-061-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | Even though it was working opening the file in 'read' mode, it really should be opened in 'write' mode, since we are redirecting the output to the file. Interestingly it does fail in 'read' mode if the command is: echo something But passes in 'write' mode. Change-Id: Ic67091881e0be377e527b78d270ab48962881ae0
* | Merge "Replace curly quotes with straight quotes"Zuul2018-02-071-1/+1
|\ \
| * | Replace curly quotes with straight quotesmelissaml2018-01-261-1/+1
| | | | | | | | | | | | | | | | | | | | | Curly quotes usually input from Chinese input method. When read from english context, it makes some confusion. Change-Id: Ife984be980a4235d9b14152143e2b3540e414751
* | | Merge "Add documentation for rescue mode"Zuul2018-02-074-0/+94
|\ \ \
| * | | Add documentation for rescue modeMario Villaplana2018-02-074-0/+94
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This adds documentation for rescue mode, including the finalize_rescue command as well as upstream support in agent images. Change-Id: Id0834941ee4dacf2e7c0feaa65126d63e8a97c39 Partial-Bug: 1526449
* | | | Merge "Replace use of functools.wraps() with six.wraps()"Zuul2018-02-061-2/+2
|\ \ \ \ | |/ / / |/| | / | | |/ | |/|
| * | Replace use of functools.wraps() with six.wraps()John L. Villalovos2018-02-011-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In Python 2.7, functools.wraps() does not provide the '__wrapped__' attribute. This attribute is used by oslo_utils.reflection.get_signature() when getting the signature of a function. If a function is decorated without the '__wrapped__' attribute then the signature will be of the decorator rather than the underlying function. From the six documentation for six.wraps(): This is exactly the functools.wraps() decorator, but it sets the __wrapped__ attribute on what it decorates as functools.wraps() does on Python versions after 3.2. Change-Id: Ic0f7a6be9bc3e474a0229b264d1bfe6c8f7e6d85
* | | Merge "Adds a releasenote for DHCP support for TinyIPA"Zuul2018-02-011-0/+5
|\ \ \
| * | | Adds a releasenote for DHCP support for TinyIPAAnup Navare2018-01-311-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | Followup patch to add a releasenote for DHCP support in TinyIPA. Change-Id: I615ea0563b1f01feaf70fb9ed965762c5e01b5dc
* | | | Merge "Use lshw in place of dmidecode for the default hardware manager"Zuul2018-02-015-92/+195
|\ \ \ \ | |/ / / |/| | |
| * | | Use lshw in place of dmidecode for the default hardware managerMike Turek2018-01-305-92/+195
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently the generic hardware manager uses dmidecode to get the total physical memory and system details. This patch switches the generic hardware manager to use lshw, as it is capable of reading more than DMI [0]. This enables systems that do not support DMI to use the generic hardware manager, such as IBM Power systems. [0] https://github.com/lyonel/lshw/blob/master/README.md Closes-Bug: #1715790 Change-Id: Ie370331df6bb5ef131c5cb60f458877e2a7ad71a Depends-On: Idaf05b8efce28cd0cbf339cf693db4f55a693d9b
* | | | Merge "Zuul: Remove project name"Zuul2018-01-311-1/+0
|\ \ \ \ | |_|/ / |/| | |
| * | | Zuul: Remove project nameJames E. Blair2018-01-291-1/+0
| | |/ | |/| | | | | | | | | | | | | | | | Zuul no longer requires the project-name for in-repo configuration. Omitting it makes forking or renaming projects easier. Change-Id: Id109926ebe6e44c637f56e52fee30f3dbd4b79df