summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Make reno ignore bugfix eol tagsstable/ussuriJay Faulkner2023-01-261-0/+2
| | | | | | | | | | Reno was assuming all tags ending in -eol represented an old, EOL'd stable branch. That's not true for Ironic projects which have bugfix branches. Update the regexp to exclude those branches. Co-Authored-By: Adam McArthur <adam@mcaq.me> Change-Id: I265969ab40a98a02962c2fc8460b6519ab576f99 (cherry picked from commit f8fc7e52f36de5c3515e60f5d2e6347a538a80d8)
* Merge "WIP Drop python2 from bindep.txt" into stable/ussuriZuul2022-12-151-3/+1
|\
| * WIP Drop python2 from bindep.txtPavlo Shchelokovskyy2022-10-261-3/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | IPA dropped support for Python2 long ago, and now Python2 is not even available in newer distros, breaking installation if IPA binary dependencies. WIP because we should consider switching the check-requirements job to use a bionic node instead of jammy, or remove it entirely Change-Id: I75a618f94de58f6de2bd96b37de1894bb0e61998 (cherry picked from commit d8a6bf5f61eb1365294c6c07840286f46c9535fc) (cherry picked from commit 5cc653cbfe32699c9940d34842d5b4a5e2fe35a0) (cherry picked from commit b62f13aeb776b9d6995b623d802ebaf3a20e3879) (cherry picked from commit 25bcef86b52c2a7458c1197133ed0c07191108e4) (cherry picked from commit 107c0e3ea34cabe6eaf15e8bf76b99f4868c78fb)
* | Use utf-16-le if BOM not presentRiccardo Pittau2022-10-132-2/+14
|/ | | | | | | | | | | | | | In case no BOM is present in the CSV file the utf-16 codec won't work. We fail over to utf-16-le as Little Endian is commonly used. NOTE: The original change landed this fix in efi_utils.py, however that was introduced after the Xena development cycle, so this backport moves the original change to where the code originally came from to populate the efi_utils.py file. Change-Id: I3e25ce4997f5dd3df87caba753daced65838f85a (cherry picked from commit 697fa6f3b6db10408eaadd57450456de87f13519) (cherry picked from commit 99b9d1403cacd3bbd489a6cf6913f32746ef6083)
* CI: Zuul no longer respects queue paramJay Faulkner2022-10-031-1/+0
| | | | Change-Id: I1e7a3b3c9ded13b10002bb47e98d4a7b486e1dd4
* Re-read the partition table with partx -a, part 2ussuri-em6.1.3Riccardo Pittau2021-12-153-43/+50
| | | | | | | | | | | | | | Use add instead of update to re-read the partition table with partx. See [1] for more details. Co-authored-by: Arne Wiebalck <arne.wiebalck@cern.ch> [1] https: //opendev.org/openstack/ironic-python-agent/commit/dc8c1f16f9a00e2bff21612d1a9cf0ea0f3addf0 Change-Id: I2336e22dadc790cfbde87904612fcaa3b8c501db (cherry picked from commit 23e67b5fea58295d0320f99d4513a66d720f09ee) (cherry picked from commit 56e63ce36a72448e128c01605d98492c80dca38f)
* Re-read the partition table with partx -aArne Wiebalck2021-12-153-15/+20
| | | | | | | | | | | | | Re-read the partition table with 'partx -a', rather than 'partx -u'. This should fix an timing issue where the bootloader installation fails to mount the EFI partition from a whole disk image since it is not yet aware of the new partitions (observed with both, the iscsi and the direct deploy interface). Change-Id: If5da3075e813ae01df3decf8f0647aba111b0515 (cherry picked from commit dc8c1f16f9a00e2bff21612d1a9cf0ea0f3addf0) (cherry picked from commit ab3e8a75badf2719602b2416af9e3c19d7511c79)
* Fix UEFI record regexJulia Kreger2021-11-193-6/+76
| | | | | | | | | | | | | | | | I accidently put colons on the test data and remembered taking the colon character out of the regex I was working on, but apparently left it in, and accounted for the active entry indicator flag which appears to have inconsistent support across vendors. The regex has been fixed, and a test added from a Lenovo SR650 which has some additional string entry data in the UEFI output which may separate entries. Change-Id: I1f67b0fb1f645fa82e98bd7c7bba3ffc7755cc74 (cherry picked from commit e10f052c06c03016b0ff4d9c1f3191c79fc50a1a) (cherry picked from commit 87a30ff4fa93e710efa2f9eeb227c779d40c16af) (cherry picked from commit 25f89e4d8859ec1a3e811c3d916cf49d603754fc)
* Delete EFI boot entry duplicate labels firstJulia Kreger2021-11-193-24/+51
| | | | | | | | | | | | | | | | | | | | | | | | | | | Some firmware seems to take an objection with EFI nvram entries being deleted after one is added, resulting in the entire entry table being reset to the last known good state. This is problematic, as ultimately deployments can time out if we previously booted with Networking, and the machine, while commanded to do other wise, reboots back to networking regardless. We will now delete entries first, before proceeding. Additionally, for general use, this pattern may serve the community better by avoiding cases where we would have previously just relied upon efibootmgr[0] to warn us of duplicate entries. [0]: https://github.com/rhboot/efibootmgr/blob/103aa22ece98f09fe3ea2a0c83988f0ee2d0e5a8/src/efibootmgr.c#L228 Change-Id: Ib61a7100a059e79a8b0901fd8f46b9bc41d657dc Story: 2009649 Task: 43808 (cherry picked from commit 67eddfa7e3fedbb530045f5b43a2c89db832fa2a) (cherry picked from commit 33b39705a50513c5af411216b48e2a6f6ac9ab14) (cherry picked from commit 8fca1457399ac7892427fac1b9ab74a4ac653f05) (cherry picked from commit 47ac40a7f943d0ce6e58f43330a73ac144c23aa1)
* Output verbose info from efibootmgrDerek Higgins2021-11-182-22/+22
| | | | | | | | | | | When debugging boot manager problems it can be advantageous to see all the full entries rather then just their labels. Depends-On: https://review.opendev.org/c/openstack/ironic/+/818394 Change-Id: I6a1bb78acaf5a4284727bdf533d4be6db2099f50 (cherry picked from commit caf695f70ab366498b46cb6f07f6751369c67e30) (cherry picked from commit 9753b61a51008da4f0b948b0c89665b762eb95c4) (cherry picked from commit 750934a20794efdcfe8340eec75996466c4c7665)
* Fix getting memory size in some lshw output6.1.2Zane Bitter2021-06-253-7/+210
| | | | | | | | | | | | | | | | | | | | | | | | | | Due to a regression in lshw introduced by https://github.com/lyonel/lshw/pull/60, there are some versions in the wild that do not return sizes for memory banks <32GiB. In those cases, work around the problem by looking at the top-level size (if available) to find the total size. Previously we assumed that we only needed the top-level size when there was no list of memory banks. The issue is fixed upstream by https://github.com/lyonel/lshw/pull/65, but the erroneous patch is still present in the lshw-B.02.19.2-5.el8 package in CentOS 8.4 and 8.5. Note from Backport to Victoria branch: The stable test data was moved sometime during the Wallaby development cycle to a separate file, where as in Victoria and earlier, it is based in the test file itself. The required content was moved into the test file in line with where it was in the later versions. Change-Id: I6eb5981d28b9ae368239af0c1d0ec32ff79d95b3 Story: #2008865 Task: 42395 (cherry picked from commit ed791d97786f4ed37bf7b9f18eac8e2af46c3766) (cherry picked from commit bae3aec172df5b6ca9d609f29ea9feb9f6d11f13) (cherry picked from commit 97ce08d039099f569c48a2348c784e71e3693829)
* Add function to calculate memoryRiccardo Pittau2021-06-251-16/+22
| | | | | | | Move logic to calculate memory to its own function. Change-Id: I5ab98b6450ff45dff35ddae093a83140f37047a8 (cherry picked from commit 2738e57f2a6cacd44cf78331d6d77f3ae9f6a254)
* Reduce logging verbosity when collecting logsDmitry Tantsur2021-06-141-2/+1
| | | | | | | | | It's not uncommon that some commands fail when collecting logs. We already log all failures in utils.execute, no need to duplicate them with a non-fatal ERROR logging. Change-Id: If151b3a3be979bd2b3ce01030e5d6242ad74eaa3 (cherry picked from commit 2fcf35e56d578d98d77ffc97b6441f83548d7704)
* Utilize CSV file for EFI loader selectionJulia Kreger2021-06-113-14/+137
| | | | | | | | | | | | | | | | | | | | | | | | | Adds support to identify and utilize a CSV file to signal which bootloader to utilize, and set it when the OS is running as opposed to when EFI is running. This works around EFI loader potentially crashing some vendors hardware types when entry stored in the image does not match the EFI loader record which was utilzied to boot. Grub2+shim specifically specifically needs the CSV file name and entry label to match what the system was booted with in order to prevent the machine from potentially crashing. See https://storyboard.openstack.org/#!/story/2008962 and https://bugzilla.redhat.com/show_bug.cgi?id=1966129#c37 for more information. Change-Id: Ibf1ef4fe0764c0a6f1a39cb7eebc23ecc0ee177d Story: 2008962 Task: 42598 Co-Authored-By: Bob Fournier <bfournie@redhat.com> (cherry picked from commit 2fab70c36ba40a345a9dd01aeb5019681e567aa5) (cherry picked from commit bfa97cbbc2040d56bd0db14d1e1b83bb14f1a74c) (cherry picked from commit 474d2a91b06942a72c59d0f25ddd65fc255a3d16)
* Make _get_efi_bootloaders return relative pathsSteve Baker2021-06-112-16/+27
| | | | | | | | | | | | | | | | | | To make this function useful for purposes other than efibootmgr entries, this change moves the path manipulation to _run_efibootmgr. This change also adds boot*.efi entries to BOOTLOADERS_EFI so that it includes every entry in the UEFI Spec 2.9[1] Table 3-2 UEFI Image Types. [1] https://uefi.org/sites/default/files/resources/UEFI_Spec_2_9_2021_03_18.pdf Story: 2008923 Task: 42521 Change-Id: Ibe02786609aa0de65115897d8f4a9b4f36c8aed2 (cherry picked from commit 10d18c41136cc645ee99d41acfb6031b9158e1fb) (cherry picked from commit d61b7bd843fa821ce383b15dcb2085789972c91f) (cherry picked from commit 350a67e203f678d66e3ea1b8acc436394fc42f1a)
* Limit qemu-img execution arenasJulia Kreger2021-06-012-0/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | qemu-img attempts to launch multiple threads by default *and* attempts to have multiple memory allocation arenas to operate from. While multithreading can be good for performance, this pattern and the memory footprint for process launch and dependencies can turn the memory footprint for a cirros image conversion (16MB) into 1.2GB of memory being asked for by the qemu-img tool. In order to limit this impact, as the default number of arenas is governed by the number of CPUs times the number 8, it seems reasonable to lower this to a more reasonable number which also helps keep our possible memory footprint from being exceeded. NOTE: This change is largely different than the original change as an intermediate change converted write_image.sh to python. As it is unlikely for us to backport the intermediate change, it is logical for us to just modify the original script. Otherwise the release note is ultimately what is backported for release note tooling continutity. Change-Id: I71a28ec59ec31c691205eb34d9fcab63a2ccb682 Story: 2008928 Task: 42528 (cherry picked from commit 9e4c7052a2fd9aac03858db696bf1ea9487f15e6) (cherry picked from commit 9c20cca36284a2a17aa535bef92c828096c7d926) (cherry picked from commit ee8118423b88f61ed58b0420356ceaed2fa53a40)
* Increase the memory limit for qemu-imgDerek Higgins2021-06-012-2/+9
| | | | | | | | | | | | | | | | | We appear to be bumping up against this limit when deploying RHCOS images(currently 977MB). Curiously the problem isn't happening all the time but increasing the limit eliminates it. This limit was intruduced to guard against a malicious image allocating an arbitrary amount of memory. Nothing else runs on hosts when IPA is running so we should be ok bumping up the limit. Story: #2008667 Task: #41955 Change-Id: I9405995915a874b00b7177c9642c5469d05d66a8 (cherry picked from commit 5492ad7da59571581e9f70fd054efafb39e12593) (cherry picked from commit de1e75126a09db9d27bfb4d77a3d2eab99c66c0c)
* Fix NVMe Partition image on UEFIJulia Kreger2021-05-263-1/+51
| | | | | | | | | | | | | | | | | | | | | | | | The _manage_uefi code has a check where it attempts to just identify the precise partition number of the device, in order for configuration to be parsed and passed. However, the same code did not handle the existence of a `p1` partition instead of just a partition #1. This is because the device naming format is different with NVMe and Software RAID. Likely, this wasn't an issue with software raid due to how complex the code interaction is, but the docs also indicate to use only whole disk images in that case. This patch was pulled down my one RH's professional services folks who has confirmed it does indeed fix the issue at hand. This is noted as a public comment on the Red Hat bugzilla. https://bugzilla.redhat.com/show_bug.cgi?id=1954096 Story: 2008881 Task: 42426 Related: rhbz#1954096 Change-Id: Ie3bd49add9a57fabbcdcbae4b73309066b620d02 (cherry picked from commit fe825fa97ed1f3c9fa8b1461b63ab133fec20b72)
* Add fstab pointer to EFI partitionJulia Kreger2021-03-233-7/+271
| | | | | | | | | | | | | | | Adds support for the EFI partition to be appended to fstab so the filesystem can be automounted and EFI loader updated should the deployed operating system need to do so. This should enable bootloaders to be upgraded by linux based operating systems after the instance has been deployed when a partition image was utilized for the initial deployment. Change-Id: Iec28a8841cc01ec8b01a3f5cca070c934c7a2531 Story: 2008070 Task: 40754 (cherry picked from commit a12a5744b66063816af17769f99ec3f03da0a2d5)
* Prevent broken partition image UEFI deploysJulia Kreger2021-03-233-68/+774
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Partition images can sometimes contain a /boot folder structure event he assets for EFI booting on that filesystem. Which is a good thing. The conundrum is that Ironic does not handle this properly and potentially replaces the bootloader in this sequence such that grub2-install is used instead of signed bootloader assets. As such, we should be preserving the assets and using them from a partition image much like we do when we have a wholedisk image and can identify the assets. Now we will preserve the EFI boot assets, copy them to the new EFI boot partition, and call the EFI setup methods to manage the EFI nvram. Note, this change also splits the logic path out that performs the end call of the EFI boot manager into a reusable method but does not retool all of the testing as it is intertwined in the install_grub2 testing. Also adds some additional debug logging, as much of the bootloader installation code has multiple fallback/cleanup points which makes it difficult to debug from logs. Story: 2008070 Task: 40753 Change-Id: If17d4b4c06df5504987e61a1fde6662e9acd6989 (cherry picked from commit f9870d58120a493c40493df6ef22662364138c31)
* Option to enable bootloader config failure bypassJulia Kreger2021-03-234-10/+184
| | | | | | | | | | | | | | | | | | | | | Some hardware is very well intentioned. However this intention can result in the UEFI NVRAM table being full which prevents us from adding new records to the table. We can't be sure what to delete, so in this case some operators just need the ability to tell ironic "it is okay if this fails, it will still work." The added ``ignore_bootloader_failure`` option adds this capability which can be set per-node either in the agent configuation via the ramdisk image, or in the pxe_append_params configuration parameter for the node itself with a ``ipa-ignore-bootloader-failure`` option in order to prevent the failure from being raised. Change-Id: If3c83fb2ea2025fce092d495a64f32077c70d2d6 Story: 2008386 Task: 41309 (cherry picked from commit 7a83773fbc9800217a0364c72b8ca9f823a60519) (cherry picked from commit 07cf2c1b7921f37adf0dbf633fd0efed07ddbfd8)
* More refactoring of the image moduleRiccardo Pittau2021-03-231-39/+32
| | | | | | | | Introducing new function _umount_all_partitions to reduce the size of _install_grub2 Change-Id: I304468d57b10d677f2a9d58aec42a1bf414c6cba (cherry picked from commit 80e11811f5edf86c7fca28d3f3bca8cf42f87621)
* Mount all vfat partitions before calling grub2Arne Wiebalck2021-03-232-6/+73
| | | | | | | | | | In order to ensure grub2 finds all files it needs, mount all vfat partitions specified in the deployed image. Story: #2007618 Task: #39629 Change-Id: Ie5b6e0abc3f266409562f9ecb26538126b667056 (cherry picked from commit c5022790b3dca80c009e914aa07f3f879cd159b4)
* Refactor part of image moduleRiccardo Pittau2021-03-231-27/+32
| | | | | | | | Shuffle some functions around and reduce size of _is_bootloader_loaded moving logic out to a new function. Change-Id: I9c10bf05186dcebb37f175d61bf4ac9ff86b6510 (cherry picked from commit 9d9a6bce5c246d18d50dc405265e865fb77142eb)
* Re-enable the ussuri tinyipa jobsRiccardo Pittau2021-03-171-9/+3
| | | | | | They use the definition from ipa-builder now. Change-Id: Ia069e1488f7f52659308e13f9e26321b1fac2570
* Prepare to use ussuri jobs from ipa-builderRiccardo Pittau2021-03-152-19/+9
| | | | | | | | | Temporary remove the tinyipa ussuri jobs definitions. We need to add them back once [0] merges. [0] https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/780556 Change-Id: Ie073f34384be29e5e5fd61ca760ddcf33d7dbb19
* Use UPPER_CONSTRAINTS_FILE to deal with ipa-builderRiccardo Pittau2021-03-023-4/+11
| | | | | | | | | | | The generate_upper_constraints.sh script in ipa-builder 2.2.0 still uses UPPER_CONSTRAINTS_FILE as fallback to get the upper constraints file. Also remove duplicate option in ironic-ipa-dib-base and use bionic for the tinyipa jobs so we're sure to use the correct kernel when building the ipa ramdisk. Change-Id: I1883dc3b1b290f1f2f60dad5e5af57ceffba9d14
* Pin version of ipa-builder when publishing imageRiccardo Pittau2021-03-012-1/+8
| | | | | | | | | | | | | The ironic-python-agent-build-image-tinyipa job from ipa-builder comes from master branch and it will use that branch to build all the tinyipa ramdisks. For compatibility reasons with the base version of tinycore used to build tinyipa, we need to pin the ipa-builder code to tag 2.2.0 as ussuri CI is based on bionic and it won't support the new kernel used in tinycore 11.x when we need to chroot to modify the image during CI jobs like ironic-standalone. Change-Id: I60682d7e1d83793fb9dc3df4398e8e6f17438f98
* Software RAID: Get component devices by md UUIDArne Wiebalck2021-02-273-20/+152
| | | | | | | | | | | | | | Scanning the output of mdadm commands for RAID members will miss component devices which are currently not part of the RAID. For proper cleaning it is better to scan block devices for a signature of the md device for which we would like to get the components. Story: #2008186 Task: #40947 Change-Id: Ib46612697851e36a16d272ccaeb0115106253863 (cherry picked from commit 044c64dbc0ccf166368ae364b48289420e8674ed)
* Merge "Remove lower-constraints job" into stable/ussuriZuul2020-12-182-2/+9
|\
| * Remove lower-constraints jobRiccardo Pittau2020-12-172-2/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | As discussed during the upstream ironic community meeting on Monday Dec 14 2020, the lower-constraints job is being removed. Also Cap version of ipa-builder to 2.2.0 Versions higher than 2.2.0 of ironic-python-agent-builder use tinycore 11.x to build tinyipa, and that uses a kernel too recent to be built on bionic. Change-Id: Ide0f6c38a59ae6486fa33cfb19b383d022e57d5a (cherry picked from commit 78b356cd44907287af60412113e1e15fe4ccaf0a) (cherry picked from commit 95e1cd54cbe3a76dbe581a4283fe989463429d75)
* | Log a warning of target_boot_mode does not match current boot modeDmitry Tantsur2020-10-081-0/+8
| | | | | | | | | | | | | | This is not a normal situation and is likely to cause problems. Change-Id: Id0668fd160ac0539d85997e985f8c43d9da75c90 (cherry picked from commit 1a67dddde7cad5a27e303a56bdeb484798bc796d)
* | Merge "CI: Lower memory usage of VMs/Increase swap" into stable/ussuriZuul2020-10-071-0/+2
|\ \
| * | CI: Lower memory usage of VMs/Increase swapJulia Kreger2020-09-231-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The IPA images we presently build/use for centos are now smaller than their peak size a few months ago. As such, we should be able to reduce that memory footprint and still execcute all of the necessary tests without any issues. Also increases the amount of swap to 8GB as the infra default is now 1GB. Change-Id: I5705f1f2504803a049ed88a0d8b1d6d0bbccf9e4 (cherry picked from commit afb521d18ea6347fa6c39afa4785bf4a2fa04cc6)
* | | Merge "Fix: make Intel CNA hardware manager none generic" into stable/ussuriZuul2020-10-043-33/+31
|\ \ \
| * | | Fix: make Intel CNA hardware manager none genericQianbiao.NG2020-09-233-33/+31
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently, IntelCnaHardwareManager inherits GenericHardwareManager which makes it a new "GenericHardwareManager" with "MAINLINE" priority. This causes all other hardware-managers with lower priority than "MAINLINE" never be used. To fix this, make IntelCnaHardwareManager inherit basic HardwareManager. Change-Id: I28b665d8841b0b2e83b132e1f25df95e03e7ba10 Story: 2008142 Task: 40882 (cherry picked from commit 4b0ef13d0812f4302e7b9ad08d94a04be4729583)
* | | Software RAID: Don't delete partitions too earlyArne Wiebalck2020-09-293-12/+27
|/ / | | | | | | | | | | | | | | | | | | | | Partions on the holder disk should only be deleted after all RAID devices have been deleted. Otherwise, super blocks on partitions which reside on the same disks cannot be cleaned. Story: #2008199 Task: #40979 Change-Id: I19293f5b992cd1fa68957d6f306dcec8f3b7a820 (cherry picked from commit c7aec775ff5530e2c0407d8de49f15e8150f9248)
* | Merge "Make WSGI server respect listen_* directives" into stable/ussuriZuul2020-09-033-7/+58
|\ \
| * | Make WSGI server respect listen_* directivesJay Faulkner2020-09-023-7/+58
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The listen_port and listen_host directives are intended to allow deployers of IPA to change the port and host IPA listens on. These configs have not been obeyed since the migration to the oslo.service wsgi server. Story: 2008016 Task: 40668 Change-Id: I76235a6e6ffdf80a0f5476f577b055223cdf1585 (cherry picked from commit 7d0ad36ebd350a7162bc3c33bbefd26b9e962a78)
* | | Increase memory for tinyipa jobsRiccardo Pittau2020-08-241-1/+1
|/ / | | | | | | | | | | | | | | Tinyipa is not that tiny anymore and we need to increase the base memory for VMs in jobs that use it. Change-Id: I7e2d93ef566f4f2beb54caf445c7810a01aec1de (cherry picked from commit 2a5ba7ef68db8b09a62e36943be75ef29c62ef54)
* | Merge "Fix bootloader install issue with MDRAID" into stable/ussuriZuul2020-08-123-6/+52
|\ \
| * | Fix bootloader install issue with MDRAIDDoug Szumski2020-08-053-6/+52
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When no root_device hint is set, an MDRAID partition can be incorrectly selected as the root device which causes installation of the bootloader to the physical disks behind the MDRAID volume to fail. See the notes in the referenced Story for more detail. This change adds a little more specificity to the listing of block devices. Change-Id: I66db457e71a0586723ee753bef961aec5bf58827 Story: 2007905 Task: 40303 (cherry picked from commit 5e95b1321d6e4fe5c562092d0baba73ad6d5303e)
* | | Fix TypeError on agent lookup failureJulia Kreger2020-08-073-4/+84
|/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Agent lookups can fail as we presently use logging.exception, better known in our code as LOG.exception, which can also generate other fun issues on journald based systems where additional errors could be raised resulting in us being unable to troubleshoot the the actual issue. Because of the mis-use of LOG.exception and the default behavior of the backoff retry handler, the retry logic was also not functional as any error no matter how small caused IPA to just exit. Change-Id: Ic4608b7c6ff9773d1403926efb3d59869c71343b Story: 2007968 Task: 40465 (cherry picked from commit 5eab9bced63b2b9a6753cbbf594dda7ef9d03a3a)
* | Merge "Return the final RAID configuration from apply_configuration" into ↵6.1.1Zuul2020-08-043-1/+70
|\ \ | | | | | | | | | stable/ussuri
| * | Return the final RAID configuration from apply_configurationDmitry Tantsur2020-07-293-1/+70
| | | | | | | | | | | | | | | | | | | | | | | | AgentRAID expects it and fails with TypeError if it's not provided. Change-Id: Id84ac129bba97540338e25f0027aa0a0f51bde52 Story: #2006963 (cherry picked from commit f03d72019a9e1bd51d52fb7cb4b5d77a29e44658)
* | | Merge "Prevent un-needed iscsi cleanup" into stable/ussuriZuul2020-08-046-2/+47
|\ \ \
| * | | Prevent un-needed iscsi cleanupJulia Kreger2020-07-286-2/+47
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When we added software raid support, we started calling bootloader installation. As time went on, we ehnanced that code path for non RAID cases in order to ensure that UEFI nvram was setup for the instance to boot properly. Somewhere in this process, we missed a possible failure case where the iscsi client tgtadm may return failures. Obviously, the correct path is to not call iscsi teardown if we don't need to. Since it was always semi-opportunistic teardown, we can't blindly catch any error, and if we started iSCSI and failed to tear the connection down, we might want to still fail, so this change moves the logic over to use a flag on the agent object which one extension to set the flag and the other to read it and take action based upon that. Change-Id: Id3b1ae5e59282f4109f6246d5614d44c93aefa7c Story: 2007937 Task: 40395 (cherry picked from commit 2a56ee03b6ffb2d8c8f5ff553e90ecf6ee07f9af)
* | | | Merge "set EVENTLET_NO_GREENDNS to 'yes'" into stable/ussuriZuul2020-08-041-0/+19
|\ \ \ \
| * | | | set EVENTLET_NO_GREENDNS to 'yes'Julia Kreger2020-08-011-0/+19
| | |/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Eventlet, when monkey patching occurs, replaces the base dns resolver methods. This can lead to compatability issues, and un-expected exceptions being raised during the process of monkey patching. Such as one if there are no resolvers. As such, since we don't really need monkey patching of DNS, and setting the flag should make the inspector CI jobs happier where we don't need nor use DNS, AND tinycore may not be setting a resolver configuration at all, which is the root of the failure upon monkey patching that casues IPA to fail on start in certian circumstances. As a note, this has been performed on other projects due to bugs. See Id9fe265d67f6e9ea5090bebcacae4a7a9150c5c2. Change-Id: Ib8f7b844b1bfffff16f88ebbb6ef5ddbe61d5a30 Story: 2007936 Task: 40394 (cherry picked from commit 9830f3cb0f2c753079695ab1799079c7ea452df9)
* | | | Ignore devices with size 0 when collecting inventoryDmitry Tantsur2020-07-283-5/+25
| |/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | delete_configuration still fetches all devices as it needs to clean ones with broken RAID. Story: #2007907 Task: #40307 Change-Id: I4b0be2b0755108490f9cd3c4f3b71a5e036761a1 (cherry picked from commit 1f3b70c4e968464a93ea68e6f64c4836b90446de)
View Lorry Controller Status