summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
* | | Merge "Burn-in: Add SMART self test to disk burn-in"Zuul2021-12-093-0/+168
|\ \ \
| * | | Burn-in: Add SMART self test to disk burn-inArne Wiebalck2021-12-063-0/+168
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add the option to run a SMART self test right after the disk burn-in. The disk burn-in step will fail if the SMART test on any of the disk fails. Story: #2007523 Task: #43383 Change-Id: I1312d5b71bedd044581a136af0b4c43769d21877
* | | | Merge "Prepare for bugfix release"Zuul2021-12-081-2/+2
|\ \ \ \ | |_|/ / |/| | |
| * | | Prepare for bugfix releaseRiccardo Pittau2021-12-071-2/+2
| | |/ | |/| | | | | | | Change-Id: Ic9437c6d55879db45aa1aa3dc548ea62ed5ca10d
* | | [trivial] Fix Xena release notes versionsRiccardo Pittau2021-12-061-3/+3
|/ / | | | | | | Change-Id: Iaf511e6aeae59409ac6d1ba4543d297c5bb2ec01
* | Test python 3.6 for distributions compatibilityRiccardo Pittau2021-11-301-0/+10
| | | | | | | | | | | | | | | | | | | | | | As discussed during the ironic meeting on 29/11/2021, the community has decided to continue testing the code against Python 3.6 to keep compatibility with distributions that have native support for it, such as CentOS Stream 8, Ubuntu Bionic, Debian 10, and openSuse Leap, at least until it's possible and reasonable considering the support granted from other dependencies and libraries, and not beyond the Yoga cycle. Change-Id: I97ad7c4acdb278e2849a598c5a02a71fc67cc81a
* | Merge "Updating yoga tested python versions in classifier"Zuul2021-11-261-2/+1
|\ \
| * | Updating yoga tested python versions in classifierGhanshyam Mann2021-11-241-2/+1
| |/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | Yoga testing runtime has been updated with py38 and py39 as voting and removed the py36 testing. Unit tests update are handled by the job template change in openstack-zuul-job and you can see the updated jobs running in gate. - https://review.opendev.org/c/openstack/openstack-zuul-jobs/+/818609 this commit updates the tested py versions in setup.cfg classifier. [1] https://governance.openstack.org/tc/reference/runtimes/yoga.html Change-Id: I47cd32e5690b55b983827c650efba4fd99e7be55
* | Get rid of lambda in RealFilePartitioningTestCaseIury Gregory Melo Ferreira2021-11-251-10/+14
|/ | | | | | | This commit changes the lambda usage in the RealFilePartitioningTestCase to autospec to avoid problems with unexpected args. Change-Id: I21356a7783f105dde9ff0d3777e2a06f3f28a786
* Merge "Trivial: split away efibootmgr helpers"Zuul2021-11-231-13/+44
|\
| * Trivial: split away efibootmgr helpersDmitry Tantsur2021-11-191-13/+44
| | | | | | | | | | | | These are very useful for downstream deploy steps, make them public. Change-Id: I26106a07049f751d3e3cc646431e2176001f4645
* | Merge "Call execute from ironic-lib in hardware.py"Zuul2021-11-222-189/+187
|\ \ | |/ |/|
| * Call execute from ironic-lib in hardware.pyRiccardo Pittau2021-11-182-189/+187
| | | | | | | | | | | | | | | | | | Replace the execute wrapper from utils with execute from ironic-lib in hardware.py Adjust unit tests as needed. Change-Id: I63a3b0407b2ca2246bd0e6624bfa0f748c0d73f7
* | Fix compatibility with disk_utils.find_efi_partitionDmitry Tantsur2021-11-195-13/+16
| | | | | | | | | | | | | | | | | | | | This function returns the complete block device record, not just number. Fixes regression in 89bc73aa0105850c6ae44428642e31802bba3b20. Also fix the incorrect job in the gate queue, which prevented us from catching this issue on merging. Change-Id: I4cbc359ceabfc193ce18fed14a1952359460e7d9
* | Merge "Remove metalsmith centos7 job"Zuul2021-11-192-16/+1
|\ \
| * | Remove metalsmith centos7 jobJulia Kreger2021-11-102-16/+1
| | | | | | | | | | | | Change-Id: I523382b5b06b479ba34dce5a1dc7262076122514
* | | Use two more functions from disk_utilsDmitry Tantsur2021-11-186-140/+18
| |/ |/| | | | | Change-Id: If01c9cd7f95b4495509369786360741b731161db
* | Move manage_uefi from the image extension to a public locationDmitry Tantsur2021-11-166-766/+803
| | | | | | | | | | | | | | | | | | | | This call is very useful for custom deploy implementations, such as one we maintain for OpenShift. Splitting it out also makes image.py slightly more manageable. The get_partition call is moved to partition_utils. Change-Id: I60a6a2823d3eb27a4ae78e913e3655dae7b54ffe
* | Merge "Simplify error messages when running clean/deploy step"Zuul2021-11-134-6/+66
|\ \
| * | Simplify error messages when running clean/deploy stepDmitry Tantsur2021-11-094-6/+66
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The caller knows what step it invokes, there is no point in repeating it in the error message. There is also no need to wrap the exception if it's a RESTError or an ironic-lib exception already since they are normally detailed enough. Only leave a detailed message when an unexpected exception happens. Change-Id: I1d8ca1e7ed1462159e4ae5f0bcf58686f6a2681c
* | | Move rescan device function to general utilsRiccardo Pittau2021-11-104-145/+208
| |/ |/| | | | | | | | | | | We use basically the same function in two modules in the same way, let's put that in a common place. Change-Id: I4016e43f2cb102d4327bafcc8a2f90112a6f944a
* | Re-read the partition table with partx -a, part 2Riccardo Pittau2021-11-093-43/+50
|/ | | | | | | | | | | | Use add instead of update to re-read the partition table with partx. See [1] for more details. Co-authored-by: Arne Wiebalck <arne.wiebalck@cern.ch> [1] https: //opendev.org/openstack/ironic-python-agent/commit/dc8c1f16f9a00e2bff21612d1a9cf0ea0f3addf0 Change-Id: I2336e22dadc790cfbde87904612fcaa3b8c501db
* Re-read the partition table with partx -aArne Wiebalck2021-11-063-17/+22
| | | | | | | | | | | Re-read the partition table with 'partx -a', rather than 'partx -u'. This should fix an timing issue where the bootloader installation fails to mount the EFI partition from a whole disk image since it is not yet aware of the new partitions (observed with both, the iscsi and the direct deploy interface). Change-Id: If5da3075e813ae01df3decf8f0647aba111b0515
* Merge "Fix UEFI record regex"Zuul2021-11-053-6/+75
|\
| * Fix UEFI record regexJulia Kreger2021-11-043-6/+75
| | | | | | | | | | | | | | | | | | | | | | | | | | I accidently put colons on the test data and remembered taking the colon character out of the regex I was working on, but apparently left it in, and accounted for the active entry indicator flag which appears to have inconsistent support across vendors. The regex has been fixed, and a test added from a Lenovo SR650 which has some additional string entry data in the UEFI output which may separate entries. Change-Id: I1f67b0fb1f645fa82e98bd7c7bba3ffc7755cc74
* | Merge "Always include the oslo_log log file in ramdisk logs"Zuul2021-11-045-3/+72
|\ \ | |/ |/|
| * Always include the oslo_log log file in ramdisk logsDmitry Tantsur2021-10-285-3/+72
| | | | | | | | | | | | | | Even if journald is present, there is no guarantee that IPA logs there (this is the case in container-based ramdisks). Change-Id: Iceeab0010827728711e19e5b031ccac55fe1efde
* | Merge "Stop requiring mocking of utils.execute if ironic-lib execute is mocked"Zuul2021-11-032-17/+1
|\ \
| * | Stop requiring mocking of utils.execute if ironic-lib execute is mockedDmitry Tantsur2021-10-272-17/+1
| |/ | | | | | | | | | | | | | | | | | | Based on unit tests, this was done intentionally, but I don't see reasons for that. It makes refactoring much harder, because sometimes you need to mock both execute functions and test them separately. In the end, utils.execute should be removed. Change-Id: I5a9c694ebe626c54f219d4870eab0a592777518d
* | Delete EFI boot entry duplicate labels firstJulia Kreger2021-11-013-24/+51
|/ | | | | | | | | | | | | | | | | | | | | | | Some firmware seems to take an objection with EFI nvram entries being deleted after one is added, resulting in the entire entry table being reset to the last known good state. This is problematic, as ultimately deployments can time out if we previously booted with Networking, and the machine, while commanded to do other wise, reboots back to networking regardless. We will now delete entries first, before proceeding. Additionally, for general use, this pattern may serve the community better by avoiding cases where we would have previously just relied upon efibootmgr[0] to warn us of duplicate entries. [0]: https://github.com/rhboot/efibootmgr/blob/103aa22ece98f09fe3ea2a0c83988f0ee2d0e5a8/src/efibootmgr.c#L228 Change-Id: Ib61a7100a059e79a8b0901fd8f46b9bc41d657dc Story: 2009649 Task: 43808
* Merge "Fix error messages in burnin code"Zuul2021-10-261-9/+5
|\
| * Fix error messages in burnin codeDmitry Tantsur2021-10-261-9/+5
| | | | | | | | Change-Id: Ib920b6f8da2c2c9d72dbb8bbd8915bde767bddd2
* | Respect global parameters when downloading a configdriveDmitry Tantsur2021-10-203-7/+90
|/ | | | | | | | * Use the same TLS parameters as everything else * Respect image_download_connection_timeout * Do not ignore HTTP errors Change-Id: I84f8021f731186d82e44ac3d4ef2d12df13f830a
* Assert EFI part UUID is not None before editing fstabArne Wiebalck2021-10-082-1/+7
| | | | | | | | | | The EFI partition UUID may be None and this will break the fstab editing. While this is not necessarily fatal when instantiating a node, it creates an exception at the end of bootloader installation, so only attempt to add a line to fstab when the UUID is not None. Change-Id: I68799980e67c05afe4ca68ca9733605dd166d54d
* Software RAID: Call udev_settle before creationArne Wiebalck2021-10-052-0/+14
| | | | | | | | | | | | This patch fixes a race during software RAID creation: we create the partition with parted, the kernel then notifies udev, but we need to wait for udevd to create the device files before calling mdadm to create the md device. Credits to jcosmao for finding this. Change-Id: I642f28acc351cf50263e37dfbc8468bf59de2cc5
* Add Python3 yoga unit testsOpenStack Release Bot2021-09-221-1/+1
| | | | | | | | | | | This is an automatically generated patch to ensure unit testing is in place for all the of the tested runtimes for yoga. See also the PTI in governance [1]. [1]: https://governance.openstack.org/tc/reference/project-testing-interface.html Change-Id: Ia08ee369e2925b2c313dcfaa8975fe023ec1c07a
* Update master for stable/xenaOpenStack Release Bot2021-09-222-0/+7
| | | | | | | | | | | | Add file to the reno documentation build to show release notes for stable/xena. Use pbr instruction to increment the minor version number automatically so that master versions are higher than the versions on stable/xena. Sem-Ver: feature Change-Id: If28b1df9c76469062e6d9ce28edcf3026fdbfbaa
* Merge "Trivial: minor fixes in error messages"8.2.0Zuul2021-09-093-3/+3
|\
| * Trivial: minor fixes in error messagesDmitry Tantsur2021-09-073-3/+3
| | | | | | | | Change-Id: I06b32c2eb576520cddff88074e4619070731017d
* | Merge "Trivial: better debugging in list_all_block_devices"Zuul2021-09-031-2/+5
|\ \
| * | Trivial: better debugging in list_all_block_devicesDmitry Tantsur2021-08-271-2/+5
| |/ | | | | | | | | | | | | One debug message only specified "Skipping" without any details. Another did not log the whole line from lsblk. Fix both. Change-Id: I9f8f4edad88ba2df5abc6a45a74ebdb3c7afcf97
* | Merge "Check the network burnin roles and partner"Zuul2021-09-022-0/+29
|\ \ | |/ |/|
| * Check the network burnin roles and partnerArne Wiebalck2021-08-102-0/+29
| | | | | | | | | | | | | | | | The network burnin roles are 'reader' and 'writer'. Raise an error if the role is not provided or if the role is unknown. Equally, raise an error if the partner is not provided. Change-Id: I6259a7b0d15d62e68b1dc27f0cb511f8563c02ce
* | Merge "Move loading of IPMI module loading to a single point"Zuul2021-08-233-66/+60
|\ \
| * | Move loading of IPMI module loading to a single pointJonas Schäfer2021-08-063-66/+60
| | | | | | | | | | | | | | | | | | | | | | | | | | | This means we do not have to rely on modprobe idempotency as much and it's less code duplication, which is always nice. Signed-off-by: Jonas Schäfer <jonas.schaefer@cloudandheat.com> Change-Id: I996aba47bc54309e15e7d56e4a96b23b8deb5c9c
* | | Merge "Output verbose info from efibootmgr"Zuul2021-08-112-21/+21
|\ \ \
| * | | Output verbose info from efibootmgrDerek Higgins2021-08-032-21/+21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | When debugging boot manager problems it can be advantageous to see all the full entries rather then just their labels. Change-Id: I6a1bb78acaf5a4284727bdf533d4be6db2099f50
* | | | Merge "Increase version of hacking and pycodestyle"Zuul2021-08-119-37/+48
|\ \ \ \ | |_|_|/ |/| | |
| * | | Increase version of hacking and pycodestyleRiccardo Pittau2021-07-309-37/+48
| |/ / | | | | | | | | | | | | | | | Fix H904 "Delay string interpolations at logging calls" errors Change-Id: I331808d0132094faf739998a6984440787d3ebf8
* | | Merge "Add lower-constraints job to current development branch"Zuul2021-08-103-2/+35
|\ \ \
View Lorry Controller Status