summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Fix UTF-16 result handling for efibootmgrstable/xenaJulia Kreger2023-04-273-31/+56
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | The tl;dr is that UEFI NVRAM is in encoded in UTF-16, and when we run the efibootmgr command, we can get unicode characters back. Except we previously were forcing everything to be treated as UTF-8 due to the way oslo.concurrency's processutils module works. This could be observed with UTF character 0x00FF which raises up a nice exception when we try to decode it. Anyhow! while fixing handling of this, we discovered we could get basically the cruft out of the NVRAM, by getting what was most likey a truncated string out of our own test VMs. As such, we need to also permit decoding to be tollerant of failures. This could be binary data or as simple as flipped bits which get interpretted invalid characters. As such, we have introduced such data into one of our tests involving UEFI record de-duplication. Closes-Bug: 2015602 Change-Id: I006535bf124379ed65443c7b283bc99ecc95568b (cherry picked from commit 76accfb880474445a5dcb07825889123b3dd0237) (cherry picked from commit 9f84c8b3d1fa0e08bf1f799f37a11698f8da07a4)
* Make reno ignore bugfix eol tagsJay Faulkner2023-01-261-0/+2
| | | | | | | | | | Reno was assuming all tags ending in -eol represented an old, EOL'd stable branch. That's not true for Ironic projects which have bugfix branches. Update the regexp to exclude those branches. Co-Authored-By: Adam McArthur <adam@mcaq.me> Change-Id: I265969ab40a98a02962c2fc8460b6519ab576f99 (cherry picked from commit f8fc7e52f36de5c3515e60f5d2e6347a538a80d8)
* Fixes for tox 4.0xena-em8.2.3Jay Faulkner2022-12-151-7/+8
| | | | | | | - passenv needed better structure - usedevelop no longer allowed alongside skipsdist Change-Id: I22dae3b1e4cca2dc328c21e889acf7fe98a80e0b
* Warn when smartctl not foundMark Goddard2022-12-121-1/+2
| | | | | | | | | | | | | | Currently, if smartctl is not found by IPA, it will silently skip ATA secure erase and proceed to shred (if enabled). This is supposedly for backwards compatibility, but is quite hard to diagnose. This change adds a warning message to make it more obvious what is happening. TrivialFix Change-Id: I03a381e99de79f201ec7e9a388777c3d48457e93 (cherry picked from commit b68fa6b2e13774dbde5d0b81f6bf0b0095536aa4)
* Merge "Drop python2 from bindep.txt" into stable/xenaZuul2022-11-161-3/+1
|\
| * Drop python2 from bindep.txtPavlo Shchelokovskyy2022-10-261-3/+1
| | | | | | | | | | | | | | | | | | | | IPA dropped support for Python2 long ago, and now Python2 is not even available in newer distros, breaking installation if IPA binary dependencies. Change-Id: I75a618f94de58f6de2bd96b37de1894bb0e61998 (cherry picked from commit d8a6bf5f61eb1365294c6c07840286f46c9535fc) (cherry picked from commit 5cc653cbfe32699c9940d34842d5b4a5e2fe35a0)
* | Merge "Use utf-16-le if BOM not present" into stable/xena8.2.2Zuul2022-10-252-2/+14
|\ \
| * | Use utf-16-le if BOM not presentRiccardo Pittau2022-10-132-2/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In case no BOM is present in the CSV file the utf-16 codec won't work. We fail over to utf-16-le as Little Endian is commonly used. NOTE: The original change landed this fix in efi_utils.py, however that was introduced after the Xena development cycle, so this backport moves the original change to where the code originally came from to populate the efi_utils.py file. Change-Id: I3e25ce4997f5dd3df87caba753daced65838f85a (cherry picked from commit 697fa6f3b6db10408eaadd57450456de87f13519) (cherry picked from commit 99b9d1403cacd3bbd489a6cf6913f32746ef6083)
* | | Merge "CI: Make swift/Vmedia job non-voting" into stable/xenaZuul2022-10-251-2/+2
|\ \ \ | |_|/ |/| |
| * | CI: Make swift/Vmedia job non-votingJulia Kreger2022-10-251-2/+2
| |/ | | | | | | | | | | | | | | | | | | | | | | | | | | It appears that swift is occassionally responding to jobs with 404 when tempurls are used. Likely this is something to do with time, but the underlying credenital can also be validated. Since this works in newer branches, and no chanes can be attributed to swift, there is likely some sort of intermediate library issue where unable to pin down. In the interest of keeping a working CI, for now, mark the job as non-voting until we're able to figure something out. Change-Id: I46e8e8800eb1b08caba8faab6247195ea646430b
* | Merge "Fix software raid output poisoning" into stable/xenaZuul2022-10-254-1/+42
|\ \ | |/ |/|
| * Fix software raid output poisoningJulia Kreger2022-09-164-1/+42
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In the event a device name is set to contain a raid device path, it is possible for the Name and Events field values of mdadm's detailed output to contain text which inadvertently gets captured and mapped as component data for the "holder" devices of the RAID set. This would cause invalid values to get passed to UEFI methods which would cause a deployment to fail under these circumstances. We now ignore the Name and Events fields in mdadm output. Change-Id: If721dfe1caa5915326482969e55fbf4697538231 (cherry picked from commit f3e3de8097f05cc830768da7d3f3e9eae04b40a1) (cherry picked from commit 6660e01e1f8a6e7a40b798eea5215b1eddcbe0c3) (cherry picked from commit 5751f60353f3a4bf325a8c9335d743eec45fbcd1)
* | CI: Zuul no longer respects queue paramJay Faulkner2022-10-031-1/+0
|/ | | | Change-Id: I1e7a3b3c9ded13b10002bb47e98d4a7b486e1dd4
* Gather details about bond interfaces if presentDerek Higgins2022-07-133-11/+66
| | | | | | | | | | If present gather information about bonded interfaces. Story: #2010093 Task: #45637 Change-Id: I394187640b4788ebec21c3391d33ed728fb72ffa (cherry picked from commit 7e4fe3bf6a2ae41656b7923796f9c2d056a2ed04)
* Fix discovering WWN/serial for devicemapper devicesDmitry Tantsur2022-06-223-16/+31
| | | | | | | | UDev prefix is DM_ not ID_ for them. On top of that, they don't have short serials (or at least don't always have). Change-Id: I5b6075fbff72201a2fd620f789978acceafc417b (cherry picked from commit 69e22545033f544d628f9c4ecd5a665ba0b5b85e)
* Multipath Hardware path handlingJulia Kreger2022-06-097-49/+722
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Removes multipath base devices from consideration by default, and instead allows the device-mapper device managed by multipath to be picked up and utilized instead. In effect, allowing us to ignore standby paths *and* leverage multiple concurrent IO paths if so offered via ALUA. In reality, anyone who has previously built IPA with multipath tooling might not have encountered issues previously because they used Active/Active SAN storage environments. They would have worked because the IO lock would have been exchanged between controllers and paths. However, Active/Passive environments will block passive paths from access, ultimately preventing new locks from being established without proper negotiation. Ultimately requiring multipathing *and* the agent to be smart enough to know to disqualify underlying paths to backend storage volumes. An additional benefit of this is active/active MPIO devices will, as long as ``multipath`` is present inside the ramdisk, no longer possibly result in duplicate IO wipes occuring accross numerous devices. Story: #2010003 Task: #45108 Resolves: rhbz#2076622 Resolves: rhbz#2070519 Change-Id: I0fd6356f036d5ff17510fb838eaf418164cdfc92 (cherry picked from commit 014d37743a3b5694e0e2a3cabfafe885417172d5)
* Collect a full lsblk output in the ramdisk logsDmitry Tantsur2022-06-093-12/+10
| | | | | | | | | | The existing lsblk call is very handy for an overview, but there a lot more useful pairs to collect. Collect them in a machine-readable format to be able to use in debugging and further development. Change-Id: Ib27843524421944ee93de975d275e93276a5597a (cherry picked from commit 424e649bed3db5d1129b18b7ea4dfba88d552537) (cherry picked from commit bc74df8bfe89f703880f8a545ce939e9b1cd8651)
* Merge "Use a pre-defined partition UUID to detect configdrive on GPT" into ↵Zuul2022-05-183-39/+58
|\ | | | | | | stable/xena
| * Use a pre-defined partition UUID to detect configdrive on GPTDmitry Tantsur2022-05-103-39/+58
| | | | | | | | | | | | | | | | | | | | | | | | Using partition numbers is currently broken for devicemapper devices. Fortunately, GPT has partition UUIDs, so we can just generate one and use it for lookup. NOTE on backport: _get_partition is imported from the image extension. In Yoga it was moved to partition_utils. Change-Id: I41ffe4f8e4c6e43182090b5aa2a2b4b34f32efd5 (cherry picked from commit 65c4de903a2d8059b1520b0102235b6700287f87)
* | Do not try to guess EFI partition path by its numberDmitry Tantsur2022-05-064-48/+117
|/ | | | | | | | | | | | | The logic of adding a partition number to the device path does not work for devicemapper devices (e.g. a multipath storage device). Conflicts: ironic_python_agent/efi_utils.py ironic_python_agent/tests/unit/extensions/test_image.py ironic_python_agent/tests/unit/test_efi_utils.py Change-Id: I9a445e847d282c50adfa4bad5e7136776861005d (cherry picked from commit f09f6c9f1a09c7062d0450b3e0a4d3164fd53f7f)
* SoftwareRAID: Use efibootmgr (and drop grub2-install)Arne Wiebalck2022-03-167-64/+243
| | | | | | | | | | | | | | | | | | | | | | | Move the software RAID code path from grub2-install to efibootmgr: - remove the UEFI efibootmgr exception for software RAID - create and populate the ESPs on the holder disks - update the NVRAM with all ESPs (the component devices of the ESP mirror, use unique labels to avoid unintentional deduplication of entries in the NVRAM) In addition, use canonical device names for the RAID device for the ESP: it seems like tinyIPA silently replaces /dev/md/esp with /dev/md127. Find the next free /dev/md device and use it instead. Also rescan the resulting device before copying files. Co-authored-by: Dmitry Tantsur <dtantsur@protonmail.com> Story: #2009794 Change-Id: I7ed34e595215194a589c2f1cd0b39ff0336da8f1 (cherry picked from commit 62c5674a600baeeef0af3b12baeab486870eb103)
* Merge "Rescan device after filesystem creation" into stable/xenaZuul2022-03-123-4/+21
|\
| * Rescan device after filesystem creationVanou Ishii2022-03-083-4/+21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In work_on_disk function, IPA runs mkfs commands without following device rescan operation. This leads to incorrect content of uuids_to_return to be returned. These mkfs commands modify partition label but IPA fails to catch such changes because of no following device rescan operation. This commit adds call of device rescan function before uuids_to_return construction. Change-Id: I4e8b30deb5e2247f51ce8f10bd3271f64a264089 (cherry picked from commit fa70a1909b0f60e1c2c804cb28765fd989ed3fb9)
* | Create fstab entry with appropriate labelJulia Kreger2022-03-116-10/+135
|/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Depending on the how the stars align with partition images being written to a remote system, we *may* end up with *either* a Partition UUID value, or a Partition's UUID value. Which are distinctly different. This is becasue the value, when collected as a result of writing an image to disk *falls* back and passes the value to enable partition discovery and matching. Later on, when we realized we ought to create an fstab entry, we blindly re-used the value thinking it was, indeed, always a Partition's UUID and not the Partition UUID. Obviously, the label type is quite explicit, either UUID or PARTUUID respectively, when initial ramdisk utilities such as dracut are searching and mounting filesystems. Adds capability to identify the correct label to utilize based upon the current state of the block devices on disk. Granted, we are likely only exposed to this because of IO race conditions under high concurrecy load operations. Normally this would only be seen on test VMs, but systems being backed by a Storage Area Network *can* exibit the same IO race conditions as virtual machines. Change-Id: I953c936cbf8fad889108cbf4e50b1a15f511b38c Resolves: rhbz#2058717 Story: #2009881 Task: 44623 (cherry picked from commit 99ca1086dbfc7b6e41cf800b0bd899565e2e8922)
* Stop defaulting the standalone job to netboot; use the correct boot modeDmitry Tantsur2022-02-221-1/+1
| | | | | | | | | Its configuration must match one in Ironic, and netboot does not work with whole disk images under UEFI. Fix the boot mode of the BIOS job: it was running in UEFI. Change-Id: Ia207e80bbfc30f8d2891e11bbeda7b2ab0d617c0
* Make the standalone job voting againDmitry Tantsur2022-02-011-7/+2
| | | | | | | | | We forgot to revert it. This job covers software RAID and manual cleaning, so it's very important to avoid regressions, even if it costs us some rechecks from time to time. Change-Id: I2446afeaca866ffc3131b5e9f266526f35fc5ed7 (cherry picked from commit b921b761679df06afe19ac6f570f66fa1fdcf371)
* Re-read the partition table with partx -a, part 28.2.1Riccardo Pittau2021-11-103-43/+50
| | | | | | | | | | | | | Use add instead of update to re-read the partition table with partx. See [1] for more details. Co-authored-by: Arne Wiebalck <arne.wiebalck@cern.ch> [1] https: //opendev.org/openstack/ironic-python-agent/commit/dc8c1f16f9a00e2bff21612d1a9cf0ea0f3addf0 Change-Id: I2336e22dadc790cfbde87904612fcaa3b8c501db (cherry picked from commit 23e67b5fea58295d0320f99d4513a66d720f09ee)
* Re-read the partition table with partx -aArne Wiebalck2021-11-093-17/+22
| | | | | | | | | | | | Re-read the partition table with 'partx -a', rather than 'partx -u'. This should fix an timing issue where the bootloader installation fails to mount the EFI partition from a whole disk image since it is not yet aware of the new partitions (observed with both, the iscsi and the direct deploy interface). Change-Id: If5da3075e813ae01df3decf8f0647aba111b0515 (cherry picked from commit dc8c1f16f9a00e2bff21612d1a9cf0ea0f3addf0)
* Merge "Fix UEFI record regex" into stable/xenaZuul2021-11-083-6/+75
|\
| * Fix UEFI record regexJulia Kreger2021-11-083-6/+75
| | | | | | | | | | | | | | | | | | | | | | | | | | I accidently put colons on the test data and remembered taking the colon character out of the regex I was working on, but apparently left it in, and accounted for the active entry indicator flag which appears to have inconsistent support across vendors. The regex has been fixed, and a test added from a Lenovo SR650 which has some additional string entry data in the UEFI output which may separate entries. Change-Id: I1f67b0fb1f645fa82e98bd7c7bba3ffc7755cc74
* | Merge "Delete EFI boot entry duplicate labels first" into stable/xenaZuul2021-11-083-24/+51
|\ \ | |/
| * Delete EFI boot entry duplicate labels firstJulia Kreger2021-11-043-24/+51
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Some firmware seems to take an objection with EFI nvram entries being deleted after one is added, resulting in the entire entry table being reset to the last known good state. This is problematic, as ultimately deployments can time out if we previously booted with Networking, and the machine, while commanded to do other wise, reboots back to networking regardless. We will now delete entries first, before proceeding. Additionally, for general use, this pattern may serve the community better by avoiding cases where we would have previously just relied upon efibootmgr[0] to warn us of duplicate entries. [0]: https://github.com/rhboot/efibootmgr/blob/103aa22ece98f09fe3ea2a0c83988f0ee2d0e5a8/src/efibootmgr.c#L228 Change-Id: Ib61a7100a059e79a8b0901fd8f46b9bc41d657dc Story: 2009649 Task: 43808 (cherry picked from commit 67eddfa7e3fedbb530045f5b43a2c89db832fa2a)
* | Always include the oslo_log log file in ramdisk logsDmitry Tantsur2021-11-045-3/+72
|/ | | | | | | | Even if journald is present, there is no guarantee that IPA logs there (this is the case in container-based ramdisks). Change-Id: Iceeab0010827728711e19e5b031ccac55fe1efde (cherry picked from commit 2cedaa53c2ad306c4aeb2c2dc76c051db7408dbd)
* Merge "Respect global parameters when downloading a configdrive" into ↵Zuul2021-10-283-7/+90
|\ | | | | | | stable/xena
| * Respect global parameters when downloading a configdriveDmitry Tantsur2021-10-273-7/+90
| | | | | | | | | | | | | | | | | | * Use the same TLS parameters as everything else * Respect image_download_connection_timeout * Do not ignore HTTP errors Change-Id: I84f8021f731186d82e44ac3d4ef2d12df13f830a (cherry picked from commit 8a66978666ca207d8abf203d7dbde6bc69f6433d)
* | Fix error messages in burnin codeDmitry Tantsur2021-10-271-9/+5
|/ | | | | Change-Id: Ib920b6f8da2c2c9d72dbb8bbd8915bde767bddd2 (cherry picked from commit 9a8c6a831aa1189a28e90537a03547af8c353eb3)
* Assert EFI part UUID is not None before editing fstabArne Wiebalck2021-10-212-1/+7
| | | | | | | | | | | The EFI partition UUID may be None and this will break the fstab editing. While this is not necessarily fatal when instantiating a node, it creates an exception at the end of bootloader installation, so only attempt to add a line to fstab when the UUID is not None. Change-Id: I68799980e67c05afe4ca68ca9733605dd166d54d (cherry picked from commit 333ed70c94e366f16d8f2633f74a5ef05aa5fadb)
* Software RAID: Call udev_settle before creationArne Wiebalck2021-10-062-0/+14
| | | | | | | | | | | | | This patch fixes a race during software RAID creation: we create the partition with parted, the kernel then notifies udev, but we need to wait for udevd to create the device files before calling mdadm to create the md device. Credits to jcosmao for finding this. Change-Id: I642f28acc351cf50263e37dfbc8468bf59de2cc5 (cherry picked from commit 9d707e9f4bab40109b7e29df2136e86d65325ea3)
* Update TOX_CONSTRAINTS_FILE for stable/xenaOpenStack Release Bot2021-09-221-4/+4
| | | | | | | | | | | | Update the URL to the upper-constraints file to point to the redirect rule on releases.openstack.org so that anyone working on this branch will switch to the correct upper-constraints list automatically when the requirements repository branches. Until the requirements repository has as stable/xena branch, tests will continue to use the upper-constraints list on master. Change-Id: I5588301bcc0eeb4c364b55f18b4b358249a4652e
* Update .gitreview for stable/xenaOpenStack Release Bot2021-09-221-0/+1
| | | | Change-Id: Iaf94c71704fd09a3de7c5e85c7bf1cd231a989b1
* Merge "Trivial: minor fixes in error messages"8.2.0Zuul2021-09-093-3/+3
|\
| * Trivial: minor fixes in error messagesDmitry Tantsur2021-09-073-3/+3
| | | | | | | | Change-Id: I06b32c2eb576520cddff88074e4619070731017d
* | Merge "Trivial: better debugging in list_all_block_devices"Zuul2021-09-031-2/+5
|\ \
| * | Trivial: better debugging in list_all_block_devicesDmitry Tantsur2021-08-271-2/+5
| |/ | | | | | | | | | | | | One debug message only specified "Skipping" without any details. Another did not log the whole line from lsblk. Fix both. Change-Id: I9f8f4edad88ba2df5abc6a45a74ebdb3c7afcf97
* | Merge "Check the network burnin roles and partner"Zuul2021-09-022-0/+29
|\ \ | |/ |/|
| * Check the network burnin roles and partnerArne Wiebalck2021-08-102-0/+29
| | | | | | | | | | | | | | | | The network burnin roles are 'reader' and 'writer'. Raise an error if the role is not provided or if the role is unknown. Equally, raise an error if the partner is not provided. Change-Id: I6259a7b0d15d62e68b1dc27f0cb511f8563c02ce
* | Merge "Move loading of IPMI module loading to a single point"Zuul2021-08-233-66/+60
|\ \
| * | Move loading of IPMI module loading to a single pointJonas Schäfer2021-08-063-66/+60
| | | | | | | | | | | | | | | | | | | | | | | | | | | This means we do not have to rely on modprobe idempotency as much and it's less code duplication, which is always nice. Signed-off-by: Jonas Schäfer <jonas.schaefer@cloudandheat.com> Change-Id: I996aba47bc54309e15e7d56e4a96b23b8deb5c9c
* | | Merge "Output verbose info from efibootmgr"Zuul2021-08-112-21/+21
|\ \ \
| * | | Output verbose info from efibootmgrDerek Higgins2021-08-032-21/+21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | When debugging boot manager problems it can be advantageous to see all the full entries rather then just their labels. Change-Id: I6a1bb78acaf5a4284727bdf533d4be6db2099f50
View Lorry Controller Status