summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Fix UTF-16 result handling for efibootmgrstable/yogaJulia Kreger2023-04-274-63/+91
| | | | | | | | | | | | | | | | | | | | | | | | | | | | The tl;dr is that UEFI NVRAM is in encoded in UTF-16, and when we run the efibootmgr command, we can get unicode characters back. Except we previously were forcing everything to be treated as UTF-8 due to the way oslo.concurrency's processutils module works. This could be observed with UTF character 0x00FF which raises up a nice exception when we try to decode it. Anyhow! while fixing handling of this, we discovered we could get basically the cruft out of the NVRAM, by getting what was most likey a truncated string out of our own test VMs. As such, we need to also permit decoding to be tollerant of failures. This could be binary data or as simple as flipped bits which get interpretted invalid characters. As such, we have introduced such data into one of our tests involving UEFI record de-duplication. Closes-Bug: 2015602 Change-Id: I006535bf124379ed65443c7b283bc99ecc95568b (cherry picked from commit 76accfb880474445a5dcb07825889123b3dd0237)
* Make reno ignore bugfix eol tagsJay Faulkner2023-01-261-0/+2
| | | | | | | | | | Reno was assuming all tags ending in -eol represented an old, EOL'd stable branch. That's not true for Ironic projects which have bugfix branches. Update the regexp to exclude those branches. Co-Authored-By: Adam McArthur <adam@mcaq.me> Change-Id: I265969ab40a98a02962c2fc8460b6519ab576f99 (cherry picked from commit f8fc7e52f36de5c3515e60f5d2e6347a538a80d8)
* Fixes for tox 4.0Jay Faulkner2022-12-151-7/+8
| | | | | | | - passenv needed better structure - usedevelop no longer allowed alongside skipsdist Change-Id: I22dae3b1e4cca2dc328c21e889acf7fe98a80e0b
* Warn when smartctl not foundMark Goddard2022-12-121-1/+2
| | | | | | | | | | | | | | Currently, if smartctl is not found by IPA, it will silently skip ATA secure erase and proceed to shred (if enabled). This is supposedly for backwards compatibility, but is quite hard to diagnose. This change adds a warning message to make it more obvious what is happening. TrivialFix Change-Id: I03a381e99de79f201ec7e9a388777c3d48457e93 (cherry picked from commit b68fa6b2e13774dbde5d0b81f6bf0b0095536aa4)
* Drop python2 from bindep.txtPavlo Shchelokovskyy2022-10-261-3/+1
| | | | | | | | | IPA dropped support for Python2 long ago, and now Python2 is not even available in newer distros, breaking installation if IPA binary dependencies. Change-Id: I75a618f94de58f6de2bd96b37de1894bb0e61998 (cherry picked from commit d8a6bf5f61eb1365294c6c07840286f46c9535fc)
* CI: Zuul no longer respects queue param8.5.1Jay Faulkner2022-10-031-1/+0
| | | | Change-Id: I1e7a3b3c9ded13b10002bb47e98d4a7b486e1dd4
* Fix software raid output poisoningJulia Kreger2022-08-264-1/+42
| | | | | | | | | | | | | | | | In the event a device name is set to contain a raid device path, it is possible for the Name and Events field values of mdadm's detailed output to contain text which inadvertently gets captured and mapped as component data for the "holder" devices of the RAID set. This would cause invalid values to get passed to UEFI methods which would cause a deployment to fail under these circumstances. We now ignore the Name and Events fields in mdadm output. Change-Id: If721dfe1caa5915326482969e55fbf4697538231 (cherry picked from commit f3e3de8097f05cc830768da7d3f3e9eae04b40a1) (cherry picked from commit 6660e01e1f8a6e7a40b798eea5215b1eddcbe0c3)
* Gather details about bond interfaces if presentDerek Higgins2022-07-053-11/+66
| | | | | | | | | | If present gather information about bonded interfaces. Story: #2010093 Task: #45637 Change-Id: I394187640b4788ebec21c3391d33ed728fb72ffa (cherry picked from commit 7e4fe3bf6a2ae41656b7923796f9c2d056a2ed04)
* Fix discovering WWN/serial for devicemapper devicesDmitry Tantsur2022-06-223-16/+31
| | | | | | | | UDev prefix is DM_ not ID_ for them. On top of that, they don't have short serials (or at least don't always have). Change-Id: I5b6075fbff72201a2fd620f789978acceafc417b (cherry picked from commit 69e22545033f544d628f9c4ecd5a665ba0b5b85e)
* Multipath Hardware path handlingJulia Kreger2022-05-238-57/+748
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Removes multipath base devices from consideration by default, and instead allows the device-mapper device managed by multipath to be picked up and utilized instead. In effect, allowing us to ignore standby paths *and* leverage multiple concurrent IO paths if so offered via ALUA. In reality, anyone who has previously built IPA with multipath tooling might not have encountered issues previously because they used Active/Active SAN storage environments. They would have worked because the IO lock would have been exchanged between controllers and paths. However, Active/Passive environments will block passive paths from access, ultimately preventing new locks from being established without proper negotiation. Ultimately requiring multipathing *and* the agent to be smart enough to know to disqualify underlying paths to backend storage volumes. An additional benefit of this is active/active MPIO devices will, as long as ``multipath`` is present inside the ramdisk, no longer possibly result in duplicate IO wipes occuring accross numerous devices. Story: #2010003 Task: #45108 Resolves: rhbz#2076622 Resolves: rhbz#2070519 Change-Id: I0fd6356f036d5ff17510fb838eaf418164cdfc92 (cherry picked from commit 014d37743a3b5694e0e2a3cabfafe885417172d5)
* Merge "Collect a full lsblk output in the ramdisk logs" into stable/yogaZuul2022-05-113-16/+10
|\
| * Collect a full lsblk output in the ramdisk logsDmitry Tantsur2022-05-093-16/+10
| | | | | | | | | | | | | | | | | | The existing lsblk call is very handy for an overview, but there a lot more useful pairs to collect. Collect them in a machine-readable format to be able to use in debugging and further development. Change-Id: Ib27843524421944ee93de975d275e93276a5597a (cherry picked from commit 424e649bed3db5d1129b18b7ea4dfba88d552537)
* | Do not try to guess EFI partition path by its numberDmitry Tantsur2022-05-055-58/+142
|/ | | | | | | | The logic of adding a partition number to the device path does not work for devicemapper devices (e.g. a multipath storage device). Change-Id: I9a445e847d282c50adfa4bad5e7136776861005d (cherry picked from commit f09f6c9f1a09c7062d0450b3e0a4d3164fd53f7f)
* Use a pre-defined partition UUID to detect configdrive on GPTDmitry Tantsur2022-05-043-38/+55
| | | | | | | | | Using partition numbers is currently broken for devicemapper devices. Fortunately, GPT has partition UUIDs, so we can just generate one and use it for lookup. Change-Id: I41ffe4f8e4c6e43182090b5aa2a2b4b34f32efd5 (cherry picked from commit 65c4de903a2d8059b1520b0102235b6700287f87)
* Update TOX_CONSTRAINTS_FILE for stable/yogaOpenStack Release Bot2022-03-231-4/+4
| | | | | | | | | | | | Update the URL to the upper-constraints file to point to the redirect rule on releases.openstack.org so that anyone working on this branch will switch to the correct upper-constraints list automatically when the requirements repository branches. Until the requirements repository has as stable/yoga branch, tests will continue to use the upper-constraints list on master. Change-Id: I6413453a0b82d7f48ee0d0704935b69727224b5e
* Update .gitreview for stable/yogaOpenStack Release Bot2022-03-231-0/+1
| | | | Change-Id: If55120209ec44d160c29f4017ab9dd0969ab5635
* Merge "Refactor efi_utils for easier maintaining and debugging"8.5.0Zuul2022-03-182-68/+161
|\
| * Refactor efi_utils for easier maintaining and debuggingDmitry Tantsur2022-02-142-68/+161
| | | | | | | | | | | | | | | | | | | | * Move irrelevant code from inside the giant try..except block * Do not bother removing the (empty) temporary mountpoint * Fix log messages according to the actual code * Fix some code duplication * Add missing unit tests for failure case Change-Id: Id7b557419d513375816d73901e2ab6f139d765ad
* | Merge "Improve efficiency of storage cleaning in mixed media envs"Zuul2022-03-153-16/+124
|\ \
| * | Improve efficiency of storage cleaning in mixed media envsJacob Anders2022-03-153-16/+124
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://storyboard.openstack.org/#!/story/2008290 added support for NVMe-native storage cleaning, greatly improving storage clean times on NVMe-based nodes as well as reducing device wear. This is a follow up change which aims to make further improvements to cleaning efficiency in mixed NVMe-HDD environments. This is achieved by combining NVMe-native cleaning methods on NVMe devices with traditional metadata clean on non-NVMe devices. Story: 2009264 Task: 43498 Change-Id: I445d8f4aaa6cd191d2e540032aed3148fdbff341
* | | Merge "CI: be explicit that the jobs are using the DIB ramdisk"Zuul2022-03-121-0/+2
|\ \ \
| * | | CI: be explicit that the jobs are using the DIB ramdiskDmitry Tantsur2022-02-031-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently it requires tracing the jobs up to the ironic's devstack plugin. Be explicit. Change-Id: I19d0e680b0025bda22709c5a4fff9eacb5b4b1d0
* | | | Merge "Add non-voting dib CentOS Stream 9 job"Zuul2022-03-111-0/+2
|\ \ \ \
| * | | | Add non-voting dib CentOS Stream 9 jobRiccardo Pittau2022-03-101-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We recently enabled voting CS9 jobs in ipa-builder, let's also add the same check job here. Change-Id: Iaf2e56e0a1f6ca35272bcaedf3cb73273080b7ef
* | | | | Merge "Create fstab entry with appropriate label"Zuul2022-03-116-10/+135
|\ \ \ \ \ | |/ / / / |/| | | |
| * | | | Create fstab entry with appropriate labelJulia Kreger2022-03-106-10/+135
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Depending on the how the stars align with partition images being written to a remote system, we *may* end up with *either* a Partition UUID value, or a Partition's UUID value. Which are distinctly different. This is becasue the value, when collected as a result of writing an image to disk *falls* back and passes the value to enable partition discovery and matching. Later on, when we realized we ought to create an fstab entry, we blindly re-used the value thinking it was, indeed, always a Partition's UUID and not the Partition UUID. Obviously, the label type is quite explicit, either UUID or PARTUUID respectively, when initial ramdisk utilities such as dracut are searching and mounting filesystems. Adds capability to identify the correct label to utilize based upon the current state of the block devices on disk. Granted, we are likely only exposed to this because of IO race conditions under high concurrecy load operations. Normally this would only be seen on test VMs, but systems being backed by a Storage Area Network *can* exibit the same IO race conditions as virtual machines. Change-Id: I953c936cbf8fad889108cbf4e50b1a15f511b38c Resolves: rhbz#2058717 Story: #2009881 Task: 44623
* | | | | Merge "Run partx in verbose mode to simplify debugging"Zuul2022-03-084-55/+55
|\ \ \ \ \
| * | | | | Run partx in verbose mode to simplify debuggingDmitry Tantsur2022-02-144-55/+55
| | |_|_|/ | |/| | | | | | | | | | | | | | | | | | | | | | | Otherwise the actual failure cause is not recorded. Change-Id: If66ee97016ddf0e5c3f40ad9400ff3bc6fdebedc
* | | | | Merge "Add `mount` and `parted -l` to the collected commands"Zuul2022-03-082-4/+10
|\ \ \ \ \
| * | | | | Add `mount` and `parted -l` to the collected commandsDmitry Tantsur2022-02-142-4/+10
| |/ / / / | | | | | | | | | | | | | | | Change-Id: I1c759552220291890704d0002a62ea3f51701691
* | | | | Merge "Rescan device after filesystem creation"Zuul2022-03-073-4/+21
|\ \ \ \ \ | |_|_|_|/ |/| | | |
| * | | | Rescan device after filesystem creationVanou Ishii2022-02-113-4/+21
| |/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In work_on_disk function, IPA runs mkfs commands without following device rescan operation. This leads to incorrect content of uuids_to_return to be returned. These mkfs commands modify partition label but IPA fails to catch such changes because of no following device rescan operation. This commit adds call of device rescan function before uuids_to_return construction. Change-Id: I4e8b30deb5e2247f51ce8f10bd3271f64a264089
* | | | Merge "Use utf-16-le if BOM not present"Zuul2022-03-022-2/+14
|\ \ \ \ | |_|/ / |/| | |
| * | | Use utf-16-le if BOM not presentRiccardo Pittau2022-02-222-2/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | In case no BOM is present in the CSV file the utf-16 codec won't work. We fail over to utf-16-le as Little Endian is commonly used. Change-Id: I3e25ce4997f5dd3df87caba753daced65838f85a
* | | | Stop defaulting the standalone job to netboot; use the correct boot modeDmitry Tantsur2022-02-211-1/+1
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | Its configuration must match one in Ironic, and netboot does not work with whole disk images under UEFI. Fix the boot mode of the BIOS job: it was running in UEFI. Change-Id: Ia207e80bbfc30f8d2891e11bbeda7b2ab0d617c0
* | | Move prepare_boot_partitions_for_softraid to raid_utilsArne Wiebalck2022-02-146-332/+343
|/ / | | | | | | | | | | | | | | | | | | | | prepare_boot_partitions_for_softraid() is used in BIOS and UEFI modes to prepare the partitions for the bootloader. Move it from the image extensions to raid_utils to reflect this and avoid the import of an extension to efi_utils. Follow-up to 62c5674a600baeeef0af3b12baeab486870eb103. Change-Id: I9f5974fbbfea5e8cdfbb7e49bea375e5cbfdd145
* | Clean up release notes8.4.0Dmitry Tantsur2022-02-032-10/+11
|/ | | | Change-Id: I568d7edfe81e928e6d7f09bd4a7933ca72b8813a
* Make the standalone job voting againDmitry Tantsur2022-02-011-7/+2
| | | | | | | | We forgot to revert it. This job covers software RAID and manual cleaning, so it's very important to avoid regressions, even if it costs us some rechecks from time to time. Change-Id: I2446afeaca866ffc3131b5e9f266526f35fc5ed7
* Use canonical device name for RAID device for ESPDmitry Tantsur2022-02-014-17/+71
| | | | | | | | | | It seems like tinyIPA silently replaces /dev/md/esp with /dev/md127. Find the next free /dev/md device and use it instead. Also rescan the resulting device before copying files. Change-Id: Ie04f530be434c4b1561e75f387b9da679e4607e0 Depends-On: https://review.opendev.org/c/openstack/ironic/+/827129/
* SoftwareRAID: Use efibootmgr (and drop grub2-install)Arne Wiebalck2022-01-267-45/+172
| | | | | | | | | | | | | | | Move the software RAID code path from grub2-install to efibootmgr: - remove the UEFI efibootmgr exception for software RAID - create and populate the ESPs on the holder disks - update the NVRAM with all ESPs (the component devices of the ESP mirror, use unique labels to avoid unintentional deduplication of entries in the NVRAM) Story: #2009794 Change-Id: I7ed34e595215194a589c2f1cd0b39ff0336da8f1
* Merge "Burn-in: Dynamic network pairing"Zuul2022-01-206-16/+293
|\
| * Burn-in: Dynamic network pairingArne Wiebalck2022-01-106-16/+293
| | | | | | | | | | | | | | | | | | | | | | | | | | Pair nodes dynamically via a distributed coordination backend for network burn-in. The algorithm uses a group to pair nodes: after acquiring a lock, a first node joins the group, releases the lock, waits for a second node, then they both leave, and release the lock for the next pair. Story: #2007523 Task: #42796 Change-Id: I572093b144bc90a49cd76929c7e8685ed45d9f6e
* | [trivial] Fix typo in __init__.pyArne Wiebalck2021-12-161-1/+1
| | | | | | | | Change-Id: I67810abbfb975c0d0ad0faf9807318c462580528
* | Re-add python 3.6/3.7 in classifierGhanshyam Mann2021-12-131-0/+2
|/ | | | | | | | | | | | | | | | | | We have updated the yoga testing runtime to keep the py36 testing. - https://review.opendev.org/c/openstack/governance/+/820195 Unit tests job template is also updated to keep python 3.6 as a voting job. So with the py3.6 and py3.9 testing as voting job template, we are keeping python 3.6, 3.7, 3.8, and 3.8 as tested versions in the Yoga cycle. - https://review.opendev.org/c/openstack/openstack-zuul-jobs/+/820286 This commit re-add the python 3.6/3.7 versions in setup.cfg classifier. Change-Id: I0f03a7f5bb2aa07c2ec2aab1a8ebfddc0c70ca87
* Merge "Burn-in: Add options for named log files"8.3.0Zuul2021-12-093-21/+117
|\
| * Burn-in: Add options for named log filesArne Wiebalck2021-12-083-21/+117
| | | | | | | | | | | | | | | | | | | | | | | | In order to ease logging of the various burn-in steps, this patch proposes options to define the outpout files for all burn-in steps: {'agent_burnin_cpu', 'agent_burnin_vm', 'agent_burnin_fio_network', 'agent_burnin_fio_disk'}_outputfile via a node's driver-info. Story: #2007523 Task: #44102 Change-Id: I327cae5949d38e738d3c535487b3795d00ad8f1e
* | Merge "Use only Yoga tests"Zuul2021-12-091-10/+0
|\ \
| * | Use only Yoga testsRiccardo Pittau2021-12-031-10/+0
| |/ | | | | | | | | | | | | | | | | TC has decided to keep support for Python 3.6 during the Yoga cycle. For more info see [1] [1] http://lists.openstack.org/pipermail/openstack-discuss/2021-December/026164.html Change-Id: Icfe518fafa2b012e034a2e8ff18c242843df0086
* | Merge "Instruct qemu-img to write image zeros to disk."Zuul2021-12-095-7/+15
|\ \
| * | Instruct qemu-img to write image zeros to disk.Derek Higgins2021-12-085-7/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Doing this will cause it not to zero out the entire block device which can be very costly on a slow HDD. Story: 2009227 Task: 43315 Change-Id: I62ba2afc037d9844387e6b0984fe5008779d95d2
View Lorry Controller Status