summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Fix UTF-16 result handling for efibootmgrstable/zedJulia Kreger2023-04-274-63/+91
| | | | | | | | | | | | | | | | | | | | | | | | | | | | The tl;dr is that UEFI NVRAM is in encoded in UTF-16, and when we run the efibootmgr command, we can get unicode characters back. Except we previously were forcing everything to be treated as UTF-8 due to the way oslo.concurrency's processutils module works. This could be observed with UTF character 0x00FF which raises up a nice exception when we try to decode it. Anyhow! while fixing handling of this, we discovered we could get basically the cruft out of the NVRAM, by getting what was most likey a truncated string out of our own test VMs. As such, we need to also permit decoding to be tollerant of failures. This could be binary data or as simple as flipped bits which get interpretted invalid characters. As such, we have introduced such data into one of our tests involving UEFI record de-duplication. Closes-Bug: 2015602 Change-Id: I006535bf124379ed65443c7b283bc99ecc95568b (cherry picked from commit 76accfb880474445a5dcb07825889123b3dd0237)
* Make reno ignore bugfix eol tagsJay Faulkner2023-01-261-0/+2
| | | | | | | | | | Reno was assuming all tags ending in -eol represented an old, EOL'd stable branch. That's not true for Ironic projects which have bugfix branches. Update the regexp to exclude those branches. Co-Authored-By: Adam McArthur <adam@mcaq.me> Change-Id: I265969ab40a98a02962c2fc8460b6519ab576f99 (cherry picked from commit f8fc7e52f36de5c3515e60f5d2e6347a538a80d8)
* Fixes for tox 4.0Jay Faulkner2022-12-151-7/+8
| | | | | | | - passenv needed better structure - usedevelop no longer allowed alongside skipsdist Change-Id: I22dae3b1e4cca2dc328c21e889acf7fe98a80e0b
* Update TOX_CONSTRAINTS_FILE for stable/zedOpenStack Release Bot2022-09-231-4/+4
| | | | | | | | | | | | Update the URL to the upper-constraints file to point to the redirect rule on releases.openstack.org so that anyone working on this branch will switch to the correct upper-constraints list automatically when the requirements repository branches. Until the requirements repository has as stable/zed branch, tests will continue to use the upper-constraints list on master. Change-Id: I67f8b3e937f81ab9271b89f1f0bb10cd762bfa74
* Update .gitreview for stable/zedOpenStack Release Bot2022-09-231-0/+1
| | | | Change-Id: I90bb4608e46c45259542993f04253026cedf4f0b
* Merge "add openstack-python3-zed-jobs-arm64 job"9.1.0Zuul2022-09-201-0/+1
|\
| * add openstack-python3-zed-jobs-arm64 joblikui2022-08-291-0/+1
| | | | | | | | | | | | This is a non-voting job to validate py3 unittests on ARM64 Change-Id: I608d2e4e9e378b1f6e33a7e1a2cdc1c0bab7ec5c
* | SoftwareRAID: Enable skipping RAIDSJakub Jelinek2022-09-058-59/+750
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Extend the ability to skip disks to RAID devices This allows users to specify the volume name of a logical device in the skip list which is then not cleaned or created again during the create/apply configuration phase The volume name can be specified in target raid config provided the change https://review.opendev.org/c/openstack/ironic-python-agent/+/853182/ passes Story: 2010233 Change-Id: Ib9290a97519bc48e585e1bafb0b60cc14e621e0f
* | Merge "Create RAIDs with volume name"Zuul2022-09-025-44/+117
|\ \ | |/ |/|
| * Create RAIDs with volume nameJakub Jelinek2022-09-025-44/+117
| | | | | | | | | | | | | | | | Use 'volume_name' field from 'target_raid_config' to create logical disks if it is present Do not allow two logical disks to have the same volume name Change-Id: If3e4e9f8698ec3e0cb49717f8ed2087d2ba03f2c
* | Trivial: Fix reno for software raid fixJulia Kreger2022-08-251-1/+1
| | | | | | | | | | | | | | Fixes the release note for If721dfe1caa5915326482969e55fbf4697538231. Change-Id: I9971d12665f2c8a4fdfe82911c6173021d03ddc0
* | Merge "Fix software raid output poisoning"Zuul2022-08-254-1/+43
|\ \
| * | Fix software raid output poisoningJulia Kreger2022-08-244-1/+43
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In the event a device name is set to contain a raid device path, it is possible for the Name and Events field values of mdadm's detailed output to contain text which inadvertently gets captured and mapped as component data for the "holder" devices of the RAID set. This would cause invalid values to get passed to UEFI methods which would cause a deployment to fail under these circumstances. We now ignore the Name and Events fields in mdadm output. Change-Id: If721dfe1caa5915326482969e55fbf4697538231
* | | remove unicode prefix from codeniuke2022-08-232-11/+11
|/ / | | | | | | Change-Id: I70f0112f1ee3066ffd9316d10b84b9ea5b7fc306
* | Merge "Improve function list_block_devices_check_skip_list"Zuul2022-08-172-25/+20
|\ \
| * | Improve function list_block_devices_check_skip_listJakub Jelinek2022-08-162-25/+20
| | | | | | | | | | | | | | | | | | | | | | | | | | | Fix minor issues suggested by dtantsur Add an example of skip list specification to the documentation A follow-up patch to I3bdad3cca8acb3e0a69ebb218216e8c8419e9d65 Change-Id: Ic94a33b7bc0572a1cc8f92b330474ec63a173e81
* | | Merge "Enable skipping disks for cleaning"9.0.0Zuul2022-08-164-9/+265
|\ \ \ | |/ / | | / | |/ |/|
| * Enable skipping disks for cleaningJakub Jelinek2022-08-114-9/+265
| | | | | | | | | | | | | | | | | | | | | | | | Introduce a field skip_block_devices in properties - this is a list of dictionaries Create a helper function list_block_devices_check_skip_list Update tests of erase_devices_express to use node when calling _list_erasable_devices Add tests covering various options of the skip list definition Use the helper function in get_os_install_device when node is cached Story: 2009914 Change-Id: I3bdad3cca8acb3e0a69ebb218216e8c8419e9d65
* | Merge "Use lsblk json output for safety_check_block_device"Zuul2022-08-032-32/+31
|\ \ | |/ |/|
| * Use lsblk json output for safety_check_block_deviceRiccardo Pittau2022-07-202-32/+31
| | | | | | | | Change-Id: Ibfc2e203287d92e66567c33dc48f59392852b88e
* | Remove unused lines of codeJakub Jelinek2022-07-201-5/+0
| | | | | | | | | | | | | | The 5 lines of code were extracted from erase_devices_metadata to _list_erasable_devices, but now are duplicated in both functions. The variable block_devices is not used in erase_devices_metadata. Change-Id: I89f56c69d90fb0eb61907d6667266fbd57d333af
* | Merge "Guard shared device/cluster filesystems"Zuul2022-07-208-9/+499
|\ \ | |/
| * Guard shared device/cluster filesystemsJulia Kreger2022-07-198-9/+499
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Certain filesystems are sometimes used in specialty computing environments where a shared storage infrastructure or fabric exists. These filesystems allow for multi-host shared concurrent read/write access to the underlying block device by *not* locking the entire device for exclusive use. Generally ranges of the disk are reserved for each interacting node to write to, and locking schemes are used to prevent collissions. These filesystems are common for use cases where high availability is required or ability for individual computers to collaborate on a given workload is critical, such as a group of hypervisors supporting virtual machines because it can allow for nearly seamless transfer of workload from one machine to another. Similar technologies are also used for cluster quorum and cluster durable state sharing, however that is not specifically considered in scope. Where things get difficult is becuase the entire device is not exclusively locked with the storage fabrics, and in some cases locking is handled by a Distributed Lock Manager on the network, or via special sector interactions amongst the cluster members which understand and support the filesystem. As a reult of this IO/Interaction model, an Ironic-Python-Agent performing cleaning can effectively destroy the cluster just by attempting to clean storage which it percieves as attached locally. This is not IPA's fault, often this case occurs when a Storage Administrator forgot to update LUN masking or volume settings on a SAN as it relates to an individual host in the overall computing environment. The net result of one node cleaning the shared volume may include restoration from snapshot, backup storage, or may ultimately cause permenant data loss, depending on the environment and the usage of that environment. Included in this patch: - IBM GPFS - Can be used on a shared block device... apparently according to IBM's documentation. The standard use of GPFS is more Ceph like in design... however GPFS is also a specially licensed commercial offering, so it is a red flag if this is encountered, and should be investigated by the environment's systems operator. - Red Hat GFS2 - Is used with shared common block devices in clusters. - VMware VMFS - Is used with shared SAN block devices, as well as local block devices. With shared block devices, ranges of the disk are locked instead of the whole disk, and the ranges are mapped to virtual machine disk interfaces. It is unknown, due to lack of information, if this will detect and prevent erasure of VMFS logical extent volumes. Co-Authored-by: Jay Faulkner <jay@jvf.cc> Change-Id: Ic8cade008577516e696893fdbdabf70999c06a5b Story: 2009978 Task: 44985
* | Drop support for instance netbootDmitry Tantsur2022-07-076-47/+21
|/ | | | Change-Id: I2b4c543537dac8904028fdcdb590c1c214238e10
* Merge "CI: Removing ironic job queue"Zuul2022-07-051-1/+0
|\
| * CI: Removing ironic job queueJulia Kreger2022-05-191-1/+0
| | | | | | | | | | | | | | Please see: https://zuul-ci.org/docs/zuul/latest/releasenotes.html#relnotes-4-1-0-deprecation-notes Change-Id: I341b8a2220a49c5a7c3f78fed3a1baa0f0638cde
* | Merge "Fix passing kwargs in clean steps"Zuul2022-07-044-1/+73
|\ \
| * | Fix passing kwargs in clean stepswaleedm2022-07-014-1/+73
| | | | | | | | | | | | | | | | | | | | | | | | Pass kwargs to dispatch_to_managers method in execute_clean_step Change-Id: Ida4ed4646659b2ee3f8f92b0a4d73c0266dd5a99 Story: 2010123 Task: 45705
* | | Merge "Drop python2 from bindep.txt"Zuul2022-07-021-3/+1
|\ \ \
| * | | Drop python2 from bindep.txtPavlo Shchelokovskyy2022-06-301-3/+1
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | IPA dropped support for Python2 long ago, and now Python2 is not even available in newer distros, breaking installation if IPA binary dependencies. Depends-On: https://review.opendev.org/c/openstack/ironic/+/848345 Change-Id: I75a618f94de58f6de2bd96b37de1894bb0e61998
* | | Merge "Gather details about bond interfaces if present"Zuul2022-07-023-11/+66
|\ \ \
| * | | Gather details about bond interfaces if presentDerek Higgins2022-06-213-11/+66
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | If present gather information about bonded interfaces. Story: #2010093 Task: #45637 Change-Id: I394187640b4788ebec21c3391d33ed728fb72ffa
* | | Merge "Remove oslo.serialization dependency"Zuul2022-07-027-27/+33
|\ \ \
| * | | Remove oslo.serialization dependencyRiccardo Pittau2022-06-177-27/+34
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Use pure json instead of jsonutils. Borrow encode function from oslo.serialization to be used in the utils module. Change-Id: Ied9a2259a4329a86b4f0853bd1fb187563c0a036
* | | | Merge "Collect udev properties in the ramdisk logs"Zuul2022-07-023-4/+89
|\ \ \ \
| * | | | Collect udev properties in the ramdisk logsDmitry Tantsur2022-06-173-4/+89
| | |/ / | |/| | | | | | | | | | Change-Id: Ifcf3dfff00b604dec1e2f430369ab8053f50f137
* | | | Merge "Use json for lsblk output"Zuul2022-06-304-201/+226
|\ \ \ \ | | |/ / | |/| |
| * | | Use json for lsblk outputRiccardo Pittau2022-06-144-201/+226
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | The lsblk output is available in json format since version 2.27 of util-linux [1] https: //mirrors.edge.kernel.org/pub/linux/utils/util-linux/v2.27/v2.27-ReleaseNotes Change-Id: I0c5812736b7a320cc4ecc333f80db70eb78cc76d
* | | Merge "Warn when smartctl not found"Zuul2022-06-271-1/+2
|\ \ \
| * | | Warn when smartctl not foundMark Goddard2022-06-241-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently, if smartctl is not found by IPA, it will silently skip ATA secure erase and proceed to shred (if enabled). This is supposedly for backwards compatibility, but is quite hard to diagnose. This change adds a warning message to make it more obvious what is happening. TrivialFix Change-Id: I03a381e99de79f201ec7e9a388777c3d48457e93
* | | | Merge "Add ipa-tox-examples job to gate"Zuul2022-06-251-0/+1
|\ \ \ \
| * | | | Add ipa-tox-examples job to gateRiccardo Pittau2022-05-311-0/+1
| | |/ / | |/| | | | | | | | | | | | | | | | | | The ipa-tox-examples job is voting but it's missing from gate Change-Id: Ie47066084172d8e06eb1f6f097b0354b3b800612
* | | | Merge "Remove importlib-metadata from requirements"Zuul2022-06-242-7/+1
|\ \ \ \
| * | | | Remove importlib-metadata from requirementsRiccardo Pittau2022-06-212-7/+1
| |/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | We don't need it anymore as we don't support python < 3.8 Also it was removed from global requirements so it breaks the requirements check. Change-Id: Ia12cbef3515f823fdd627a36020cf7801bf6d734
* | | | Merge "Drop support for Python 3.6 and 3.7"Zuul2022-06-231-3/+1
|\ \ \ \
| * | | | Drop support for Python 3.6 and 3.7Riccardo Pittau2022-05-311-3/+1
| |/ / / | | | | | | | | | | | | | | | | | | | | | | | | It has been removed from Zed and we're now testing with Python 3.9 in tinyipa and Python 3.8 in CentOS Stream 9 Change-Id: I028121d593b910e585f44e464c7fcb3e635420e8
* | | | Fix discovering WWN/serial for devicemapper devicesDmitry Tantsur2022-06-143-16/+31
|/ / / | | | | | | | | | | | | | | | | | | UDev prefix is DM_ not ID_ for them. On top of that, they don't have short serials (or at least don't always have). Change-Id: I5b6075fbff72201a2fd620f789978acceafc417b
* | | Merge "Add a metalsmith job with legacy boot"Zuul2022-05-302-2/+16
|\ \ \
| * | | Add a metalsmith job with legacy bootDmitry Tantsur2022-05-172-2/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | With netboot removal, this will be the only job that tests local legacy boot with partition images. Depends-On: https://review.opendev.org/c/openstack/metalsmith/+/841911 Change-Id: Id3f165286cfc47dcf45c042115a63804a0c671e8
* | | | Update oslo.log requirement to 4.6.1Julia Kreger2022-05-241-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously IPA was set to enforce a minimum version of 3.36.0 which was a Python2 version build which does did not support more recent versions of python. Given that relationship is realistically impossible moving the minimum to something released a bit more recently, in this case 4.6.1. Change-Id: Ibfbcc1196eb9f583ba9d79bae7988d64de514f6d
View Lorry Controller Status