summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorZuul <zuul@review.opendev.org>2020-08-05 23:44:54 +0000
committerGerrit Code Review <review@openstack.org>2020-08-05 23:44:54 +0000
commitf084006293acedb3f2c9242076e05e2461ec247b (patch)
treebd9ae9b9f0cd62347dedccd96fa67a52941847f4
parent6026481415cb2900236583cc796949d4445e81f3 (diff)
parent040523ad1066a77f19134df129275938bee45d04 (diff)
downloadironic-f084006293acedb3f2c9242076e05e2461ec247b.tar.gz
Merge "Log the traceback of unexpected errors when verifying power credentials"
-rw-r--r--ironic/conductor/manager.py5
1 files changed, 4 insertions, 1 deletions
diff --git a/ironic/conductor/manager.py b/ironic/conductor/manager.py
index f75029eaa..3c54ef6ce 100644
--- a/ironic/conductor/manager.py
+++ b/ironic/conductor/manager.py
@@ -1228,6 +1228,8 @@ class ConductorManager(base_manager.BaseConductorManager):
error = (_('Failed to validate power driver interface for node '
'%(node)s. Error: %(msg)s') %
{'node': node.uuid, 'msg': e})
+ log_traceback = not isinstance(e, exception.IronicException)
+ LOG.error(error, exc_info=log_traceback)
else:
try:
power_state = task.driver.power.get_power_state(task)
@@ -1235,6 +1237,8 @@ class ConductorManager(base_manager.BaseConductorManager):
error = (_('Failed to get power state for node '
'%(node)s. Error: %(msg)s') %
{'node': node.uuid, 'msg': e})
+ log_traceback = not isinstance(e, exception.IronicException)
+ LOG.error(error, exc_info=log_traceback)
if error is None:
if power_state != node.power_state:
@@ -1246,7 +1250,6 @@ class ConductorManager(base_manager.BaseConductorManager):
else:
task.process_event('done')
else:
- LOG.error(error)
node.last_error = error
task.process_event('fail')