summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDevananda van der Veen <devananda.vdv@gmail.com>2014-09-29 15:59:36 -0700
committerDevananda van der Veen <devananda.vdv@gmail.com>2014-09-29 16:28:09 -0700
commit56245fcda083eef031385cf309b7bed39536b2c7 (patch)
tree02b638f95aef5925c59eaf778a77cc44547cbf4e
parent8a0923c437acf5bd840dc7f64db5e555962c15ac (diff)
downloadironic-56245fcda083eef031385cf309b7bed39536b2c7.tar.gz
Stop running check_uptodate in the pep8 testenv
As per this discussion on the mailing list: http://lists.openstack.org/pipermail/openstack-dev/2014-September/047160.html We are going to stop enforcing the correctness of the sample config file, and move to a separate non-voting check test that notifies us when it is no longer accurate, thus prompting a human to correct it. This addresses the issue where config options in dependent libraries (eg. keystone) repeatedly break our gate, without removing the sample config file that deployers benefit from. Change-Id: Ief88a693e4967b32f5f2f71b9a683599527a5129
-rw-r--r--tox.ini9
1 files changed, 8 insertions, 1 deletions
diff --git a/tox.ini b/tox.ini
index 2c792d173..b5ed9dab5 100644
--- a/tox.ini
+++ b/tox.ini
@@ -20,7 +20,6 @@ downloadcache = ~/cache/pip
[testenv:pep8]
commands =
flake8 {posargs}
- {toxinidir}/tools/config/check_uptodate.sh
# Check that .po and .pot files are valid:
bash -c "find ironic -type f -regex '.*\.pot?' -print0|xargs -0 -n 1 msgfmt --check-format -o /dev/null"
@@ -29,7 +28,15 @@ setenv = VIRTUAL_ENV={envdir}
commands =
python setup.py testr --coverage {posargs}
+[testenv:checkconfig]
+sitepackages = False
+envdir = {toxworkdir}/venv
+commands =
+ {toxinidir}/tools/config/check_uptodate.sh
+
[testenv:genconfig]
+sitepackages = False
+envdir = {toxworkdir}/venv
commands =
bash tools/config/generate_sample.sh -b . -p ironic -o etc/ironic