Refactor vendor detection and add Redfish implementation

Get rid of the TODO in the code and prepare for more management
interfaces supporting detect_vendor(). Vendor detecting now runs
during transition to manageable and on power state sync (essentially
same as before but for all drivers not only IPMI).

Update the IPMI implementation to no longer hide exceptions since
they're not handled on the upper level. Simplify the regex and fix
the docstring.

Add the Redfish implementation as a foundation for future
vendor-specific changes.

Change-Id: Ie521cf2295613dde5842cbf9a053540a40be4b9c

1 files changed, 15 insertions, 0 deletions

diff --git a/ironic/drivers/modules/redfish/management.py b/ironic/drivers/modules/redfish/management.py
index 2e89d0aa1..9d49a21eb 100644
--- a/ironic/drivers/modules/redfish/management.py
+++ b/ironic/drivers/modules/redfish/management.py
@@ -677,6 +677,21 @@ class RedfishManagement(base.ManagementInterface):
                                 'component': component,
                                 'uuid': task.node.uuid})
 
+    def detect_vendor(self, task):
+        """Detects and returns the hardware vendor.
+
+        Uses the System's Manufacturer field.
+
+        :param task: A task from TaskManager.
+        :raises: InvalidParameterValue if an invalid component, indicator
+            or state is specified.
+        :raises: MissingParameterValue if a required parameter is missing
+        :raises: RedfishError on driver-specific problems.
+        :returns: String representing the BMC reported Vendor or
+                  Manufacturer, otherwise returns None.
+        """
+        return redfish_utils.get_system(task.node).manufacturer
+
     @METRICS.timer('RedfishManagement.update_firmware')
     @base.clean_step(priority=0, abortable=False, argsinfo={
         'firmware_images': {