diff options
| author | Dmitry Tantsur <divius.inside@gmail.com> | 2016-11-23 16:17:58 +0100 |
|---|---|---|
| committer | Dmitry Tantsur <divius.inside@gmail.com> | 2016-12-01 09:59:48 +0100 |
| commit | 6e981156c83c4d7217e985c88553548d5924c601 (patch) | |
| tree | 462e8c488218b95c108896e616ea52d5dd35988d /releasenotes/notes/create-on-conductor-c1c52a1f022c4048.yaml | |
| parent | 9d4e1070e9e0e098aeb81e5805eff8d768322d65 (diff) | |
| download | ironic-6e981156c83c4d7217e985c88553548d5924c601.tar.gz | |
Move interface validation from API to conductor side
This change moves the check on network interface to driver_factory.py
and moves node creation from API to conductor side. A new exception
InterfaceNotFoundInEntrypoint (similar to DriverNotFoundInEntrypoint)
was introduced for the case when invalid interface is requested either
during creation or during updating.
The current approach already duplicates the check in two places.
With the driver composition in place it will not be quite possible:
different conductors may have different interfaces enabled as long as
no hardware type ends up with different interfaces on different
conductors. Also when calculating the defaults, we'll need access
to a real hardware type object, which may not be possible on API side.
Also there is a demand for driver-side validations on creation
(e.g. detecting duplicating IPMI addresses), which also requires
creation to happen on conductor side. Such features, however, are
out of scope for this change.
A side effect of this change is that objects.Node.network_interface
is now defined the same way as other interfaces (i.e. nullable string).
Also added more clean ups to base unit test class, as otherwise newly
added tests randomly break other tests.
Change-Id: Id1da20ccd5bb50e61a82449ef3d2ffce91822d71
Partial-Bug: #1524745
Diffstat (limited to 'releasenotes/notes/create-on-conductor-c1c52a1f022c4048.yaml')
| -rw-r--r-- | releasenotes/notes/create-on-conductor-c1c52a1f022c4048.yaml | 11 |
1 files changed, 11 insertions, 0 deletions
diff --git a/releasenotes/notes/create-on-conductor-c1c52a1f022c4048.yaml b/releasenotes/notes/create-on-conductor-c1c52a1f022c4048.yaml new file mode 100644 index 000000000..82d02642a --- /dev/null +++ b/releasenotes/notes/create-on-conductor-c1c52a1f022c4048.yaml @@ -0,0 +1,11 @@ +--- +upgrade: + - In this release node creation logic was moved from the API service to + the conductor service. This is more consistent with other node operations + and opens opportunities for conductor-side validations on nodes. + However, with this change, node creation may take longer, and this may + limit the number of nodes that can be enrolled in parallel. + - The "[DEFAULT]default_network_interface" and "[dhcp]dhcp_provider" + configuration options were previously required for the ironic-api service + to calculate the correct "network_interface" default. Now these options + are only read by the ironic-conductor service. |