summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Move ipmi logging to a separate optionJulia Kreger2020-04-034-5/+25
| | | | | | | | | | | | | | | | | | | | The IPMI verbose output being turned on by the debug option is confusing and misleading, and since many operators run ironic in debug mode anyway, it doesn't make much sense to spam logs with errors and information that can be misleading to a less experienced operator. Also... less logging output. Back-porting per discussion[0] in IRC where we believe this is the best action possible and the verbose ipmitool output tends not to be extremely helpful for operators. [0]: http://eavesdrop.openstack.org/irclogs/%23openstack-ironic/%23openstack-ironic.2020-04-01.log.html#t2020-04-01T16:02:43 Change-Id: I0fae7bad5613865dfd4d1c663be08d40debe157a (cherry picked from commit 1e514b64404ee668ff0651ffb2ad30217f5b1b81) (cherry picked from commit 3e5816e10a18d3d001aeb73ecb3595e9488e764d)
* Retry agent get_command_status upon failuresJulia Kreger2020-03-273-1/+31
| | | | | | | | | | | | | | | | | | | The agent command status code lacks any retry mechanism which meant if any intermittent failure such as a dropped packet or an overloaded firewall could potentially begin to cause the entire deployment or cleaning process to derail and fail. This fix addes logic to ensure we retry upon such failures. Worth noting, the exact same logic has been used elsewhere in the agent client code for the exact same problem when issuing commands. Change-Id: I4f6581b7fb895ed2b1d505b9947e363665551b57 Story: 2007470 Task: 39158 (cherry picked from commit 242775ae184582ce51a006e5797e7017133617f3)
* Merge "Don't require root partition when installing a whole disk image" into ↵12.1.4Zuul2020-03-203-7/+53
|\ | | | | | | stable/stein
| * Don't require root partition when installing a whole disk imageBob Fournier2020-02-133-7/+53
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | With the change to find the bootloader on disk (https://review.opendev.org/#/c/696914/) install_bootloader should now be invoked when doing an iscsi_deploy even if the root partition cannot be found. Fixed Conflicts: - ironic/drivers/modules/agent_base_vendor.py - ironic/tests/unit/drivers/modules/test_agent_base_vendor.py Depends-On: I7167e71e5d2352a045565289b200e5530d0ba11d Change-Id: I4f2cecdc0af366364b18232dbd8ea4ffdd3165d2 (cherry picked from commit d614d86eef0db7fd9784f4d81a3369841c5a9eb3)
* | Merge "Revamp grenade jobs" into stable/steinZuul2020-03-181-0/+4
|\ \
| * | Revamp grenade jobsRiccardo Pittau2020-03-161-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | Grenade job has been fixed for stein in [1] so adding the related jobs back again. [1] https://review.opendev.org/#/c/713014/ Change-Id: Id9763481961f20f11f129398ed9813e9ccc0f33e
* | | Merge "tell reno to ignore the kilo branch" into stable/steinZuul2020-03-161-0/+4
|\ \ \ | |/ / |/| |
| * | tell reno to ignore the kilo branchDoug Hellmann2020-02-101-0/+4
| |/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When reno 3.x runs under setuptools, it scans all of the branches it can find, including any that look like they're closed and have an -eol tag. The old kilo branch in this repository has a jumbled history that somehow makes it look like it should include tags that it doesn't. We know that there are no release notes in that branch, because reno wasn't adopted while it was open. The releasenotes/source/index.rst links to separate release notes in the wiki. This patch tells reno to ignore that branch so that it doesn't throw an exception when it gets confused about the old tag. Story: #2007274 Task: #38710 Change-Id: I8047d805b0a3da4051a6d618ed9ac40875b8636a Signed-off-by: Doug Hellmann <doug@doughellmann.com> (cherry picked from commit 0f4b9e38a2924a693e17d815b16f19223f16632a)
* | Disable grenade jobs from SteinJulia Kreger2020-03-091-4/+0
|/ | | | | | | | | Rocky is heading into Extended maintenance which means shouldn't really be worrying about upgrade jobs anymore. As such, removing the grenade jobs from testing. Change-Id: Ica0ea37acea44d5b5e6a1927be5d9c51b8f5bba6
* [stable] consume virtualbmc from pip packagesDmitry Tantsur2020-01-034-8/+0
| | | | | | | | | | The virtualbmc master has dropped support for Python 2, breaking stable CI jobs. Since we expect this to be a one-time breakage, limit the existing stable branches to virtualbmc in upper-constraints by removing it from required projects in the CI jobs. Change-Id: I15464410c9e74b915a647bffbaac02770d15f6b2 (cherry picked from commit 7c993afb1f1a4389a5a7582925f6ff6a2e9b3b81)
* Add timeout when querying agent's command statusesVladyslav Drok2019-11-283-1/+17
| | | | | | | | | | | Otherwise the node can get locked up for a significant amount of time. It conforms to the behaviour of all other (POST) HTTP requests done to agent. Story: 2006946 Task: 37626 Change-Id: I968606a300bc43675d7bd07f73de37967ef80c26 (cherry picked from commit 33a84d94eb4d495312e3ba750b194213737a8933)
* Pass correct flags during PXE cleanup in iPXEBootVladyslav Drok2019-11-206-10/+26
| | | | | | | | | | | They were not handled correctly and ipxe-related configs were left after node tear down. Story: 2006907 Task: 37549 Change-Id: I1ee6727d2fc52619544e327a10a62ae8a7e6f7fe (cherry picked from commit 8e39fe9d44ea79b7df6d6f0b903c2806624c4e92) (cherry picked from commit 24fc7894628ed10d2587982f30aa898c10e5416e)
* Merge "Change MTU logic to allow for lower MTUs automatically" into stable/steinZuul2019-10-232-3/+5
|\
| * Change MTU logic to allow for lower MTUs automaticallyJulia Kreger2019-10-232-3/+5
| | | | | | | | | | | | | | | | Conflicts: zuul.d/ironic-jobs.yaml Change-Id: I40d357e716b589585493824cfd963fd5f579bd81 (cherry picked from commit cf074202e50426365c761326c8d2ccfcce4ad916)
* | Merge "Do not ignore 'fields' query parameter when building next url" into ↵12.1.3Zuul2019-10-2320-9/+200
|\ \ | |/ |/| | | stable/stein
| * Do not ignore 'fields' query parameter when building next urlArun S A G2019-10-2220-9/+200
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When an user calls the GET on an ironic resource it returns MAX_LIMIT number of resources at a time along with a next url. The default MAX_LIMIT is 1000. If the user requested specific set of fields from ironic API using the fields query parameter (eg: /v1/resource?fields=f1,f2,f3) The next url returned by the API ignores fields query parameter. This results in fields missing from the results after MAX_LIMIT is reached. This change fixes this problem by passing the fields as parameter to collections.get_next method and using the fields argument to build the query parameter. Change-Id: I62b59e8148171c72de0ccf63a1517e754b520c76 Story: 2006721 Task: 37093 (cherry picked from commit e36f72d36da53ff5439d0e5a19561bed9e792b06)
* | Merge "Mask secrets when logging in json_rpc" into stable/steinZuul2019-10-224-4/+63
|\ \ | |/ |/|
| * Mask secrets when logging in json_rpcDmitry Tantsur2019-10-224-4/+63
| | | | | | | | | | | | | | | | | | Otherwise passwords are displayed in plain text in the DEBUG logs. Change-Id: I4210492bc7cb42b205d2b93a018bfaa25bfe5752 Story: #2006744 Task: #37216 (cherry picked from commit 3ab93f0c84a5a8e2551f31c7f6ea24fc62ae79a9)
* | Read in non-blocking fashion when starting consoleVladyslav Drok2019-10-183-23/+108
|/ | | | | | | | | | | | | | As PID file is created by daemon, it might happen that although the return code is 0, the PID file does not exist yet. And afterwards, communicate() call might hang for some reason. As there is no way to put timeout on communicate call in python2, and in order to make this change more backportable, this patch uses non-blocking read to get the values of stdout and stderr of the call. Story: 2006514 Task: 36511 Change-Id: I0bf38321b0135ea17439d35081b5727fd4d827c8 (cherry picked from commit efc2d5fcd3e4c3d8e24801b45f61f7f747b7f340)
* grub configuration should use user kernel & ramdiskshenjiatong2019-10-083-4/+9
| | | | | | | | | | compared with pxe_config.template, ramdisk boot with grub should use aki_path and ari_path Change-Id: Ibedf375cfeeb20917f06e52b1e86a6990a3c494b Story: 2006639 Task: 36855 (cherry picked from commit 2364c8b247899f8ac9fb42b53a070db2ea50a2e0)
* Change log level based on node statusRiccardo Pittau2019-10-041-6/+14
| | | | | | | | | | | While the status node change message is purely informational, it can contain also failed states transitions. Moving the level from INFO to ERROR if the provision_state is 'failed' can help in detecting the transition message when troubleshooting issues. Change-Id: I79ff7cb8b9d33bc2837d41126fba269a5d4b1cda (cherry picked from commit b8fa188a29481b11b2f3117cdeecfd920a8f5a0e)
* Fix typo in handling of exception FailedToGetIPAddressOnPortJan Horstmann2019-09-162-3/+4
| | | | | | | | | | | Function create_pxe_config in ironic/common/pxe_utils.py tried to handle exception FailedToGetIPaddressesOnPort. However, the raised exception is called FailedToGetIPAddressOnPort. Change-Id: I33e51f064daa0a0d70dd87e163d401c0e7b922bc Story: 2006478 Task: 36419 (cherry picked from commit 22db498ea1d02119d7662f566e299d04a09e9ae5)
* Do not wait for console being started on timeoutVladyslav Drok2019-08-283-14/+48
| | | | | | | | | | | | | Current logic tries to call communicate on Popen object when starting shellinabox console even if console.subprocess_timeout is hit. This blocks until the command is finished, with timeout having no effect on it. It means that node lock is not released until communicate call finishes. Story: 2006429 Task: 36333 Change-Id: Ic7b878cd432990218a3d87047905ce0828b8da2a (cherry picked from commit 1ad73338b83ac0bf1e3a48298fe00a922bd571a2)
* Asynchronous out of band deploy steps fails to executeShivanand Tendulker2019-08-2011-10/+213
| | | | | | | | | | | | | | | Asynchronous out of band steps in a deploy template fails to execute. This commit fixes that issue. Asynchronous steps can set 'skip_current_deploy_step' flag to False in 'driver_internal_info' to make sure that upon reboot same step is re-executed. Also it can set 'deployment_reboot' flag to True in 'driver_internal_info' to signal that it has rebooted the node. Co-Authored-By: Mark Goddard <mark@stackhpc.com> Change-Id: If6217afb5453c311d5ca71ba37458a9b97c18395 Story: 2006342 Task: 36095 (cherry picked from commit 8f907886a1ed0de70c34aef84ba892c3e6a5cd49)
* Merge "Check for deploy.deploy deploy step in heartbeat" into stable/steinZuul2019-08-163-14/+175
|\
| * Check for deploy.deploy deploy step in heartbeatMark Goddard2019-08-143-14/+175
| | | | | | | | | | Change-Id: Id160e37348c940055c312fbfdb05a27d13012f52 (cherry picked from commit b5e34e16731b47d1930bcdc99d184b1319493f1a)
* | Merge "RAID creation fails with 'ilo5' RAID interface" into stable/steinZuul2019-08-153-30/+28
|\ \
| * | RAID creation fails with 'ilo5' RAID interfaceShivanand Tendulker2019-08-053-30/+28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | RAID interface methods do not clear driver_internal_info properly leads to failure of RAID operation when they are attempted again. Change-Id: I3cd133fb700ec4946471d9e4cbebeab4bded4540 Story: 2006321 Task: 36052 (cherry picked from commit 6305ea70077f031f5033e7bb33b9321178f0c413)
* | | Merge "Fixes power-on failure for 'ilo' hardware type" into stable/steinZuul2019-08-143-6/+59
|\ \ \
| * | | Fixes power-on failure for 'ilo' hardware typeShivanand Tendulker2019-08-033-6/+59
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Server fails to return success for power-on operation if no bootable device is found. (Note) Two tescases are added as testcases modified in master branch cannot be modified here. This was required as the configuration parameter [ilo]power_retry which was marked for obsolescence in Stein release has been removed in Train release. Change-Id: I0e6ab307ecd0caaf7b79edff67373be3490bfed7 Story: 2006288 Task: 35997 (cherry picked from commit 49140989d185a021bc346ea55d7a63b91541baac)
* | | Merge "iLO firmware update fails with 'update_firmware_sum' clean step" into ↵Zuul2019-08-133-4/+29
|\ \ \ | |_|/ |/| | | | | stable/stein
| * | iLO firmware update fails with 'update_firmware_sum' clean stepShivanand Tendulker2019-08-053-4/+29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Firmware update using 'update_firmware_sum' clean step fails with an error stating that unable to connect to iLO address due to authentication failure. The 'update_firmware_sum' is an inband clean step wherein the firmware ISO was inserted from IPA ramdisk. As part of security fix to ironic the BMC credentials are no more passed to the IPA ramdisk. The attempt to connect to iLO from IPA ramdisk fails. The fix has been made to insert the firmware ISO from the conductor. Change-Id: I866330c5fc98b1c5bc042c296c3b6e76ed9fd57d Story: 2006223 Task: 35821 (cherry picked from commit 50bfd9067fdeebcc89117ddab4fdd1573dba565e)
* | | Merge "Fixing broken links" into stable/steinZuul2019-08-094-7/+14
|\ \ \
| * | | Fixing broken linksAlexandra Settle2019-08-094-7/+14
| | | | | | | | | | | | | | | | | | | | Change-Id: Ie3b699a0010c88366a0814db28fc7cbac123a8b2 Backport: stein rocky
* | | | Merge "Enable testing adoption in the CI" into stable/steinZuul2019-08-091-1/+5
|\ \ \ \ | |/ / / |/| | |
| * | | Enable testing adoption in the CIDmitry Tantsur2019-08-031-1/+5
| | |/ | |/| | | | | | | | | | | | | Change-Id: Id175e0573b9ff76fd1b6c2e57af774e943ae1476 Depends-On: https://review.opendev.org/672286 (cherry picked from commit 363e50cab81bfd4ad73b27bcac6ac5b567ec0447)
* | | Merge "Ansible module: fix deployment for private and/or shared images" into ↵Zuul2019-08-073-23/+42
|\ \ \ | | | | | | | | | | | | stable/stein
| * | | Ansible module: fix deployment for private and/or shared imagesRaphael Glon2019-07-293-23/+42
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The ansible module deployment was broken for private/shared images because the original request context was not available anymore at the time the image informations were fetched Change-Id: Id35dcf8ddc209bb8318433d6bf26aba848e074ee Story: #2006178 Task: #35702 (cherry picked from commit d0c31d748d3e6ccc05a0452bac5eb67eaca19763)
* | | | Merge "Direct bridge to be setup" into stable/steinZuul2019-08-072-2/+6
|\ \ \ \
| * | | | Direct bridge to be setupJulia Kreger2019-08-062-2/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The multinode jobs are failing because the br-infra bridge is not being setup. It is not being setup because somewhere in the infra, the multi-node-bridge role is never established as a requirement. Realistically, only ironic does this, but we need to ensure it is present. Change-Id: Ia1dcc68d7e75a931e01829ce23da36c978a70765 (cherry picked from commit bda02c43fb022a155157402764cd5a74478b8cf1)
* | | | | Merge "CI: stop using pyghmi from git master" into stable/steinZuul2019-08-064-8/+0
|\ \ \ \ \ | |/ / / / |/| | | |
| * | | | CI: stop using pyghmi from git masterDmitry Tantsur2019-07-304-8/+0
| |/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It's just a library we consume, there is no reason to use its git head. Currently 1.4.0 is breaking us. Story: #2006301 Task: #36014 Change-Id: Ib1b1e32bc60d7ec271098dcd17086f79518c09df (cherry picked from commit 3dfce5f2de6377d74632bb2a7fe3d382ccc629b0)
* | | | Merge "Filter security group list on the ID's we expect" into stable/steinZuul2019-08-053-17/+32
|\ \ \ \ | |_|_|/ |/| | |
| * | | Filter security group list on the ID's we expectHarald Jensås2019-07-303-17/+32
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Filter the list of security groups based on the security group IDs we plan on using for the network. Also only get the id field as this is all we need to compare. Fixes an issue where deployment fail on systems with a high number of security groups. Story: 2006256 Task: 35871 Change-Id: I83bbd3c77f13aaab0912354c3ec9cdd5e1123d0f (cherry picked from commit 59787768cbf1d757611be27406777a088fb16659)
* | | Merge "Fix serial/wwn gathering for ansible+python3" into stable/steinZuul2019-08-032-1/+7
|\ \ \
| * | | Fix serial/wwn gathering for ansible+python3Raphael Glon2019-07-242-1/+7
| |/ / | | | | | | | | | | | | | | | | | | Change-Id: Ifd0c3d6be14c9e1369624bb4a02043e7345f4a03 Story: #2006266 Task: #35957 (cherry picked from commit 54054c0e5ab5ad250b51d3521e980ca5f4931a75)
* | | Merge "Ansible driver: fix deployment with serial specified as root device ↵Zuul2019-08-033-3/+13
|\ \ \ | |_|/ |/| | | | | hint" into stable/stein
| * | Ansible driver: fix deployment with serial specified as root device hintRaphael Glon2019-08-023-3/+13
| |/ | | | | | | | | | | | | Change-Id: Ie0d56da52ae8476d9f9860c967e8e31253a63c5b Story: #2006275 Task: #35975 (cherry picked from commit ba207ba3720c501499c990bcf6c3ca335055c589)
* | IPA does not boot up after cleaning reboot for 'redfish' bios interfaceShivanand Tendulker2019-07-293-21/+94
|/ | | | | | | | | | The clean steps of 'redfish' bios interface does not set up deploy ramdisk before initiating the cleaning reboot of bare metal. Change-Id: I979358ead1e19f9b24f23117d0cba3479e33707b Story: 2006217 Task: 35810 (cherry picked from commit ddc0fb831b80ac60446cc47c7ec4e1d0848411b5)
* Merge "Deal with iPXE boot interface incompatibility in Train" into stable/stein12.1.2Zuul2019-07-153-2/+29
|\
View Lorry Controller Status