summaryrefslogtreecommitdiff
path: root/ironic/tests/unit/drivers/modules/ilo/test_inspect.py
Commit message (Collapse)AuthorAgeFilesLines
* Fix RedfishManagement.get_mac_addresses and related functionsDmitry Tantsur2021-11-091-7/+14
| | | | | | | | | | | RedfishManagement.get_mac_addresses has two problems: * It returns a dict while the base class documents returning a list * The dict's values are Redfish-specific values This change fixes this function to return a list and significantly simplifies the related create_ports_if_not_exists. Change-Id: I329cabe04662d0d668d4c3e04ecede5b4fdec6c6
* Add security dashboard clean steps to ilo driversankit2021-04-051-3/+10
| | | | | | | | | | | | | | | This commit adds new clean steps security_parameters_update, update_minimum_password_length and update_auth_failure_logging_threshold to allow users to edit following security parameters which fetched during node inspection - ``Password_Complexity``, ``RequiredLoginForiLORBSU``, ``RequireHostAuthentication``, ``MinPasswordLength``, ``IPMI/DCMI_Over_LAN``, ``Authentication_failure_Logging``, and ``Secure_Boot``. Story: 2008024 Task: 40736 Change-Id: I0dd9a83ee23c6b846eda3ff171ab7b3138b22fa7
* Add runtime gpu capabilities to ilo inspectionNisha Agarwal2021-03-181-0/+12
| | | | | | | | | | | | | | Add gpu related dynamic capabilities in ilo inspection. It would add following dynamic capabilities: gpu_<vendor>_count : Integer gpu_<gpu_device_name>_count : Integer gpu_<gpu_device_name> : boolean story: 2008702 task: 42023 Change-Id: Ic785fbe8a40d8a999e7e319a6505b46f82ba8344
* Switch to unittest mockIury Gregory Melo Ferreira2020-04-301-1/+1
| | | | | | | Python3 have a standard library for mock in the unittest module, let's drop the mock requirement and switch tests to unittest mock. Change-Id: I4f1b3e25c8adbc24cdda51c73da3b66967f7ef23
* Stop using six libraryRiccardo Pittau2019-12-231-2/+1
| | | | | | | | | | Since we've dropped support for Python 2.7, it's time to look at the bright future that Python 3.x will bring and stop forcing compatibility with older versions. This patch removes the six library from requirements, not looking back. Change-Id: Ib546f16965475c32b2f8caabd560e2c7d382ac5a
* Update the log message for ilo driversNisha Agarwal2019-03-011-8/+8
| | | | | | | | | | | | | This patch updates the log message for ``ilo`` drivers and extends the warning to Gen9 as well. The proliantutils fix which added active NIC inspection for Gen9 has been reverted back in I02c27d820b27bd532f23ab7ef276b39f868f5205 story: #2004950 task: #29366 Change-Id: Ifbffb782c10b952bfb3498b882f07d313d410356
* Log a warning for Gen8 InspectionNisha Agarwal2018-10-091-3/+87
| | | | | | | | | | | | | This patch adds a warning for Prolaint Gen8 server's NIC inspection. The proliantutils will start returning only active NICs starting this patch Ica624aae8f956a2da061801def6ddc43152a5b09. story: #2004950 task: #29366 Depends-On: Ica624aae8f956a2da061801def6ddc43152a5b09 Change-Id: I71feefa3d0593fd185a286bec4ce38607203641d
* Add Redfish inspect interface follow upIlya Etingof2018-11-231-6/+6
| | | | | | | | | | | This commit addresses minor issues found in patch [1]. In particular, the `drivers/modules/inspect_utils.py` module has been introduced. 1. Change-Id: Ie3167569db060620fe0b9784bc7d7a854f2ef754 Change-Id: I8499793e51fce73a94f438b8fbab20e9062df56d
* Add Redfish inspect interfaceNisha Agarwal2018-11-031-38/+6
| | | | | | | | | | | | | Add the InspectInterface to the `redfish` hardware type. This enables OOB inspection in ironic. Story: 1668487 Task: 10571 Co-Authored-By: Ilya Etingof <etingof@gmail.com> Depends-On: I3a79f2afe6c838636df554ee468f8f2e0cf0859e Depends-On: Ieb374f8cabb0418bb2680fdab690446346fc354f Change-Id: Ie3167569db060620fe0b9784bc7d7a854f2ef754
* Remove the remaining fake driversDmitry Tantsur2018-06-181-20/+3
| | | | | | | | | | | | | | | The following drivers are removed here: * fake_ilo * fake_drac * fake_irmc * fake_ucs * fake_cimc * fake_oneview Some clean up can be done in the unit tests, but this is out of scope for this change. Change-Id: Ifce3f9102384e1424d4ab624d32929f5e832206d
* Remove excessive usage of mock_the_extension_manager in unit tests - part 2Dmitry Tantsur2018-05-241-3/+2
| | | | | | | | | Also fixes incorrect oneview tests that apparently used to be hidden by that. Similarly, insufficient mocking in the PXE boot interface tests was fixed. Now only test_manager uses mock_the_extension_manager. Change-Id: Iaef9555337919706cd165adbbb2e1be9322f80b7
* Add the new capabilities to the iLO InspectInterfaceNisha Agarwal2017-08-171-6/+25
| | | | | | | | | | | | | | | | | | | | | | This patch adds the new capabilities to iLO InspectInterface as listed in the specification. It requires proliantutils version >=2.4.0 for these new capabilities. This patch also removes three capabilities keys from iLO InspectInterface - ``max_raid_level``, ``BootMode``, and ``sr_iov_devices``. max_raid_level - It cannot be discovered out-of-band using proliantutils. The capability is set during RAID configuration as ``raid_level`` instead. sr_iov_devices - It cannot be discovered out-of-band. Required Inband mechanism to discover this. BootMode - This capability required Nova to change as the value was supposed to be a list of supported boot modes on the system. Nova asked to implement the Boolean capabilities instead. Partial-Bug: 1599425 Change-Id: I64c3e471d55c2020204cf7a20e50c399e43eccf7
* Node should reflect what was savedRuby Loo2017-04-041-1/+3
| | | | | | | | | | | | | | | | | | | | | After a node is saved to the database, we weren't updating the Node object to reflect what was saved. This caused a problem where the node's update_at field was incorrect. It was fixed in 065326c0f55a73c99706148f7bfbbec87ea863bc by explicitly setting node.update_at. However, that doesn't address other node fields that may be out of sync. The more correct fix would be to do a similar thing that (most of) the other Objects do, which is for the node to update itself via ._from_db_object(). Doing this revealed several incorrect tests and code in the conductor and agent where changes to the node's dictionaries were incorrectly being set and thus, not being saved. Those are fixed in this patch. Change-Id: Ia84cd60c1a4eabcc1ad0a756124c338fa9f644c8 Closes-Bug: #1679297 Related-Bug: #1281638
* SNMP agent support for OOB inspection for iLO DriversNisha Agarwal2017-02-081-0/+2
| | | | | | | | | This patch allows to get the disk size by OOB Inspection using snmpv3 if RIBCL/RIS is unable to get it. Closes-bug: 1609622 Change-Id: Ib315dabc50b1f0b627b69781ef1c14de0d5d972c
* Fix iLO drivers to not clear local_gb if its not detectedAnkit Kumar2016-09-221-0/+43
| | | | | | | | | | | | | | In certain cases, due to hardware limitation disk data cannot be retrieved out-of-band. Currently iLO drivers overwrite the 'local_gb' property of node with '0' during inspection even when it fails to detect it. This patch fixes this behavior to ensure that the operator provided value for 'local_gb' are not overwritten if inspection fails to detect disk size. Co-Authored-By: Shivanand Tendulker <stendulker@gmail.com> Closes-bug: 1602269 Change-Id: Idad3e3fa547022da6213b048cd16c91faae3ff14
* Replace DB API call to object's method in iLO driversYuriy Zveryanskyy2016-08-221-20/+25
| | | | | | | | | | Ironic code should use versioned objects for CRUD operations if possible. This patch modifies iLO driver inspect module and changes ports creation from DB API call to Port.create() method. Related-Bug: #1606520 Change-Id: I7b3ec087663ce3a7cf30c0708830f8b1be616ee8
* Cleanup unused conf variablesMichael Still2016-05-101-2/+0
| | | | | | | | I noticed in nova that we had a lot of unused conf variables. I wondered if this was a thing in other projects as well. Turns out it is. Change-Id: Ic1c4f911c9760811aea61e0150fa69987ea08e29
* Rename utils.py to mgr_utils.py to avoid namespace collisionJohn L. Villalovos2015-10-231-1/+1
| | | | | | | | | | | | | | | | The file ironic/tests/unit/conductor/utils.py is used during testing but there is also an ironic/conductor/utils.py and then it is confusing which test_* file belongs to which file. Rename utils.py to mgr_utils.py and rename the test file Intentionally not renaming test_conductor_utils.py to test_utils.py at this time as we would lose git history for the files. This is best done in a follow-up patch. Updated all import statements for unit tests using this file. Change-Id: I5dfa1ffc01c5f54dc41a7caed83cd0bca3fb0be6
* Replace deprecated LOG.warn with warningAnton Arefiev2015-10-211-1/+2
| | | | | | | | LOG.warn is deprecated. It still used in a few places. This updates those one to use the non-deprecated LOG.warning instead. Closes-Bug: 1508442 Change-Id: Id947e4c8ae9894f480192a5ab034c24c25125788
* Move unit tests to correct directoryJohn L. Villalovos2015-09-301-0/+365
Move unit tests that test ironic/drivers/modules/* from ironic/tests/drivers/* to ironic/tests/drivers/modules/* Update any unit test imports that were broken by move. Change-Id: Ic5c2e4143ad76e9d910a4361483dc09145dc1dff
View Lorry Controller Status