| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
This issue will occurs when they validate with test-requirements in
constraints.
issue logs:
| ubuntu-xenial | Validating test-requirements.txt
| ubuntu-xenial | Requirement for package stestr has no lower bound
Change-Id: I61a25bc6ccbc97006443db8f9086bec41506e940
|
|
|
|
|
|
|
|
|
| |
Project Testing Interface for Python [0] suggests to use stestr
as unit test runner uniformly across all OpenStack projects.
[0] https://governance.openstack.org/tc/reference/pti/python.html
Change-Id: I1c321500a2256b09cb6a58f6cd7070c9dc702555
|
|
|
|
|
|
|
|
|
|
| |
Currently, ironic ignores D000 check because of error:
"D000 Cannot analyze code. Pygments package not found."
Pygments is supported from:
https://review.openstack.org/#/c/568729/
Change-Id: Ib942f47abf6facaf9967603914326aa3cb79bbd9
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
hacking is not capped in g-r and it is in
blacklist for requirement as hacking new version
can break the gate jobs.
Hacking can break gate jobs because of various
reasons:
- There might be new rule addition in hacking
- Some rules becomes default from non-default
- Updates in pycodestyle etc
That was the main reason it was not added in g-r
auto sync also. Most of the project maintained the
compatible and cap the hacking version in
test-requirements.txt and update to new version when
project is ready. Bumping new version might need code
fix also on project side depends on what new in that
version.
If project does not have cap the hacking version then,
there is possibility of gate failure whenever new hacking
version is released by QA team.
Example of such failure in recent release of hacking 1.1.0
- http://lists.openstack.org/pipermail/openstack-dev/2018-May/130282.html
Change-Id: I688a5f322bba52ae3b9fa5ecab5bed4f58fec542
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Rather than pinning pycodestyle, ignore the E402 and W503 error. Fix
issue with E731 (Do not assign a lambda expression, use a def).
W503 is something we will likely never enable as it is a personal
style decision and can change depending on the code. There is no one
right answer. Interestingly there is also a W504 which is the opposite
check.
E402 is one we should most likely fix. But it can be done in a follow
patch or patches.
List of various error codes:
https://pycodestyle.readthedocs.io/en/latest/intro.html#error-codes
Change-Id: Ie2c31a8a3c75beeef22453cab5878cf0094bdf3f
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
2.4.0 broke our pep8 tests pretty hard:
http://logs.openstack.org/20/531320/14/check/openstack-tox-pep8/c9d9d10/job-output.txt.gz#_2018-04-10_15_43_40_014738
Pin pycodestyle until we have time to fix all of those.
Note that this is in the global-requirements blacklist to allow
projects to manage those versions on their own:
https://github.com/openstack/requirements/blob/b94a4e8c8fadbdc4c5cac9c4da6755a3c06a7824/blacklist.txt#L13
Change-Id: I6b0d458c702684779eb21e7022dd0f3193ac72d2
Story: 2001819
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For compliance with the Project Testing Interface as described in:
[1] https://governance.openstack.org/tc/reference/project-testing-interface.html
[2] http://lists.openstack.org/pipermail/openstack-dev/2017-December/125710.html
[doc/requirements.txt] & [test-requirements.txt]
To support documentation generation in new PTI, project should have
list python dependencies needed for documentation in
doc/requirements.txt which are move from test-requirements.txt
[doc/source/contributor/index.rst] & [setup.cfg]
- Remove [pbr] section in setup.cfg [3], and unrelated lines in
contributor/index.rst
[3] http://lists.openstack.org/pipermail/openstack-dev/2018-March/128594.html
- Add sphinxcontrib.apidoc to replace pbr autodoc
[tox.ini]
--ignore D000: pep8 require sphinx (which move to doc/requirements.txt)
to test doc/source files, however, docs already test the doc/source.
Therefore we can ignore the D000 error code.
Depends-On: https://review.openstack.org/#/c/559327/
Change-Id: Iee90f19a5e46978a97035eab7e4b1e0ec68b8684
|
|
|
|
| |
Change-Id: I4c7930477e058a09ad90c8697b8f4b5e2c0447ad
|
|
|
|
| |
Change-Id: Id95f7b7baa9099653da2c5414661995cc22eb13c
|
|
|
|
| |
Change-Id: I76719f244c1a5cf34afa0f8c967df231fc72792f
|
|
|
|
| |
Change-Id: I9c7368b19c3774746c9562d52876021baac2e880
|
|
|
|
| |
Change-Id: I150316afff013a6c114992daf67cdc612f85251b
|
|
|
|
| |
Change-Id: I2f86b636737ffce95f1f2e1e026e8834bd8e42b4
|
|
|
|
|
|
|
|
|
|
|
|
| |
- python-subunit is not used directly anywhere
and it is dependency of both testrepository and os-testr
(probably was used by some tox wrapper script before)
- python-ironicclient is not used anywhere
(probably should've been used by functional tests,
but we still have none of those).
Change-Id: I42aeb75dab18d90d60792f070599532fd3d9af10
|
|
|
|
| |
Change-Id: I36ee4f2127fd7fef0d81e2efa69a717369472968
|
|
|
|
| |
Change-Id: I062934f70d84ee50d90a0ec189487a0f2ecb29bc
|
|
|
|
| |
Change-Id: Ic85c561d0998cc7c5027119236a2368acf1ed0fb
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Update test-requirements.txt to use latest versions of:
* flake8-import-order
* hacking
Enable the following off-by-default checks:
* [H204] Use assert(Not)Equal to check for equality.
* [H205] Use assert(Greater|Less)(Equal) for comparison.
Fix code that failed H204 and H205. In this case the fix was to add:
# noqa
As we want to ensure that these particular tests are calling the
desired comparison operators.
Change-Id: If9cba62c832e301ac81320f9142e91319f0e40a9
|
|
|
|
| |
Change-Id: I1c708b4dfeb1cf62635ea28386866e5e1fea3a42
|
|
|
|
| |
Change-Id: I54fdba274c2fa5bfa76d87b4a478e8eb40e9d355
|
|
|
|
| |
Change-Id: Ie86268aa40e0604c92d6997604ebf9d30e66a68d
|
|
|
|
| |
Change-Id: I2f1f8f76b6ec732a770707a259dc72a2f576e46c
|
|
|
|
| |
Change-Id: I905b2d66634cb0474cd5f56ca427290c423cf8a9
|
|
|
|
| |
Change-Id: I396af4a4620683a07121b908dbe645233cff8432
|
|
|
|
| |
Change-Id: Iab43081437b0df77de7c284d3000476d068c0561
|
|
|
|
| |
Change-Id: I661a08ce6d9cc94b9cd6905777b9dad1d92bd14c
|
|
|
|
| |
Change-Id: I539741ad2499a62cb2baa00f654ed377bd1fe4e1
|
|
|
|
| |
Change-Id: I244a1d6f66d61a8185ff930f0ccf73fdcaaf105a
|
|
|
|
|
|
|
|
|
| |
Since pbr already landed and the old version of hacking seems not
work very well with pbr>=2, we should update it to match global
requirement.
Partial-Bug: #1668848
Change-Id: I635dbf199bad59c72401a4de1de5200132746f6f
|
|
|
|
|
|
|
| |
Use the flake8 plugin flake8-import-order to check import ordering. It
can do it automatically and don't need reviewers to check it.
Change-Id: I821fd7467f6c5cc1487149297f26e4ad539cf25d
|
|
|
|
| |
Change-Id: I7d91c3cf6de8245ec417f0ae24cb709f64250eb9
|
|
|
|
| |
Change-Id: I3271bb35e005003656526a0406a6c3359ac71975
|
|
|
|
| |
Change-Id: I45fe35000c7f901315788d93cde80b86bb93d4aa
|
|
|
|
| |
Change-Id: I2e0528385d8cda29834e4aee0cf2d493f953d559
|
|
|
|
| |
Change-Id: I8eaceec4a9e54529d336d4f8c322e1867dd41bfd
|
|
|
|
| |
Change-Id: Ie2e6965931186692fd40e41485b353c479a76b4d
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use hacking 0.12.0
Use the new checks that are available:
[H106] Don’t put vim configuration in source files.
[H203] Use assertIs(Not)None to check for None.
[H904] Delay string interpolations at logging calls.
Fix code so tests pass.
Change-Id: I902e999687b066800e18fafd091571bf718b15f4
Depends-On: I2aa44b62f900d4dfd67701b01eadd0523fbfaf07
|
|
|
|
| |
Change-Id: I38787c559632c19fad3e61c9ee4a3ae8646e1c6c
|
|
|
|
| |
Change-Id: I6038470839de526e71db0b0df7e17092ea9476f1
|
|
|
|
| |
Change-Id: I1178b5193694c8afec1c655aa7609c9f78fee793
|
|
|
|
|
|
|
|
|
|
|
| |
This installs the basic directories and content pointing to the current
Ironic Installation Guide. Simply having this in our repo will not lead
to it being published, this is only the first step. Having these items
in our repository is a good first step to building out our install
guide.
Change-Id: I6a0e69bd3b6f5074ae61505f82f27bcf9df84bab
Partial-bug: #1612278
|
|
|
|
| |
Change-Id: I46a60d1064a4304b704df0496d59cce25a12c4b1
|
|
|
|
| |
Change-Id: I13298cf6f1939f1bf67342a826c26f50f18123f4
|
|
|
|
|
|
|
|
|
|
|
|
| |
Update the hacking test-requirement to match openstack/requirements
global-requirements.txt
Remove author lines from some files to fix error:
[H105] Don't use author tags. As we use version control instead
The hacking requirement is not updated by the proposal bot.
Change-Id: I8a35a7ebd811c477c893c7b5e854c46acc075af0
|
|
|
|
| |
Change-Id: Ibf40a95bb193c74acd1c2e320d7b27876b37b308
|
|
|
|
| |
Change-Id: I886421684ea169cd7a45dbe4441df5ffdd1272a1
|
|
|
|
| |
Change-Id: I628ea6406dc0ba1e4e041f5733b4fdbb79508cb2
|
|
|
|
| |
Change-Id: Ia70565f6277eaadc15bcdd3f8e0c8de50563f219
|
|
|
|
| |
Change-Id: I64b973cd2cad9b0c04ecc5dba92e2affed9b503d
|
|
|
|
| |
Change-Id: Ia3f8993833168ef4b7e88aa7ca39bd4af9801dbf
|