summaryrefslogtreecommitdiff
path: root/tox.ini
Commit message (Collapse)AuthorAgeFilesLines
* Put py34 first in the env order of toxThiago Paiva2015-08-261-1/+1
| | | | | | | | | | To solve the problem of "db type could not be determined" on py34 we have to run first the py34 env to, then, run py27. This patch puts py34 first on the tox.ini list of envs to avoid this problem to happen. Change-Id: Ib09cbc71149ffcc1f36495faf1c6586c4e0a0a86 Closes-bug: #1489059
* Enforce flake8 E711Lucas Alvares Gomes2015-08-131-2/+1
| | | | | | This patch enforces the rules E711 in the Ironic code base. Change-Id: Ic9395f5f6869212e4076a045ced83b57d0c16324
* Remove requirements.txt from tox.ini depsJim Rollenhagen2015-07-151-2/+1
| | | | | | | This is redundant, per lifeless email: http://lists.openstack.org/pipermail/openstack-dev/2015-July/069663.html Change-Id: Ie78d0e5b2fc8274867f2c6013b04ae9e0796f81f
* Remove db connection string env variable from tox.iniYuriy Zveryanskyy2015-07-021-6/+0
| | | | | | It is not needed with oslo.db 1.12.0. Change-Id: I49dc450d6bb84e5a75ef9ecdf248eac567c3442c
* Switch from MySQL-python to PyMySQLJeremy Stanley2015-06-221-12/+6
| | | | | | | | | | | | | | | | As discussed in the Liberty Design Summit "Moving apps to Python 3" cross-project workshop, the way forward in the near future is to switch to the pure-python PyMySQL library as a default. https://etherpad.openstack.org/p/liberty-cross-project-python3 Also set the OS_TEST_DBAPI_ADMIN_CONNECTION override variable so that oslo.db opportunistic detection will know to use PyMySQL until I12b32dc097a121bd43991bc38dd4d289b65e86c1 makes it the default behavior. Change-Id: Icd91a065d3c4f62791ba0dca99a822e3a1a0ad44 Co-Authored-By: Victor Sergeyev <vsergeyev@mirantis.com>
* Merge "Enable flake8 checking of ironic/nova/*"Jenkins2015-06-181-1/+1
|\
| * Enable flake8 checking of ironic/nova/*John L. Villalovos2015-06-121-1/+1
| | | | | | | | | | | | | | | | | | The directory ironic/nova/* was being excluded from the flake8 check. Make some minor whitespace and comment changes to ironic/nova/compute/manager.py to make it pass the flake8 checks. Change-Id: I5a76550db3b28a87964d1505441246cdb0354ee7
* | Pass environment variables of proxy to toxYuiko Takada2015-06-151-0/+1
|/ | | | | | | | | When a development environment is under a proxy, tox is failed even if environment variables of the proxy are set. This patch fix this problem. Change-Id: I650019ae86e223d5e9c2d4a5b51b92377f3c471e
* Merge "Enforce flake8 E123/6/7/8 in ironic"Jenkins2015-06-041-1/+1
|\
| * Enforce flake8 E123/6/7/8 in ironicSam Betts2015-06-041-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This patch enforces the rules E123, E126, E127, and E128 in the ironic code base: E123 - closing bracket does not match indentation of opening bracket’s line E126 - continuation line over-indented for hanging indent E127 - continuation line over-indented for visual indent E128 - continuation line under-indented for visual indent This fixes any parts of the current code which fails these rules and removes these rules from the tox.ini flake8 ignore list. Change-Id: Ia96582b5e9abc088d6c1694afc93c59be4a4065c Closes-Bug: 1421522
* | Use svg as it looks better/scales better than pngJoshua Harlow2015-06-031-1/+1
|/ | | | Change-Id: I2a17b5ddbe90fe8ea1ead53497e4dfcac5bf5647
* Revert "Add simplegeneric to py34 requirements"John L. Villalovos2015-06-021-4/+0
| | | | | | | | | | This reverts commit fe2f445418ad7cb7741a7d237fd2ad69c27833a4. WSME has been updated to 0.7 which fixes the underlying issue with 'simplegeneric' not being pulled in as a dependency. Change-Id: Ia224eafb2c2220c970367580a8818746f9479f9d Depends-On: I28861178fac89e6f3fabd34b048f53b6506eda5e
* Rename gendocs tox environmentAndreas Jaeger2015-05-211-1/+1
| | | | | | | All other openstack projects use docs environment, use the same name for ironic as well. Change-Id: I46fd50da89c3247bffefc9c971f8eda309bbe9bd
* Add simplegeneric to py34 requirementsVictor Sergeyev2015-05-201-0/+4
| | | | | | | | | | | simplegeneric suppoosed to be installed by WSME, but for a some reasons it was missed in py3 env. We can't add this library to requirements.txt, because it missed in global requirements, so I've added simplegeneric to the `deps` section in py34 environment. This if a fast-and-dirty way to unblock python34 gates for ironic. Change-Id: Ib0cddf7541defbdfe1b17448b52becf8bd4ef3de
* Run tests in py34 environmentVictor Sergeyev2015-05-061-1/+13
| | | | | | | | | | | | | | | | | A lot of fixes to be compatible with python 3: - fix encoding/decoding errors - fix issues with comparison - use `reload`, `reraise`, ext. modules from six - use items() instead of iteritems() - add a new file with py3 specific test requirements - drop passing the arbitrary arguments to object.__new__ method. See bug [1] for more details. - add a workaround to bug in `mock` library - add py33 and py34 test environment to tox.ini [1] http://bugs.python.org/issue1683368 Change-Id: I90936cb6b6eaaf4b5e1ce67732caec3c8bdc1cc2
* Add a venv that can generate/write/update the states diagramJoshua Harlow2015-04-271-0/+5
| | | | | | | | | Instead of requiring manual understanding of how to generate the states diagram, add an explicit virtualenv that can be used to create and generate that docs diagram (and replace the existing file with it). Change-Id: I1738da9bf08bfda9b9be01489e8456569a31709e
* Set hash seed to 0 in gendocs environmentJay Faulkner2015-04-071-0/+1
| | | | | | | | | This was done in the venv environment to fix docs builds in the gate, but they still fail randonly locally when using the tox environment to build them. This change ensures the gendocs environment works for generating documentation locally. Change-Id: I41e4af9edaaa76b837a6c92a296b5738c85b632b
* Remove setting language to en_US for 'venv'John L. Villalovos2015-04-011-1/+0
| | | | | | | | | | | Remove setting LANGUAGE=en_US for 'venv' virtualenv. Since the 'venv' environment is not used for unittests and users may want to see messages in their native language in the 'venv' virtualenv. Also makes it consistent with python-ironicclient Change-Id: I1902d162cc7a5a1c8ee2e6a7412096d645277cc0
* Force LANGUAGE=en_US in test runsJohn L. Villalovos2015-03-131-0/+3
| | | | | | | | | | | | | Basically back-porting what was done for Nova in this patch: https://review.openstack.org/#/c/160892/ If your native locale is not en_US and you run tests, some could fail due to the message translation that happens since the assertion messages are in en_US (not translated, just hard-coded in the tests). Note that setting LANG=en_US had no effect. Change-Id: I16fab554612a718871625f688dd5501a69fb3417
* Fix PEP8 E124 & E125 errorsJohn L. Villalovos2015-02-201-1/+1
| | | | | | | | | | Fix PEP8 E124 & E125 errors E124: closing bracket does not match visual indentation E125: continuation line with same indent as next logical line Remove E124 & E125 from the ignore list for flake8 Change-Id: Ia9aee2fb7e0bb6771aad11d3523119944eeb4170
* Fix PEP8 E121 & E122 errorsJohn L. Villalovos2015-02-191-1/+1
| | | | | | | | | | Fix PEP8 E121 & E122 errors E121: continuation line under-indented for hanging indent E122: continuation line missing indentation or outdented Remove E121 & E122 from the ignore list for flake8 Change-Id: If63dd80ee85fc97596492e0b2cb6db9e10458c54
* For flake8 check, make the 'E12' ignore be more granularJohn L. Villalovos2015-02-181-1/+1
| | | | | | | | | | | ignore = E12 means ignore E12* errors. Make it more granular by converting to E121,E122,...,E129 This will make it easier in the future to remove a single ignore and update the code to resolve the issues. Change-Id: Iddff6a826bc7c9ff07643b7408c51f1bd129530c
* dev-quickstart.rst update to add required packagesNaohiro Tamura2014-11-171-1/+1
| | | | | | | | | * added unspecifed required package "python-tox" for Ubuntu/Debian, and removed "py26" from "tox.ini" so that "tox" command doesn't invoke the tests in Python 2.6 environment. Change-Id: I57df22a54fc08f2bb53a17d13b70706952815871 Closes-Bug: #1392304
* Add gendocs tox job for generating the documentationLucas Alvares Gomes2014-11-141-0/+6
| | | | | | | | | | | | | | | We already use tox to generate the sample configuration, run the tests, etc.. This patch is adding a new 'gendocs' tox job for generating the documentation. I always have a hard time remembering the syntax to generate the docs, by adding it to tox I hope it may facilitate it a bit. You can now (re)generate the docs with this tox job: tox -egendocs The quick start guide was also updated with the new command. Change-Id: I6a755c31382310420d706e51a3e014941fd49872
* Enable hacking rule E265jiangfei2014-11-131-2/+1
| | | | | | | | E265 is block comment should start with '# ' Closes-Bug: #1391787 Change-Id: I8f0e142bd14fd201da3b8c39501f9d858a5b051b
* Put a cap on our cyclomatic complexityMichael Davies2014-10-161-0/+1
| | | | | | | | | | | Flake8 has support for McCabe cyclomatic complexity. Ironic's most complex code is at 16 right now, so cap this at 17 to make sure we don't start writing more complex code than what we already have today. Nova is doing similar: https://review.openstack.org/#/c/129125 Change-Id: I99fa26f763ab456d3428951d6a729098a73cf9ef
* Fix E131 PEP8 errorsDavid Shrewsbury2014-10-141-1/+1
| | | | | | | | | | | | | Fixes files with the following error: E131 continuation line unaligned for hanging indent and enables the check in tox.ini. Also enables the E113 check (unexpected indentation) since it seems that was fixed coincidentally with other previous changes. Change-Id: I9270e5df257e12dc903689d8eb6fb03be01c034b
* Enable E111 PEP8 checkDavid Shrewsbury2014-10-131-1/+1
| | | | | | | | | | Fixes files with the PEP8 error: E111 indentation is not a multiple of four and enables the check in tox.ini. Change-Id: I9e4e8d6b59d018367febd9362cbc9bc3e79ebd53
* Fix F812 PEP8 errorDavid Shrewsbury2014-10-131-1/+1
| | | | | | | | | | One file was redefining a variable, thus exposing this PEP8 error: F812 list comprehension redefines 'n' from line 1868 This fixes it and enables the check in tox.ini. Change-Id: Ifa9a2365160db1b8ec80b274f3458cea6bd1f653
* Enable H305 PEP8 checkDavid Shrewsbury2014-10-131-1/+1
| | | | | | | | | | | | Fixes files with the PEP8 error: H305 imports not grouped correctly and enables the check in tox.ini. Import order is: stdlib, 3rd-party, project imports Change-Id: I81fc67bc9f79c514b6f4941a13e44c95badd34e2
* Enable H307 PEP8 checkDavid Shrewsbury2014-10-131-1/+1
| | | | | | | | | | | | | | | | | Fixes files with the PEP8 error: H307 like imports should be grouped together and enables the check in tox.ini. For the modified files, made sure the import order matches the template as described in: http://docs.openstack.org/developer/hacking/#import-order-template This order is currently: stdlib, 3rd-party, and project imports. Change-Id: I4538356c207535b778da1273aadcf3b4a7b20383
* Enable H405 PEP8 checkDavid Shrewsbury2014-10-101-1/+1
| | | | | | | | | | Fixes files with the PEP8 error: H405 multi line docstring summary not separated with an empty line and enables the PEP8 check in tox.ini. Change-Id: I632c89e2a1783be8305a8a8cea7ae9d3bb55b62c
* Enable H702 PEP8 checkDavid Shrewsbury2014-10-101-1/+1
| | | | | | | | | | Fixes files with the PEP8 error: H702 Argument to _, _LI, _LW, _LC, or _LE must be just a string and enables the PEP8 check in tox.ini. Change-Id: I6ca187535981d9809ca221e90de38988601f96e0
* Enable H904 PEP8 checkDavid Shrewsbury2014-10-101-1/+1
| | | | | | | | | | Fixes all files with the PEP8 error: H904 Wrap long lines in parentheses instead of a backslash and enables the PEP8 check in tox.ini. Change-Id: Ie3314487a45d34f59304a5b24eef9488ca3ce35e
* Fix pep8 testYuriy Zveryanskyy2014-10-091-3/+2
| | | | | | | | | For hacking 0.9 "ignore" and "select" options are mutually exclusive, therefore pep8 test always passed. This patch fix this bug and also fix long line in keystone module. Closes-Bug: #1379470 Change-Id: Ie8681caa9891bc4f4e257a8e56dc4a30c6f26723
* Stop running check_uptodate in the pep8 testenvDevananda van der Veen2014-09-291-1/+8
| | | | | | | | | | | | | | | As per this discussion on the mailing list: http://lists.openstack.org/pipermail/openstack-dev/2014-September/047160.html We are going to stop enforcing the correctness of the sample config file, and move to a separate non-voting check test that notifies us when it is no longer accurate, thus prompting a human to correct it. This addresses the issue where config options in dependent libraries (eg. keystone) repeatedly break our gate, without removing the sample config file that deployers benefit from. Change-Id: Ief88a693e4967b32f5f2f71b9a683599527a5129
* Don't write python bytecode while testingLucas Alvares Gomes2014-09-121-0/+1
| | | | | | | | | | | | | | This patch was based on the Nova patch: https://review.openstack.org/#/c/121044 This should reduce the number of times you need to completely delete your tox dir because you have stale pyc files around. In Ironic we have hit this problem a number of times, migrating to oslo.message was a big one that caused a lot of confusion. Closes-Bug: #1368661 Change-Id: I7dda3ad879beff1e494a36144c941a847177c2ef
* Remove bypassing of H302 for gettextutils markersRuby Loo2014-09-111-3/+1
| | | | | | | | | | | | When we used the i18n markers (_, _LE, _LW, etc) from ironic.openstack.common.gettextutils, we bypassed H302 hacking rule for them (via tox.ini file). Now that we've converted to using the markers from oslo.i18n and are no longer using the markers from gettextutils, we can remove the bypass stuff. Change-Id: I26147b69884cd9c075e1cfe38a92e38e861083e7 Closes-Bug: #1368425
* Deprecate Ironic compute driver and sched managerMichael Davies2014-09-091-2/+0
| | | | | | | | | | | | | | | | | | | Updates the Ironic compute driver and scheduler manager so that they subclass the now in-Nova-tree driver classes. This should de-duplicate code maintenance across Nova and Ironic and also provide end users an easier upgrade path (with Deprecation log messages). This patch also removes the old Ironic compute driver tests and classes since those now live in Nova. This patch also removes a line from tox.ini which was copying the second set of unit test outputs; those no longer exist, since we are no longer running unit tests on nova code in this tree. Co-Authored-By: Dan Prince <dprince@redhat.com> Co-Authored-By: Devananda van der Veen <devananda.vdv@gmail.com> Change-Id: Ic194f779eca470e4a4dd8a3fbd31ca5a6f6b4f7e
* Translator functions cleanup part 1Vladyslav Drok2014-09-051-1/+1
| | | | | | | | | | | | | | | | | This part fixes ironic/common folder and tox.ini file. Some modules use _ function for log translation, even when the translated string is passed to e.g. LOG.warn function. This patch fixes it, using translator functions appropriate for corresponding log levels. Translator functions, imported from ironic.openstack.common.gettextutils are now imported from ironic.common.i18n. Translator functions are imported the same way across all modules. All places that are changed conform to http://docs.openstack.org/developer/oslo.i18n/guidelines.html Partial-bug: #1364813 Change-Id: I195d0e256c5412d6d75d2e6c35b19b44f2a0b09f
* Remove gettextutils _ injectionVladyslav Drok2014-08-291-1/+0
| | | | | | | | | | Now that ironic supports oslo.i18n, using the install function to inject _ into the builtin has been deprecated. New i18n common module used instead. In one module _ was imported from gettextutils, now also changed to i18n import. Closes-bug: #1346406 Change-Id: I672a975d479991982c24031e834a26e2c2811890
* Set PYTHONHASHSEED for venv tox environmentAdam Gandelman2014-08-251-0/+1
| | | | | | | | | | | | | We're seeing frequent failures of the docs Jenkins job that appear to be caused by the tox 1.7.2 upgrade and the migration to using PYTHONHASHSEED=random. This overrides the environment in the venv testenv to set PYTHONHASHSEED=0 and allows docs to build successfully. Note that we want to run our tests with a random seed if possible, so this avoids disabling it for the base testenv and only uses non-random for the testenv used by Jenkins for doc builds. Change-Id: I665703c9a002500bc90b90cd268bd3ccff4e3534 Closes-bug: 1361295
* oslo.i18n migrationGhe Rivero2014-07-161-1/+1
| | | | | | | | | | Switch ironic to use oslo.i18n. A new i18n module has been added under ironic with translation globals and imports the necessary functions from oslo.i18n. gettextutils module is still needed in the nova ironic driver. Change-Id: I682228e158132c628166e4d1e334c4003249d112
* Add gettextutils._L* to import_exceptionsEllen Hui2014-07-031-1/+3
| | | | | | | | | | | | | | | | | | | | | | | Using the new logging translation markers (_LI(), _LW(), _LE(), _LC())[1] is problematic because they are not modules. Since the Openstack guidelines only allow modules to be imported[2], the entire gettextutils module must imported in order to use the translation markers. This patch adds all four markers to import_exceptions in tox.ini, so they can be imported individually without failing the pep8 tests. This is already done with the _() marker. With this change, it will be allowable to import marker functions like so: from ironic.openstack.common.gettextutils import _LI from ironic.openstack.common.gettextutils import _LW from ironic.openstack.common.gettextutils import _LE from ironic.openstack.common.gettextutils import _LC [1]http://docs.openstack.org/developer/oslo.i18n/guidelines.html [2]http://docs.openstack.org/developer/hacking/#imports Change-Id: I78192dd7525624174deb8d377996ed3d61b36a8a
* Add genconfig tox job for sample config file generationMathieu Gagné2014-06-231-0/+4
| | | | | | | | | | | | | | | | | | | | | | | If someone tries to run generate_sample.sh outside a venv or without installing project dependencies, you could encounter error messages related to missing or outdated dependencies. This change wraps generate_sample.sh execution in tox. Wrapping it in a tox job makes sure all dependencies found in requirements.txt and test-requirements.txt are properly installed prior to its execution. This change does not propose the removal of the sample config file already in place in the repository and it does not propose adding it to the list of jobs automatically ran by tox. This change is merely the introduction of a more convenient way to execute generate_sample.sh in a proper venv. You can now (re)generate the sample config file with this tox job: tox -egenconfig Change-Id: I1058a306a462ba8349a4433c78070fabd6d03e39
* Test for membership should be 'not in'Christian Berendt2014-06-161-0/+1
| | | | | | Enabled check for PEP8 issue E713. Change-Id: Id41f5f19796a7af8cf4cb52dd7afc2e6ec1ccbc4
* Merge "Update tox.ini to also run nova tests"Jenkins2014-04-071-4/+5
|\
| * Update tox.ini to also run nova testsAdam Gandelman2014-04-041-4/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This updates testr.conf to allow passing of the tests directory as an environment variable (defaulting to ironic/tests/). Also updates tox.ini to run testr once for ironic/tests and once for ironic/nova/tests/, then combine subunit output. test-requirements.txt is updated to pull in Nova from a tarball, as well as mox and python-ironicclient. Updates the existing Nova driver unit tests to account for recent refactoring and changes in the Nova virt API. Change-Id: Ibefa2e0d3f97512f4da9ace780703fe47467232e Closes-bug: #1299312
* | Use xargs -0 instead of --nullAndreas Jaeger2014-04-031-1/+1
|/ | | | | | This gives compatibility with OS X in the test. Change-Id: I483b4279d0d6a5a6fe4f81b9fb07a838e17e1b0f
* Check that all po/pot files are validAndreas Jaeger2014-03-311-0/+4
| | | | | | | | | Perform minimal checks on po and pot files so that no broken files can get imported. Change-Id: I328fc11c688c16737ae88984e4778483ce5db5ab Co-Authored-By: Clark Boylan <clark.boylan@gmail.com> Related-Bug: #1298645
View Lorry Controller Status