From c03a5b44ef76018a384e7f2c3f4f247e1dc49e0a Mon Sep 17 00:00:00 2001 From: Julia Kreger Date: Thu, 27 Oct 2022 10:08:19 -0700 Subject: Remove autocommit, again. Patch Ic8b1d964f7be5784e01c89bfb6c0277ea82eec2d was developed without the autocommit change in place, which should allow Ironic to operate properly with sqlite, in a single process standalone mode. As such, we shouldn't need to keep autocommit turned on, but we may need to put it back if we identify yet another issue, which is entirely possible with major database refactors. Change-Id: Icde231e9db3b7a9f59205505cd51a4064e41d746 --- ironic/db/sqlalchemy/__init__.py | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/ironic/db/sqlalchemy/__init__.py b/ironic/db/sqlalchemy/__init__.py index c656ed227..f92a0b600 100644 --- a/ironic/db/sqlalchemy/__init__.py +++ b/ironic/db/sqlalchemy/__init__.py @@ -17,10 +17,8 @@ from sqlalchemy import event CONF = cfg.CONF -# FIXME(stephenfin): we need to remove reliance on autocommit semantics ASAP -# since it's not compatible with SQLAlchemy 2.0 # NOTE(dtantsur): we want sqlite as close to a real database as possible. -enginefacade.configure(sqlite_fk=True, __autocommit=True) +enginefacade.configure(sqlite_fk=True) # NOTE(TheJulia): Setup a listener to trigger the sqlite write-ahead -- cgit v1.2.1