diff options
author | Zuul <zuul@review.openstack.org> | 2018-05-02 16:39:06 +0000 |
---|---|---|
committer | Gerrit Code Review <review@openstack.org> | 2018-05-02 16:39:07 +0000 |
commit | 56d108858a2284516e1cba66a86883ea969755d4 (patch) | |
tree | 97bb7ebc91a283e2647b5ae6549943b5143882a3 | |
parent | 7bd6454e4721d1ff4935ad36e30e5420ad10e70e (diff) | |
parent | e1f92efd412c2368806abb2f29c57175235b0f07 (diff) | |
download | keystone-56d108858a2284516e1cba66a86883ea969755d4.tar.gz |
Merge "Fix assert test error under py3.6" into stable/queens
-rw-r--r-- | keystone/tests/unit/test_v3_federation.py | 9 |
1 files changed, 7 insertions, 2 deletions
diff --git a/keystone/tests/unit/test_v3_federation.py b/keystone/tests/unit/test_v3_federation.py index 8a73da4ff..41a2a8e56 100644 --- a/keystone/tests/unit/test_v3_federation.py +++ b/keystone/tests/unit/test_v3_federation.py @@ -13,6 +13,7 @@ import copy import os import random +import re import subprocess from testtools import matchers import uuid @@ -4042,11 +4043,15 @@ class SAMLGenerationTests(test_v3.RestfulTestCase): self.assertRaises(exception.SAMLSigningError, keystone_idp._sign_assertion, self.signed_assertion) + # The function __str__ in subprocess.CalledProcessError is different + # between py3.6 and lower python version. expected_log = ( "Error when signing assertion, reason: Command '%s' returned " - "non-zero exit status %s %s\n" % + "non-zero exit status %s\.? %s\n" % (CONF.saml.xmlsec1_binary, sample_returncode, sample_output)) - self.assertEqual(expected_log, logger_fixture.output) + + self.assertRegex(logger_fixture.output, + re.compile(r'%s' % expected_log)) @mock.patch('oslo_utils.fileutils.write_to_tempfile') def test_sign_assertion_fileutils_exc(self, write_to_tempfile_mock): |