From 42e2f985b246aa11de914bf5a8f0dc7f6836f501 Mon Sep 17 00:00:00 2001 From: Pete Zaitcev Date: Tue, 21 Mar 2023 22:56:58 -0500 Subject: [PooledLDAPHandler] Clean up the fix for result3() An empty exception clause is unnecessary when you're using a "finally" clause. Previous-Change-Id: I59ebf0fa77391d49b2349e918fc55f96318c42a6 Change-Id: I903db2fd2ac810ec96dbd25fc6529752c08f9a79 --- keystone/identity/backends/ldap/common.py | 4 ---- 1 file changed, 4 deletions(-) diff --git a/keystone/identity/backends/ldap/common.py b/keystone/identity/backends/ldap/common.py index d9c07fd87..0c003852e 100644 --- a/keystone/identity/backends/ldap/common.py +++ b/keystone/identity/backends/ldap/common.py @@ -867,10 +867,6 @@ class PooledLDAPHandler(LDAPHandler): # ultimately renders the pool unusable, causing a DoS. try: results = message.connection.result3(message.id, all, timeout) - except Exception: - # We don't want to ignore thrown - # exceptions, raise them - raise finally: # Now that we have the results from the LDAP server for # the message, we don't need the the context manager used -- cgit v1.2.1