diff options
| author | Miro Tomaska <mtomaska@redhat.com> | 2023-02-17 18:28:48 -0600 |
|---|---|---|
| committer | Slawek Kaplonski <skaplons@redhat.com> | 2023-03-03 15:35:51 +0000 |
| commit | 9dd8ab4b6a61600432189f508d4996367a231aed (patch) | |
| tree | f1a3df4f9d7113a38166f367d1b23851f32cb0fa | |
| parent | e52272c699800723b25f365efc866057efef7916 (diff) | |
| download | neutron-9dd8ab4b6a61600432189f508d4996367a231aed.tar.gz | |
Make retrieval of port mac column safe
This should not happen in the real world but its safer to check
if a port MAC column is not empty before trying to access it.
Trivial-Fix
Change-Id: Ie3c5151a8f7c6a240a5f3240d4e7fb58ea43e9c1
(cherry picked from commit 51005388b8a7c1445a1e1bfdaeed3159acaccef2)
| -rw-r--r-- | neutron/agent/ovn/metadata/agent.py | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/neutron/agent/ovn/metadata/agent.py b/neutron/agent/ovn/metadata/agent.py index 4169e53171..e562cad8db 100644 --- a/neutron/agent/ovn/metadata/agent.py +++ b/neutron/agent/ovn/metadata/agent.py @@ -416,6 +416,10 @@ class MetadataAgent(object): def _get_port_ips(self, port): # Retrieve IPs from the port mac column which is in form # ["<port_mac> <ip1> <ip2> ... <ipN>"] + if not port.mac: + LOG.warning("Port %s MAC column is empty, cannot retrieve IP " + "addresses", port.uuid) + return [] mac_field_attrs = port.mac[0].split() ips = mac_field_attrs[1:] if not ips: |