From ebc0219a50979ba11ef7a8015270fc215191f7af Mon Sep 17 00:00:00 2001 From: Stephen Finucane Date: Wed, 31 Aug 2016 10:52:41 +0100 Subject: hacking: Always use 'assertIs(Not)None' This is per the OpenStack style guidelines. Change-Id: Ia706045fe3524b6b5e1db0140672776d481a0c01 --- HACKING.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'HACKING.rst') diff --git a/HACKING.rst b/HACKING.rst index 4ef3f28752..ad0eb0338b 100644 --- a/HACKING.rst +++ b/HACKING.rst @@ -26,8 +26,8 @@ Nova Specific Commandments assertIsInstance(A, B). - [N317] Change assertEqual(type(A), B) by optimal assert like assertIsInstance(A, B) -- [N318] Change assertEqual(A, None) or assertEqual(None, A) by optimal assert like - assertIsNone(A) +- [N318] Change assertEqual(A, None) or assertIs(A, None) to optimal assert + like assertIsNone(A) - [N319] Validate that debug level logs are not translated. - [N320] Setting CONF.* attributes directly in tests is forbidden. Use self.flags(option=value) instead. -- cgit v1.2.1