From 5913bd889f9d3dfc8d154415e666c821054c229d Mon Sep 17 00:00:00 2001 From: Lee Yarwood Date: Fri, 1 May 2020 14:20:04 +0100 Subject: compute: Validate a BDMs disk_bus when provided Previously disk_bus values were never validated and could easily end up being ignored by the underlying virt driver and hypervisor. For example, a common mistake made by users is to request a virtio-scsi disk_bus when using the libvirt virt driver. This however isn't a valid bus and is ignored, defaulting back to the virtio (virtio-blk) bus. This change adds a simple validation in the compute API using the potential disk_bus values provided by the DiskBus field class as used when validating the hw_*_bus image properties. Closes-Bug: #1876301 Change-Id: I77b28b9cc8f99b159f628f4655d85ff305a71db8 --- api-ref/source/parameters.yaml | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) (limited to 'api-ref') diff --git a/api-ref/source/parameters.yaml b/api-ref/source/parameters.yaml index 9ed259923e..cc36fcbe8a 100644 --- a/api-ref/source/parameters.yaml +++ b/api-ref/source/parameters.yaml @@ -2515,9 +2515,10 @@ disk_available_least_total: disk_bus: description: | Disk bus type, some hypervisors (currently only libvirt) support - specify this parameter. Some example disk_bus values can be: `ide`, - `usb`, `virtio`, `scsi`. This is not an exhaustive list as it depends - on the virtualization driver, and may change as more support is added. + specify this parameter. Some example disk_bus values can be: ``fdc``, + ``ide``, ``sata``, ``scsi``, ``usb``, ``virtio``, ``xen``, ``lxc`` + and ``uml``. Support for each bus type depends on the virtualization driver + and underlying hypervisor. in: body required: false type: string -- cgit v1.2.1