From 05836c9bd9e3925c84fb97402bd70718eeb48bff Mon Sep 17 00:00:00 2001 From: Davide Guerri Date: Mon, 20 Apr 2015 15:07:33 +0100 Subject: Do not include router:external when False. Older neutron versions (e.g. current HPCloud) will reject explicitly router:external set to false. Moreover router:external = False is the default. --- neutron_network | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/neutron_network b/neutron_network index 9c8dc1c..a9640d2 100644 --- a/neutron_network +++ b/neutron_network @@ -196,11 +196,15 @@ def _create_network(module, neutron): 'provider:network_type': module.params.get('provider_network_type'), 'provider:physical_network': module.params.get('provider_physical_network'), 'provider:segmentation_id': module.params.get('provider_segmentation_id'), - 'router:external': module.params.get('router_external'), 'shared': module.params.get('shared'), 'admin_state_up': module.params.get('admin_state_up'), } + # Older neutron versions wil reject explicitly router:external set + # to false + if module.params.get('router_external'): + network['router:external'] = True + if module.params['provider_network_type'] == 'local': network.pop('provider:physical_network', None) network.pop('provider:segmentation_id', None) -- cgit v1.2.1