summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
| * | mypy: Add boilerplate configurationStephen Finucane2020-02-125-8/+27
| | | | | | | | | | | | | | | | | | Add the requirement, tox job, and basic configuration. Change-Id: I3a865255ee731a27a00e7653557099fb99096486
* | | Merge "Switch to hacking 2.x"Zuul2020-02-194-4/+4
|\ \ \ | |/ /
| * | Switch to hacking 2.xStephen Finucane2020-02-124-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This bumps the version of flake8 and pycodestyle to something much newer, which resolves a long-standing warning about nested sets and allows us to use new fangled features like f-strings if we so choose. Note that this requires some minor modifications to keep the 'pep8' task passing. Change-Id: I3af8eb490345a6152372730ca3e0a6702bf482ea Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
* | | Merge "Remove six"Zuul2020-02-1913-90/+67
|\ \ \ | |/ /
| * | Remove sixStephen Finucane2020-02-1213-90/+67
| | | | | | | | | | | | | | | | | | | | | | | | | | | We don't need this in a Python 3-only world. We can't remove mock yet since there's an issue with the stdlib variant in python3.6, but that is called out. Change-Id: I9657b1fd4409be90d645175a6e177d7e1d2ebac2 Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
* | | Merge "Update the minversion parameter."8.0.1Zuul2020-02-130-0/+0
|\ \ \
| * | | Update the minversion parameter.Daniel Bengtsson2020-02-121-1/+1
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Update the minversion parameter to use the python -m pip to install python packages: https://tox.readthedocs.io/en/latest/changelog.html#id185 It's recommend to use this. Change-Id: Ib7cd076c167c5e47d7241995fb308cd3b8c9db42
* | | Merge "remove outdated header"Zuul2020-02-131-1/+0
|\ \ \
| * | | remove outdated headerHervé Beraud2020-02-101-1/+0
| |/ / | | | | | | | | | Change-Id: I09bfa2e97bb20b3be0b801c7e76ce93b8db6d0cb
* | | trivial: Cleanup tox.iniHervé Beraud2020-02-111-3/+8
|/ / | | | | | | | | | | | | | | | | | | | | Update the minversion parameter to use the python -m pip to install python packages: https://tox.readthedocs.io/en/latest/changelog.html#id185 Also Inherit the jobs requirements to simplify maintainance. Change-Id: I730f15a4872334f040d5bd03da37e7c4f9e8148b
* | Merge "Remove universal wheel configuration"Zuul2020-02-101-2/+0
|\ \
| * | Remove universal wheel configurationBen Nemec2020-02-061-2/+0
| | | | | | | | | | | | | | | | | | | | | Now that we've dropped py2 support we shouldn't be setting this anymore. Change-Id: I9a5e096e528ccf47f50b0ea67463cbe0cd359cd9
* | | reword releasenote for py27 support droppingHervé Beraud2020-02-061-1/+1
|/ / | | | | | | Change-Id: I39fbf54eb74843cd268c8cbac0a372927fff00e7
* | [ussuri][goal] Drop python 2.7 support and testing8.0.0Stephen Finucane2020-02-039-26/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | OpenStack is dropping the py2.7 support in Ussuri cycle. Complete discussion & schedule can be found in - http://lists.openstack.org/pipermail/openstack-discuss/2019-October/010142.html - https://etherpad.openstack.org/p/drop-python2-support Ussuri Communtiy-wide goal: https://governance.openstack.org/tc/goals/selected/ussuri/drop-py27.html Change-Id: I13ce8e8264679a19c7b108381ccb969573ea9ac6 Signed-off-by: Stephen Finucane <sfinucan@redhat.com> Sem-Ver: api-break
* | Merge "tox: Trivial cleanup"Zuul2020-01-301-11/+3
|\ \
| * | tox: Trivial cleanupHervé Beraud2020-01-081-11/+3
| | | | | | | | | | | | | | | | | | Move 'basepython' to the top-level 'testenv'. Change-Id: I4957925d96c2eea0f9a2d791feb71b6d3f54a224
* | | Merge "Support hyphens in positional argument names"7.0.0Zuul2019-12-202-16/+15
|\ \ \
| * | | Support hyphens in positional argument namesDolph Mathews2017-03-302-16/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently, when you specify a positional argument with a hyphen in the name, oslo.config is not able to retrieve a value back for that argument, even if one is parsed by argparse, because there's a mismatch between where oslo.config expects to find the value (in the dest, with underscores, which positional arguments do not have), versus where argparse puts it in the namespace (using the name, with hyphens). Change-Id: Ibc44a880ffddfaeffca682ccf3b34525f3f0fe27
* | | | Merge "Assume positional arguments are required"Zuul2019-12-204-27/+34
|\ \ \ \ | |/ / /
| * | | Assume positional arguments are requiredDolph Mathews2017-03-304-27/+34
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The 'positional' keyword specifically applies to oslo.config's argparse support. Unlike oslo.config, argparse assumes that all positional arguments are required by default, and you have to explicitly tell it that a positional argument is optional if you'd like to opt into that behavior. This patch adopts that same behavior for oslo.config. When you define an option to be non-positional (oslo.config's default, designed for config files), then oslo.config makes that option optional: However, when you define an option to be positional, oslo.config assumes that the option is primarily going to be used on the CLI and thus sets it as required, by default. This change in behavior has the side effect of allowing argparse to enforce required arguments on the CLI *while* parsing arguments, instead of depending on oslo.config to detect the condition *after* argparse has been allowed to parse "invalid" arguments. argparse correctly raises a SystemExit in this case, and prints the actual command usage and a "hey, you forgot this required argument", instead of allowing oslo.config to dump a backtrace to the CLI with a context-less error message ("context-less" in that no useful CLI usage information is dumped along with the crash to help you correct the condition). Change-Id: Ifdc6918444fe72f7e1649483c237cce64b4c72d8 Partial-Bug: 1676989
* | | | Merge "Refactor unit tests for CLI usage"Zuul2019-12-201-8/+34
|\ \ \ \ | |/ / /
| * | | Refactor unit tests for CLI usageDolph Mathews2017-03-301-8/+34
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Prior to this change, CLI usage was hardcoded into the config opt fixture used for all tests. That CLI usage described two required positional arguments that were not actually part of the argument parser (FOO and BAR), but were instead just made up to have a valid-looking usage description. The trouble is that you can't then extend that argument parser with additional real arguments, and then test the configuration of those arguments by inspecting the *real* usage and --help output from argparse. For example, a unit test could not assert whether argparse was configured correctly by oslo.config, because there's simply no way to know when the usage was just statically set to the arbitrary values of "FOO BAR." This patch moves that specific unit test coverage (overriding usage with something arbitrary) into a dedicated unit test, while removing the arbitrary usage from all other unit tests. Instead, those unit tests now make assertions against the argparser's real configuration, hence options like --config-dir and --config-file now appear in those tests, because those options are included in every instance of cfg.ConfigOpts(). Change-Id: I54ba989768d074a5f24897299c85bd35fa1cbd1a Related-Bug: 1676989
* | | Merge "Remove ConfigFilter"Zuul2019-12-202-752/+0
|\ \ \ | |/ / |/| |
| * | Remove ConfigFilterBen Nemec2019-12-172-752/+0
| |/ | | | | | | | | | | | | Per the deprecation in change I04baae695a7ba0bb93c91ea642c4e33c04bf87bd this can be removed. Change-Id: I31156e2f47b0d68ea32726cde7f0c2b133022c9f
* | Ensure option groups don't change during loggingStephen Finucane2019-12-131-1/+1
|/ | | | | | | | | | | | | | | | | | | | | | | oslo.config allows us to configure groups and options dynamically. This can cause a race with our logging as we attempt to iterate through option groups that are changing under our feet. This wouldn't be a huge issue, since these are just logs are we can always log again, if needed, but we store groups in a dictionary and Python doesn't like us changing the size of a dict it's iterating through: RuntimeError: dictionary changed size during iteration Given that we're only reading through this option group and don't need to worry about a group _disappearing_, the solution is pretty simple: create a copy of our option group names ahead of time so we don't need to worry about new ones coming and messing things up. No tests are included since this is a race and the only way I see to reproduce this would involve lots of ugly threading. Change-Id: Id3b28465d645a24f0fcebff2dd68a9bd30e21594 Signed-off-by: Stephen Finucane <sfinucan@redhat.com> Closes-Bug: #1856312
* Merge "update source link in readme"Zuul2019-12-021-1/+1
|\
| * update source link in readmezhangboye2019-10-151-1/+1
| | | | | | | | Change-Id: I592a110921707656748c48a62c038131d003db6c
* | Merge "Switch to Ussuri jobs"Zuul2019-12-021-1/+1
|\ \
| * | Switch to Ussuri jobspengyuesheng2019-10-241-1/+1
| |/ | | | | | | Change-Id: Icd54952c987153b0473872733db2bf7253d7c1f1
* | Stop configuring install_command in tox.6.12.0Daniel Bengtsson2019-11-141-1/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently, we are overriding 'install_command' to use 'pip'. This is considered poor behavior and 'python -m pip' should be used instead: https://snarky.ca/why-you-should-use-python-m-pip/ It turns out that this is the the default value provided by tox: https://tox.readthedocs.io/en/latest/config.html#conf-install_command So we can remove the line and simply use the default value. Change-Id: Ibcdd3a9f7e7ea421e906cf1d96f95b516008b5d7
* | fix: fix float opt min and max value format errrorhuang.xiangdong2019-11-041-2/+2
| | | | | | | | | | | | | | | | "%d" will truncate float and generates wrong format message, use "format" to handle floats correctly. Closes-Bug: 1850879 Change-Id: If0dd3933695ac84f0e9cacefd28a9d7a60dd88d7
* | tox: Keeping going with docscaoyuan2019-10-243-5/+6
|/ | | | | | | | | | | | Sphinx 1.8 introduced [1] the '--keep-going' argument which, as its name suggests, keeps the build running when it encounters non-fatal errors. This is exceptionally useful in avoiding a continuous edit-build loop when undertaking large doc reworks where multiple errors may be introduced. [1] https://github.com/sphinx-doc/sphinx/commit/e3483e9b045 Change-Id: Ied9f46640cf2f338a5784e1c72998f93b5c860c5
* Merge "Update master for stable/train"Zuul2019-10-102-0/+7
|\
| * Update master for stable/trainOpenStack Release Bot2019-09-202-0/+7
| | | | | | | | | | | | | | | | | | | | | | | | Add file to the reno documentation build to show release notes for stable/train. Use pbr instruction to increment the minor version number automatically so that master versions are higher than the versions on stable/train. Change-Id: Id19c6dca83057a9ab63d0947ff508f97811c0499 Sem-Ver: feature
* | Update the constraints urlpengyuesheng2019-09-231-1/+1
|/ | | | | | For more detail, see http://lists.openstack.org/pipermail/openstack-discuss/2019-May/006478.html Change-Id: Ib1d98cf2feb7837c7c4c2922a48cbc9f0bf0d3ef
* Merge "Improve removing quotes logic"6.11.1Zuul2019-08-142-1/+6
|\
| * Improve removing quotes logicAndrii Ostapenko2019-08-122-1/+6
| | | | | | | | | | | | Cover case when sting consists of one quote only. Change-Id: I1fed30f6e365e18d3e3ec11d436a432b08c6c344
* | Merge "Clean up the unnecessary sphinx from test-requirements.txt"Zuul2019-08-123-6/+6
|\ \ | |/ |/|
| * Clean up the unnecessary sphinx from test-requirements.txtcaoyuan2019-07-073-6/+6
| | | | | | | | | | | | | | | | 1. Clean up the unnecessary sphinx from test-requirements.txt 2. when run `tox -e docs` in localhost, some files will be created, it not belong to the code, shoule be ignore by the git Change-Id: I2bae30fedfdc64fbbafbe0e96794597b564c2d54
* | Merge "Bump the openstackdocstheme extension to 1.20"Zuul2019-08-094-65/+2
|\ \
| * | Bump the openstackdocstheme extension to 1.20pengyuesheng2019-08-014-65/+2
| |/ | | | | | | | | | | | | | | | | | | | | | | Some options are now automatically configured by the version 1.20: - project - html_last_updated_fmt - latex_engine - latex_elements - version - release. Change-Id: Iac913e9dea8318ad8398ed7478cb66d845fe7f1e
* | Merge "Blacklist sphinx 2.1.0 (autodoc bug)"Zuul2019-08-081-1/+1
|\ \
| * | Blacklist sphinx 2.1.0 (autodoc bug)pengyuesheng2019-07-301-1/+1
| |/ | | | | | | | | | | See https://github.com/sphinx-doc/sphinx/issues/6440 for upstream details Change-Id: I4c4a2083d6578c625b948b1458412b832264f11e
* | Add Python 3 Train unit testsCorey Bryant2019-07-053-3/+3
|/ | | | | | | | | | | | This is a mechanically generated patch to ensure unit testing is in place for all of the Tested Runtimes for Train. See the Train python3-updates goal document for details: https://governance.openstack.org/tc/goals/train/python3-updates.html Change-Id: Ia547c6f2e27c12ef58eb955286b5f2ab5359c2e2 Story: #2005924 Task: #34234
* Merge "Add special handling for keystone_authtoken group"6.11.0Zuul2019-07-012-15/+33
|\
| * Add special handling for keystone_authtoken groupBen Nemec2019-05-222-15/+33
| | | | | | | | | | | | | | | | | | | | | | | | | | | | The keystone_authtoken options are created (not just registered) dynamically at runtime because of a need to not have a dependency on oslo.config in that library. As a result, there is no sane way to validate those options. This change adds a list of known problematic groups that we should ignore missing opts from. It also adds an info level log message that we are ignoring them so users know we can't confirm or deny the correctness of that piece of config. Change-Id: Ic2b36fe8be872d298a106c3f64905a5b935ced61
* | Merge "Switch to sphinxcontrib-apidoc"Zuul2019-06-2814-103/+17
|\ \
| * | Switch to sphinxcontrib-apidocBen Nemec2019-06-1814-103/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Rather than have the API docs hand-curated and scattered throughout the documentation, let's use the apidoc module like all of the other Oslo projects so our API docs are consistent and easy to find. The documents that were exclusively API docs are removed entirely, and the ones where API docs were included with other content have been changed to reference the generated API docs rather than include them inline. The one exception is the drivers because they are in private modules that don't show up in the API docs. Those are still explicitly documented. Change-Id: I00bdd963e0d4f270c0d4b50c05f420317a137fd5
* | | Merge "Deprecate ConfigFilter"Zuul2019-06-261-0/+7
|\ \ \
| * | | Deprecate ConfigFilterBen Nemec2019-06-171-0/+7
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There are no existing users of this class[0], and I believe there were some fundamental problems with the design that we never addressed. As I recall, this is because we adopted the policy that other projects should never use config opts they didn't define, so there's no real need for this feature now. I'm proposing that we deprecate this for only one cycle and remove it in U. While this doesn't fit our usual deprecation policy, the fact that the module has no known users makes me think it's not worth waiting the full two cycles we normally would. Change-Id: I04baae695a7ba0bb93c91ea642c4e33c04bf87bd 0: http://codesearch.openstack.org/?q=ConfigFilter&i=nope&files=&repos=
View Lorry Controller Status