summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
* | | Dropping lower constraints testingMoisés Guimarães de Medeiros2021-01-121-1/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We facing errors related to the new pip resolver, this topic was discussed on the ML and QA team proposed to to test lower-constraints [1]. I propose to drop this test because the complexity and recurring pain needed to maintain that now exceeds the benefits provided by this mechanismes. [1] http://lists.openstack.org/pipermail/openstack-discuss/2020-December/019390.html Change-Id: I83e50eade2cf9924424d763421e464e559c16a08
* | | Merge "Adding --check-defaults to validator"8.4.0Zuul2020-11-264-9/+302
|\ \ \
| * | | Adding --check-defaults to validatorDavid Vallee Delisle2020-11-244-9/+302
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When troubleshooting, it's often interesting to see the deltas between the default or sample configs and the running configuration. The oslo_config.validator is a great tool to integrate this feature across all projects. It can also be easily captured by data collection tools like sosreports with the current deployment packages. Change-Id: I172d82f19a81282093b0d5f7ae4c1817801cd887 Signed-off-by: David Vallee Delisle <dvd@redhat.com>
* | | | Merge "tox: Enable parallel docs builds"Zuul2020-11-051-2/+2
|\ \ \ \
| * | | | tox: Enable parallel docs buildsStephen Finucane2020-09-101-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | While we're here, specifying the doctree directory and configuring use of saved environments doesn't really make sense when we blast all previous doc build artefacts away on each build, so stop specifying those. Change-Id: I2b04a5c0ac121954aed91ae133e249a2e5813ee0 Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
* | | | | Use py3 as the default runtime for toxHervé Beraud2020-11-031-1/+1
| |/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Moving on py3 as the default runtime for tox to avoid to update this at each new cycle. Wallaby support officially the following runtimes [1]: - Python 3.6 - Python 3.8 During Victoria Python 3.7 was used as the default runtime [2] however this version isn't longer officially supported. [1] https://governance.openstack.org/tc/reference/runtimes/wallaby.html#python-runtimes-for-wallaby [2] https://governance.openstack.org/tc/reference/runtimes/victoria.html#python-runtimes-for-victoria Change-Id: Iab5475c25b3ff1ffd0b10766ab0a5dbd4b1c821a
* | | | Merge "Add a new type HostDomain."Zuul2020-10-223-4/+76
|\ \ \ \ | |_|_|/ |/| | |
| * | | Add a new type HostDomain.Hervé Beraud2020-10-223-4/+76
| | |/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | HostDomain is like HostAddress with the support of _ character - RFC1033 openstack services are failing to start when a hostname with underscore _ is provided. Example: ``` overcloud-novacompute_edge1-0.internalapi.localdomain overcloud-novacompute_edge1-0.internalapi ``` Nova use `HostAddressOpt` to define `live_migration_inbound_addr`, and if a hostname with underscore is present in the config file then the service fail to start. Example: ``` /etc/nova/nova.conf live_migration_inbound_addr = overcloud-novacompute_edge1-0.internalapi.localdomain ``` FQDN is a domain name that specifies its exact location in the tree hierarchy of the Domain Name System (DNS). Underscore are allowed by RFC1033 [1][2][3]. Indeed, while a hostname may not contain other characters, such as the underscore character (_), other DNS names may contain the underscore.[1][2]. Systems such as DomainKeys and service records use the underscore. These changes allow us to use underscore with the `HostDomain`. [1] https://www.ietf.org/rfc/rfc1912.txt [2] https://www.ietf.org/rfc/rfc1033.txt [3] http://domainkeys.sourceforge.net/underscore.html Co-authored-by: Daniel Bengtsson <dbengt@redhat.com> Change-Id: I0a0670207f96a987996d329e5efa9a5eb2ce000c Closes-Bug: #1892044
* | | Merge "Convert rst to plaintext for oslo.config output"Zuul2020-10-123-3/+51
|\ \ \
| * | | Convert rst to plaintext for oslo.config outputStephen Finucane2020-07-233-3/+51
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This lets us use powerful rST roles and directives in our help text without these being emitted to the configuration file, where they don't read quite as well. It also fixes our formatting somewhat, which is nice. Note that we're doing something funky where we disable line wrapping. We can't totally disable this due to how rst2txt works, so instead we set the line length to an arbitrarily long line length, which is taken from RFC5322 (Internet Message Format) for want of something better. I personally question whether anyone is configuring this, but that's a fight for another day. Also note that this might caught issues for people who are using invalid rST in their docstrings or use roles/directives in their config options that aren't part of the standard Sphinx set or oslo.config set. They will already be seeing the former issues if they are using the 'sphinxext' extension though, and the latter sounds like it would be fairly rare. Change-Id: I6c7208f0facfb4f334d7440cb6a9562901543dd3 Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
* | | | Merge "sphinxext: Add 'merge_domaindata'"Zuul2020-09-221-0/+9
|\ \ \ \ | | |_|/ | |/| |
| * | | sphinxext: Add 'merge_domaindata'Stephen Finucane2020-09-101-0/+9
| | |/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is necessary to enable parallel builds. As noted in the Sphinx docs [1], this method has the following function: Merge in data regarding docnames from a different domaindata inventory (coming from a subprocess in parallel builds). Given how simple the datatypes we're storing are, this is pretty easy to implement. [1] https://www.sphinx-doc.org/en/master/extdev/domainapi.html#sphinx.domains.Domain.merge_domaindata Change-Id: I46c7903b159f99c68896a4c3c4d20daef848f9c2 Signed-off-by: Stephen Finucane <sfinucan@redhat.com> Closes-Bug: #1895162
* | | Adding pre-commitHervé Beraud2020-09-225-9/+59
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Introduced changes: - pre-commit config and rules - Add pre-commit to pep8 gate, Flake8 is covered in the pre-commit hooks. - Applying fixes for pre-commit compliance in all code. Also commit hash will be used instead of version tags in pre-commit to prevend arbitrary code from running in developer's machines. pre-commit will be used to: - trailing whitespace; - Replaces or checks mixed line ending (mixed-line-ending); - Forbid files which have a UTF-8 byte-order marker (check-byte-order-marker); - Checks that non-binary executables have a proper shebang (check-executables-have-shebangs); - Check for files that contain merge conflict strings (check-merge-conflict); - Check for debugger imports and py37+ breakpoint() calls in python source (debug-statements); - Attempts to load all yaml files to verify syntax (check-yaml); - Run flake8 checks (flake8) (local) For further details about tests please refer to: https://github.com/pre-commit/pre-commit-hooks Change-Id: I65a40bbff17d92b959764846801d5e0ddd3b97ce Signed-off-by: Moisés Guimarães de Medeiros <moguimar@redhat.com>
* | | Add Python3 wallaby unit testsOpenStack Release Bot2020-09-111-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is an automatically generated patch to ensure unit testing is in place for all the of the tested runtimes for wallaby. See also the PTI in governance [1]. [1]: https://governance.openstack.org/tc/reference/project-testing-interface.html Change-Id: Id3cb71eb863a9c80e7abc3d11e0fabaf1d6e6b5f
* | | Update master for stable/victoriaOpenStack Release Bot2020-09-112-0/+7
|/ / | | | | | | | | | | | | | | | | | | | | | | Add file to the reno documentation build to show release notes for stable/victoria. Use pbr instruction to increment the minor version number automatically so that master versions are higher than the versions on stable/victoria. Change-Id: I59fa3a4e5ced137e61b8c08d63995d2a20693a92 Sem-Ver: feature
* | Bump bandit version8.3.2Moisés Guimarães de Medeiros2020-07-241-1/+1
| | | | | | | | | | | | | | | | This patch bumps bandit allowed version to >=1.6.0,<1.7.0 in order to avoid the errors detailed here https://github.com/PyCQA/bandit/pull/393 Change-Id: Iec3897279cf81f951225f463450c6a1efd028b0b Signed-off-by: Moisés Guimarães de Medeiros <moguimar@redhat.com>
* | Fix unit tests to work with stevedore > 2.0.18.3.1yatinkarel2020-07-231-2/+2
|/ | | | | | | | | | | | | | stevedore has switched to importlib_metadata[1] and this breaked unit test as the test relied on internal implementation of it. Instead we should switch to mock NamedExtensionManager that's what called by oslo_config. [1] https://review.opendev.org/#/c/739306/ Closes-Bug: #1888208 Change-Id: Ic4b990a387d875a351c9f8e7eaaef726734ff305
* drop use of pkg_resources8.3.0Doug Hellmann2020-07-054-6/+19
| | | | | | | | | Importing pkg_resources scans all of the installed modules for data that won't be used. Switch to using importlib.metdata, which more efficiently loads the metadata for a package. Change-Id: Idd2a0d0026fef9296172c9995b428ea43a746483 Signed-off-by: Doug Hellmann <doug@doughellmann.com>
* Merge "Align contributing doc with oslo's policy"Zuul2020-07-011-0/+5
|\
| * Align contributing doc with oslo's policyHervé Beraud2020-05-041-0/+5
| | | | | | | | | | | | | | | | Related to: - https://review.opendev.org/#/c/723044/ - https://governance.openstack.org/tc/goals/selected/ussuri/project-ptl-and-contrib-docs.html Change-Id: I52f370b5f1b2b956f7482139d9b4877cce502a98
* | Update lower-constraints versions8.2.0Sean McGinnis2020-06-091-2/+32
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This updates lower constraints to versions that will work with py38 so that when we move to running on focal nodes, which has py38 as its default py3 runtime, the lower-constraints job will continue to pass. It also cleans out some secondary requirements that are no longer needed due to our direct dependencies being updated. Linters are removed that are kept in the global requirements blacklist as those are not version tracked and are not relevant for our lower-constraints unit test runs. Change-Id: Ied58e8aeb700c15354f1c040b2623f498d636061 Signed-off-by: Sean McGinnis <sean.mcginnis@gmail.com>
* | Merge "generator: Handle 'cfg.Opt'-type options"Zuul2020-06-081-7/+4
|\ \
| * | generator: Handle 'cfg.Opt'-type optionsStephen Finucane2020-05-271-7/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | These are used when declaring an option with a custom type. There's no reason they shouldn't be handled and indeed they are albeit with an ugly warning. Resolve this by making this handling explicit. Change-Id: Ib7a6f26496cf19777b020c12998e953e9aae4601 Signed-off-by: Stephen Finucane <sfinucan@redhat.com> Closes-bug: #1880852
* | | Fix pygments stylemelissaml2020-06-042-8/+8
| | | | | | | | | | | | | | | | | | | | | | | | New theme of docs respects pygments_style. more info: http://lists.openstack.org/pipermail/openstack-discuss/2020-May/014971.html Change-Id: I88f448ac7fc7fb72187eb7bdad5bf19f327d8641
* | | Merge "Remove the unused coding style modules"8.1.0Zuul2020-05-261-4/+0
|\ \ \
| * | | Remove the unused coding style modulesjacky062020-05-161-5/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Python modules related to coding style checks (listed in blacklist.txt in openstack/requirements repo) are dropped from lower-constraints.txt as they are not actually used in tests (other than pep8). more info: https://github.com/openstack/requirements/blob/master/blacklist.txt Change-Id: If14b70ceb1642ba3b81385a49fb0686be7628a2d
* | | | Merge "Raise hacking minimum to 3.0.1"Zuul2020-05-254-12/+10
|\ \ \ \
| * | | | Raise hacking minimum to 3.0.1Sean McGinnis2020-05-194-12/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This raises hacking to a newer version, fixes a few issues the newer version uncovered, and removes the cap for flake8 to allow that version to be controlled by the hacking constraints. Change-Id: Ie550119322bca3c217e4a74eca789f156cfa7e2c Signed-off-by: Sean McGinnis <sean.mcginnis@gmail.com>
* | | | | Merge "Add py38 package metadata"Zuul2020-05-251-0/+1
|\ \ \ \ \
| * | | | | Add py38 package metadatazhangboye2020-05-221-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | Change-Id: Ife181dce8ed8520852501f394f3b1d3975c619fa
* | | | | | Merge "Remove six from lower-constraints.txt"Zuul2020-05-221-1/+0
|\ \ \ \ \ \ | |/ / / / / |/| | | | |
| * | | | | Remove six from lower-constraints.txtcaoyuan2020-05-041-1/+0
| | |_|_|/ | |/| | | | | | | | | | | | | | | | | | | | | | | it should be removed in https://review.opendev.org/#/c/687355/ but missing Change-Id: I45351e5913801982e93bd386ffb6d6a8845f03e6
* | | | | Merge "Resolve UnboundLocalError"Zuul2020-05-193-4/+28
|\ \ \ \ \ | |_|_|/ / |/| | | |
| * | | | Resolve UnboundLocalErrorStephen Finucane2020-05-013-4/+28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | As discussed in bug 1841038, configuring a StrOpt with a regex parameter and providing an invalid environment variable will result in an ugly stacktrace due to an undefined 'alt_loc' variable. Resolve this by creating said variable. Change-Id: Id0fb6efdc435a2bd88d5dfea2b4720df453fbfec Signed-off-by: Stephen Finucane <sfinucan@redhat.com> Closes-Bug: #1841038
* | | | | Merge "Cap flake8 to be < 3.8.0"Zuul2020-05-141-0/+1
|\ \ \ \ \ | | |_|/ / | |/| | / | |_|_|/ |/| | |
| * | | Cap flake8 to be < 3.8.0Sean McGinnis2020-05-121-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The 3.8.0 version introduces some checks that cause failures with the current code. To avoid that, this caps flake8 to a version that had been tested withouth errors so hacking does not pull in a newer version. We will likely want to raise hacking to 3.x and drop this cap, but to make it easy to backport to stable branches, taking this approach first. Change-Id: I2a539263e8cfc7d15243d78e20b70b8ed763b8fd Signed-off-by: Sean McGinnis <sean.mcginnis@gmail.com>
* | | | Merge "Add Python3 victoria unit tests"Zuul2020-05-041-1/+1
|\ \ \ \
| * | | | Add Python3 victoria unit testsOpenStack Release Bot2020-04-141-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is an automatically generated patch to ensure unit testing is in place for all the of the tested runtimes for victoria. See also the PTI in governance [1]. [1]: https://governance.openstack.org/tc/reference/project-testing-interface.html Change-Id: Ifa363aba4403932ce34a721b668ac2f878fe1ef5
* | | | | Merge "Update master for stable/ussuri"Zuul2020-05-042-0/+7
|\ \ \ \ \ | |/ / / / | | | | / | |_|_|/ |/| | |
| * | | Update master for stable/ussuriOpenStack Release Bot2020-04-142-0/+7
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add file to the reno documentation build to show release notes for stable/ussuri. Use pbr instruction to increment the minor version number automatically so that master versions are higher than the versions on stable/ussuri. Change-Id: I0562aab55c319fd46f5db73246e25233fc4700a7 Sem-Ver: feature
* | | docs: Mention other ways of escaping '$'Stephen Finucane2020-05-011-1/+1
| |/ |/| | | | | | | | | | | | | | | | | | | oslo config code treat treats the '$' as a special character and it needs to be delimited when using within a string. There are two ways of doing this, '$$' or '\$'. We document the former but not the latter. Fix this. Change-Id: I37cdf31ba1c2924779a46b1a2eeabb66c46a2212 Signed-off-by: Stephen Finucane <sfinucan@redhat.com> Closes-Bug: #1872839
* | Merge "Add release notes links to doc index"Zuul2020-04-211-0/+7
|\ \
| * | Add release notes links to doc indexHervé Beraud2020-04-161-0/+7
| |/ | | | | | | Change-Id: Ife6a9f6ff6116fda3bbb5b6a5987096f22b6f5a9
* | Merge "Use unittest.mock instead of third party mock"Zuul2020-04-177-9/+7
|\ \
| * | Use unittest.mock instead of third party mockSean McGinnis2020-03-317-9/+7
| |/ | | | | | | | | | | | | | | Now that we no longer support py27, we can use the standard library unittest.mock module instead of the third party mock lib. Change-Id: I2f8067eeb2aec62f098bfbb3770a67f1876ce7a2 Signed-off-by: Sean McGinnis <sean.mcginnis@gmail.com>
* | Mark sphinx extensions thread safeSean McGinnis2020-04-142-0/+8
| | | | | | | | | | | | | | | | | | | | This adds the return of some metadata to our sphinx extension setup to indicate they are thread safe. This is needed to allow consuming projects to do multithreaded docs builds. In some cases, this can save a noticeable amount of time in job execution. Change-Id: I53a580b336a49372e27b69d009da555c03f03e35 Signed-off-by: Sean McGinnis <sean.mcginnis@gmail.com>
* | Remove redundant class docstring infoSean McGinnis2020-04-131-16/+0
|/ | | | | | | | | This now fails with the newest Sphinx due to multiple entries between the added reference to the class's docstrings, and the docstrings themselves. This fixes the warnings by just removing the duplication. Change-Id: I284a49a5df9506f936ebf1846688339c94d9a6b8 Signed-off-by: Sean McGinnis <sean.mcginnis@gmail.com>
* Merge "Use stevedore to list the source drivers in documentation"8.0.2Zuul2020-03-093-0/+12
|\
| * Use stevedore to list the source drivers in documentationDoug Hellmann2019-12-173-0/+12
| | | | | | | | | | | | | | | | Add a section to the configuration guide to list all of the drivers using stevedore's sphinx integration. Change-Id: I6348f83efdd8a572821d2851ee4bd883f9e7e2b4 Signed-off-by: Doug Hellmann <doug@doughellmann.com>
* | Merge "mypy: Add boilerplate configuration"Zuul2020-03-075-8/+27
|\ \
View Lorry Controller Status