From 10fd6fd30a6ed7ab3b98c7ef318fe93f1f144243 Mon Sep 17 00:00:00 2001 From: yanheven Date: Sat, 23 Jul 2016 16:50:42 +0800 Subject: Fix parameters of assertEqual are misplaced Many assertEqual sentences don't follow assertEqual(expected, actual), These misplaces have 2 impacts: 1, giving confusing messages when some tests failed. 2, mislead other developers, new test modules may follow these wrong pattern. This patch fix all of them. Change-Id: I806c893fd46242b021ce90037609ee47e015e1f3 Closes-Bug: #1604213 --- oslo_context/tests/test_context.py | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) (limited to 'oslo_context') diff --git a/oslo_context/tests/test_context.py b/oslo_context/tests/test_context.py index 54046cb..2588fa0 100644 --- a/oslo_context/tests/test_context.py +++ b/oslo_context/tests/test_context.py @@ -227,27 +227,27 @@ class ContextTest(test_base.BaseTestCase): 'HTTP_X_USER_ID': new} ctx = context.RequestContext.from_environ(environ=environ) - self.assertEqual(ctx.user, new) + self.assertEqual(new, ctx.user) ctx = context.RequestContext.from_environ(environ=environ, user=override) - self.assertEqual(ctx.user, override) + self.assertEqual(override, ctx.user) environ = {'HTTP_X_TENANT': old, 'HTTP_X_PROJECT_ID': new} ctx = context.RequestContext.from_environ(environ=environ) - self.assertEqual(ctx.tenant, new) + self.assertEqual(new, ctx.tenant) ctx = context.RequestContext.from_environ(environ=environ, tenant=override) - self.assertEqual(ctx.tenant, override) + self.assertEqual(override, ctx.tenant) environ = {'HTTP_X_TENANT_NAME': old, 'HTTP_X_PROJECT_NAME': new} ctx = context.RequestContext.from_environ(environ=environ) - self.assertEqual(ctx.project_name, new) + self.assertEqual(new, ctx.project_name) def test_from_environ_strip_roles(self): environ = {'HTTP_X_ROLES': ' abc\t,\ndef\n,ghi\n\n'} -- cgit v1.2.1