summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJenkins <jenkins@review.openstack.org>2015-01-06 02:07:43 +0000
committerGerrit Code Review <review@openstack.org>2015-01-06 02:07:43 +0000
commit98b434db7d1b52aee32782065df155988918cc3f (patch)
tree7b7cd9385f4059581ed6e53fc40f93e74fe5d8ac
parentd0c13d2a13c612b758d8da3b6543828d5d8b07f7 (diff)
parent30433383c7042e1cab5df6edd7778ed0e0156b3b (diff)
downloadoslo-db-98b434db7d1b52aee32782065df155988918cc3f.tar.gz
Merge "Ensure PostgreSQL connection errors are wrapped"
-rw-r--r--oslo_db/sqlalchemy/exc_filters.py1
-rw-r--r--oslo_db/tests/sqlalchemy/test_exc_filters.py15
2 files changed, 16 insertions, 0 deletions
diff --git a/oslo_db/sqlalchemy/exc_filters.py b/oslo_db/sqlalchemy/exc_filters.py
index efdbb2f..aa5b55a 100644
--- a/oslo_db/sqlalchemy/exc_filters.py
+++ b/oslo_db/sqlalchemy/exc_filters.py
@@ -270,6 +270,7 @@ def _raise_operational_errors_directly_filter(operational_error,
@filters("mysql", sqla_exc.OperationalError, r".*\(.*(?:2002|2003|2006|2013)")
+@filters("postgresql", sqla_exc.OperationalError, r".*could not connect to server") # noqa
@filters("ibm_db_sa", sqla_exc.OperationalError, r".*(?:30081)")
def _is_db_connection_error(operational_error, match, engine_name,
is_disconnect):
diff --git a/oslo_db/tests/sqlalchemy/test_exc_filters.py b/oslo_db/tests/sqlalchemy/test_exc_filters.py
index 157a183..b2845a2 100644
--- a/oslo_db/tests/sqlalchemy/test_exc_filters.py
+++ b/oslo_db/tests/sqlalchemy/test_exc_filters.py
@@ -745,6 +745,21 @@ class TestDBDisconnected(TestsExceptionFilter):
is_disconnect=False
)
+ def test_postgresql_ping_listener_disconnected(self):
+ self._test_ping_listener_disconnected(
+ "postgresql",
+ self.OperationalError(
+ "could not connect to server: Connection refused"),
+ )
+
+ def test_postgresql_ping_listener_disconnected_regex_only(self):
+ self._test_ping_listener_disconnected(
+ "postgresql",
+ self.OperationalError(
+ "could not connect to server: Connection refused"),
+ is_disconnect=False
+ )
+
class TestDBConnectRetry(TestsExceptionFilter):