summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorZuul <zuul@review.opendev.org>2020-04-21 11:40:38 +0000
committerGerrit Code Review <review@openstack.org>2020-04-21 11:40:38 +0000
commitc3229908fedb5a9d9b41d31d035882b6915c3ffb (patch)
treee798b8411a03533bb660d94480cc609ec7f82583
parentb450f0f24442c09d059237a621d610690dacf5ee (diff)
parent85573e07823556882117c21f42a098de7d470f7b (diff)
downloadoslo-db-c3229908fedb5a9d9b41d31d035882b6915c3ffb.tar.gz
Merge "Modernize use of table.count() with func.count()"
-rw-r--r--oslo_db/tests/sqlalchemy/test_sqlalchemy.py14
1 files changed, 10 insertions, 4 deletions
diff --git a/oslo_db/tests/sqlalchemy/test_sqlalchemy.py b/oslo_db/tests/sqlalchemy/test_sqlalchemy.py
index b3e81e3..080f418 100644
--- a/oslo_db/tests/sqlalchemy/test_sqlalchemy.py
+++ b/oslo_db/tests/sqlalchemy/test_sqlalchemy.py
@@ -115,10 +115,16 @@ class SQLiteSavepointTest(test_base._DbTestCase):
).fetchall()
)
trans.rollback()
- self.assertEqual(
- 0,
- self.engine.scalar(self.test_table.count())
- )
+
+ with self.engine.connect() as conn:
+ self.assertEqual(
+ 0,
+ conn.scalar(
+ sqlalchemy.select(
+ [sqlalchemy.func.count(self.test_table.c.id)],
+ ).select_from(self.test_table)
+ )
+ )
def test_savepoint_middle(self):
with self.engine.begin() as conn: