summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorEugene Nikanorov <enikanorov@mirantis.com>2015-03-17 14:17:41 +0300
committerRoman Podoliaka <rpodolyaka@mirantis.com>2015-03-30 15:07:47 +0000
commit7918c9aca607f18e2f9c308d329e758bc334e04f (patch)
tree4f4918ddbc16d1de55c20671a6034cf376734f9c
parent3e6a30c396aa42ef0eccb5b3625af728d8d3f437 (diff)
downloadoslo-db-7918c9aca607f18e2f9c308d329e758bc334e04f.tar.gz
Avoid excessing logging of RetryRequest exception
Such exception indicates of error condition only if retries are exceeded. In other cases error-level logs pollute the log file and complicate log analysis. Change-Id: I318867043a68a6499851631593859a0fffac6038 Closes-Bug: #1433001 (cherry picked from commit 02aeda28cf8b69f39f934a3e80cb7cae04c5fc20)
-rw-r--r--oslo_db/api.py6
1 files changed, 5 insertions, 1 deletions
diff --git a/oslo_db/api.py b/oslo_db/api.py
index 616cac5..0ba07e8 100644
--- a/oslo_db/api.py
+++ b/oslo_db/api.py
@@ -139,7 +139,11 @@ class wrap_db_retry(object):
raise e
if remaining != -1:
remaining -= 1
- LOG.exception(_LE('DB error.'))
+ # RetryRequest is application-initated exception
+ # and not an error condition in case retries are
+ # not exceeded
+ if not isinstance(e, exception.RetryRequest):
+ LOG.exception(_LE('DB error.'))
# NOTE(vsergeyev): We are using patched time module, so
# this effectively yields the execution
# context to another green thread.