diff options
| author | ChangBo Guo(gcb) <eric.guo@easystack.cn> | 2017-11-30 13:27:33 +0800 |
|---|---|---|
| committer | ChangBo Guo(gcb) <eric.guo@easystack.cn> | 2017-12-22 10:10:59 +0800 |
| commit | 83a32d33c2987832d1762ce16c975d3d17fc7c4a (patch) | |
| tree | 27caaa540c0b4aa8d5b99319a1cd80c15d0218e6 /oslo_db/sqlalchemy/enginefacade.py | |
| parent | 4f81c419947e2793e3eda4ce8f3664058b5a5d2c (diff) | |
| download | oslo-db-83a32d33c2987832d1762ce16c975d3d17fc7c4a.tar.gz | |
add bandit to pep8 job
Add the bandit security scanner to the pep8 job.
* convert assert statement to raise AssertionError
* skip B311,B105
Change-Id: I23b2732791f42adfa04bd64f02b25cbdb98aaf93
Diffstat (limited to 'oslo_db/sqlalchemy/enginefacade.py')
| -rw-r--r-- | oslo_db/sqlalchemy/enginefacade.py | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/oslo_db/sqlalchemy/enginefacade.py b/oslo_db/sqlalchemy/enginefacade.py index 7871258..80c320b 100644 --- a/oslo_db/sqlalchemy/enginefacade.py +++ b/oslo_db/sqlalchemy/enginefacade.py @@ -843,7 +843,8 @@ class _TransactionContextManager(object): new = self._clone() new._root = new new._root_factory = self._root_factory._create_factory_copy() - assert not new._factory._started + if new._factory._started: + raise AssertionError('TransactionFactory is already started') return new def patch_factory(self, factory_or_manager): @@ -869,7 +870,8 @@ class _TransactionContextManager(object): raise ValueError( "_TransactionContextManager or " "_TransactionFactory expected.") - assert self._root is self + if self._root is not self: + raise AssertionError('patch_factory only works for root factory.') existing_factory = self._root_factory self._root_factory = factory |