From 5da6884dbc169ad8daff64b4ab7abab27de4a195 Mon Sep 17 00:00:00 2001 From: blue55 Date: Tue, 6 Jun 2017 09:50:44 +0800 Subject: Using assertIsNone(xxx) instead of assertEqual(None, xxx) Following OpenStack Style Guidelines: [1] https://docs.openstack.org/developer/hacking/#unit-tests-and-assertraises [H203] Unit test assertions tend to give better messages for more specific assertions. As a result, assertIsNone(xxx) is preferred over assertEqual(None, xxx) and assertIs(xxx, None) Change-Id: Id0e54ddeb461e56fbc8ec3a4bbc8a581f11430df --- oslo_db/tests/sqlalchemy/test_models.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/oslo_db/tests/sqlalchemy/test_models.py b/oslo_db/tests/sqlalchemy/test_models.py index 893d96f..0b0f6d8 100644 --- a/oslo_db/tests/sqlalchemy/test_models.py +++ b/oslo_db/tests/sqlalchemy/test_models.py @@ -211,7 +211,7 @@ class SoftDeleteMixinTest(test_base.DbTestCase): self.session.add(m) self.session.commit() self.assertEqual(0, m.deleted) - self.assertIs(None, m.deleted_at) + self.assertIsNone(m.deleted_at) m.soft_delete(self.session) self.assertEqual(123456, m.deleted) -- cgit v1.2.1