summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Updated from global requirementsjuno-eolstable/junoOpenStack Proposal Bot2015-08-132-2/+2
| | | | Change-Id: I85bdfbf678f7491c7bf8800aaa31cd211141df5d
* processutils: ensure on_completion callback is always calledDaniel P. Berrange2015-08-072-20/+40
| | | | | | | | | | | | | | | | | | If the subprocess.Popen.communicate method raises an exception, the on_completion callback is never invoked. If a caller is trying to use on_execute + on_completion to track lifecycle of a process this creates a problem, as they cannot reliably detect completion. Conflicts: oslo/concurrency/processutils.py tests/unit/test_processutils.py openstack/common/processutils.py Change-Id: I22b2d7bde8797276f7670bc289d915dab5122481 Closes-bug: #1470868 (cherry picked from commit ab78480659834ed07c84f8569df5d2c27965af00) (cherry picked from commit 397729bca2e58433d4dbe09a3fba51887b2d0966)
* Merge "Make use_syslog=True log to syslog via /dev/log" into stable/junoJenkins2015-08-071-2/+4
|\
| * Make use_syslog=True log to syslog via /dev/logRoman Podoliaka2015-08-061-2/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | After upgrade from Icehouse to Juno OpenStack services don't log to syslog via /dev/log anymore. This behaviour was introduced in commit 1188d88a73e75da5c143d0dfad34e10dad0daee0. While /dev/log is arguably not a very portable default, breaking the backwards compatibility is even worse. This commit restores the original behaviour. /dev/log portability issues will be addressed separately. Closes-Bug: #1385295 Related-Bug: #1391428 (cherry picked from commit ac4330dd674b073c4d31ef87e61710015ffe6c80) Conflicts: openstack/common/log.py Change-Id: I4e84bca70eee6d6aa8d7525fe38d65ba235dd6b0
* | Merge "Add 2 callbacks to processutils.execute()" into stable/junoJenkins2015-08-072-0/+33
|\ \
| * | Add 2 callbacks to processutils.execute()Tony Breeds2015-08-062-0/+33
| |/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add optional on_execute and on_completion callbacks to allow callers of procesutils.execute() to track process completion asynchronously. This could be used to cache the pid of long running tasks associated with an instance and then clear the cache when the process completes. While the tasks are running should it be required the pid retrieved and the process can be signaled. Conflicts: oslo/concurrency/processutils.py openstack/common/processutils.py Co-Authored-By: abhishekkekane <abhishek.kekane@nttdata.com> Change-Id: Ifc23325eddb523f6449ba06a2deb0885a8a7009d (cherry picked from commit 3c6bcf4cd62302f949e47f1102fa7f986e82c596) (cherry picked from commit 6bf29bd813c611cba9c161d3426e1cd745721676)
* | Updated from global requirementsOpenStack Proposal Bot2015-08-065-61/+60
|/ | | | Change-Id: I13dd778b16afa0f9ef092f84c84b937242054b2d
* Fix bad mock assertion callsMatt Riedemann2015-08-062-6/+9
| | | | | | | | | | | | | Latest mock checks for assertion calls that don't exist, usually because they are typos in the tests and with the nature of mock before it just lets you create whatever if you're not using a spec for the mock. Fixing the busted assertions exposed bugs in the tests so those are also fixed. Closes-Bug: #1482377 Change-Id: I37a546d9f8679f10d50f94774280ff02195a29f9
* Merge "Updated from global requirements" into stable/junoJenkins2015-06-112-3/+3
|\
| * Updated from global requirementsOpenStack Proposal Bot2015-05-142-3/+3
| | | | | | | | Change-Id: I0721616ff1210028e73cacda8e07ac14276f4946
* | Fixed metadata version of the repoIhar Hrachyshka2015-05-281-1/+1
|/ | | | | | | | | | | | Otherwise, gate fails with: "ValueError: git history requires a target version of pbr.version.SemanticVersion(2014.2.1), but target version is pbr.version.SemanticVersion(2014.2.0)" See: http://logs.openstack.org/periodic-stable/periodic-oslo-incubator-docs-juno/ed3ec90/console.html Change-Id: Icbc3670090e33c7c6791624f6bcb747c87c6eb04
* Updated from global requirementsOpenStack Proposal Bot2015-04-082-3/+3
| | | | Change-Id: Ic39e9285151dd802f1fcc6bd5381a6eddc1ba01b
* Updated from global requirementsOpenStack Proposal Bot2015-04-072-4/+4
| | | | Change-Id: Ieea7969f3ac9d221ac28ee0fb4b0c9c7f67187fe
* Fix matchmaker_redis ack_alive fails with KeyErrorIhar Hrachyshka2015-03-062-1/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix matchmaker_redis: ack_alive fails with KeyError on re-registration attempt. def ack_alive(self, key, host): topic = "%s.%s" % (key, host) if not self.redis.expire(topic, CONF.matchmaker_heartbeat_ttl): # If we could not update the expiration, the key # might have been pruned. Re-register, creating a new # key in Redis. self.register(self.host_topic[host], host) self.host_topic is a dict with keys of tuple (key, host), not 'host', register's first parameter is the topic like 'notification-info', so modify it to key. And it will not cause indefinite recursion, because when register end, the key exist in redis, redis.expire will return True. Add test case for ack_alive. (backported from oslo.messaging; omitting master branch since it does not have RPC module anymore.) Closes-Bug: #1419718 Change-Id: I8d972afe89aec02a5c8f0d9dd4e216bc12c298a1
* Updated from global requirementsOpenStack Proposal Bot2015-02-162-3/+3
| | | | Change-Id: Ic9fd87e33c18f1c8a8869810a6042ff1bff5a7d1
* Updated from global requirementsOpenStack Proposal Bot2015-02-124-52/+52
| | | | Change-Id: Ibac51e01e59fe8cfdef9da8387d3a7a014b6f147
* Move instantiation of the Syslog handlerSimon Pasquier2015-02-031-14/+14
| | | | | | | | | Move the creation of the Syslog handler before setting up the log formatter and the log level. The issue has been introduced when fixing bug #1328501. Change-Id: I2528731d094e07bf13b8190a61ceeb024b32f607 Closes-Bug: 1399088
* Added graceful argument on Service.stop methodClif Houck2015-01-212-3/+37
| | | | | | | | | | | | | | This change adds a graceful shutdown arugment to the Service.stop method in order to allow a service to gracefully wait for threads to shutdown. Since threadgroup already supports a graceful shutdown argument for its stop() method, it is trivial to support. Added unit tests to demonstrate the expected behavior between graceful and ungraceful service stop()s. Change-Id: Ibc0df09daef5e2a07f232543f44f2fc4d203511c Closes-Bug: 1406638 (cherry picked from commit 442fc2234e8500fb11633d8d8ee7dfe5492fa4a3)
* Merge "Updated from global requirements" into stable/junoJenkins2015-01-162-3/+3
|\
| * Updated from global requirementsOpenStack Proposal Bot2015-01-142-3/+3
| | | | | | | | Change-Id: I195d707194b4b1d663c1dc357c3ce97ae34ef4c1
* | Fix incorrect attribute name in matchmaker_redisIhar Hrachyshka2015-01-151-1/+1
|/ | | | | | | | Pass the correct base class attribute name for host topic to self.register and fix the AttributeError. Change-Id: Idfe94dd37cdba9f498f79cf87d4fff81e7c4249b Closes-Bug: #1246308
* Merge "ServiceRestartTest: make it more resilient" into stable/junoJenkins2014-12-221-47/+36
|\
| * ServiceRestartTest: make it more resilientIhar Hrachyshka2014-11-251-47/+36
| | | | | | | | | | | | | | | | | | | | | | | | | | | | The test spawned new processes to run services in, but didn't guard test suite with due attention not to leak those processes into test environment. Proper guarding mechanism is already implemented for another test, ServiceLauncherTest. Hence it was moved to their common ancestor (ServiceTestBase) and reused in both test classes. Closes-Bug: #1382573 Change-Id: If4ee7ed09696c3f5f3273f4d280c567b328ca75c (cherry picked from commit 3c94482a8f7ebc86866b6793ffde1a58bdd2b00d)
* | Updated from global requirementsOpenStack Proposal Bot2014-12-142-2/+2
| | | | | | | | Change-Id: I7981b723cee97ee65a7d58d5b058f24aa734c0e2
* | Updated from global requirementsOpenStack Proposal Bot2014-12-034-6/+6
| | | | | | | | Change-Id: Idff5239d264bc44923e4091e86203127db74ebd0
* | Updated from global requirementsOpenStack Proposal Bot2014-11-274-21/+21
|/ | | | Change-Id: I80ae8c11f0ab6182f9924a8d5f822fd51d30d1b5
* Updated defaultbranch for git-reviewIhar Hrachyshka2014-11-111-0/+1
| | | | Change-Id: I32329745b9987d0fd58a524e575dd94155dbc458
* Squashed two patches that simultaneously block the gateIhar Hrachyshka2014-11-113-10/+11
| | | | | | | | | | | | | | | | | | | | | | | | | === Redis: for non-strict Redis class, expired ttl is None, not -1 Python bindings for Redis return None if ttl is expired instead of -1 when Redis class is used (instead of StrictRedis) which is the default for oslo-incubator. Fixed unit test to pass the check. The patch does not belong to master where old RPC layer was removed since Kilo. Neither it belongs to oslo.messaging since the test was not copied there. Closes-Bug: #1259532 Change-Id: Id54e78ca56bb5a5bf1cdad31bc5965ff02c0d9b4 === Fix build break - switch from str to hash for lookup Closes-Bug: #1372177 Change-Id: I1a1f70bb204d3f43bdacd4ded53225f8416f1639 (cherry picked from commit 6b65a41dd2653aa9e2558c510fa9d3ca3538a908)
* Merge "Enabled mask_password to handle byte code strings"2014.2Jenkins2014-09-152-1/+10
|\
| * Enabled mask_password to handle byte code stringsJames Carey2014-09-152-1/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Byte code strings passed into mask_password cause the coersion to six.text_type to fail with a UnicodeDecodeError. The code can work with the byte code string, but the incoming message may be an i18n object that has to be coerced. The temporary fix is to ignore the UnicodeDecodeError on the coersion. A better solution will be provided for Kilo. This is related to cinder bug #1368527 Change-Id: I6dd5195d004477f61cc87bf22f3bf5958c78f754 Closes-bug: #1366189 Closes-bug: #1368527
* | Merge "Mark middleware as obsolete"Jenkins2014-09-151-2/+2
|\ \ | |/ |/|
| * Mark middleware as obsoleteDoug Hellmann2014-09-011-2/+2
| | | | | | | | | | | | | | The middleware modules have graduated to oslo.messaging or oslo.middleware so mark them as obsolete here. Change-Id: I51519e9c5218572ebf56415eb53f19d95c371b75
* | Let oslotest manage the six.move setting for moxDoug Hellmann2014-09-133-19/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | This instruction to set up a move in six for the mox module conflicts with the one in oslotest. We are trying to use mox3 everywhere, so remove this instruction and let oslotest handle it. This changeset modifies the tests for the old qpid RPC driver, which is deprecated. However, we need to make the file importable for testr to successfully run the tests that aren't deprecated, so we need that change as well. Change-Id: I59d5799283233f8411044ddb15c8abfc8850014c
* | Test formatting errors with log level being emittedDoug Hellmann2014-09-131-1/+1
| | | | | | | | | | | | | | | | | | | | The test to ensure that formatting errors are handled properly was being run using info level logging, but the default log configuration for tests does not emit messages at that level, so switch to error. Back-ported from commit with the same ID in oslo.log. Change-Id: Ie11a51deea65627b45a11d7dfca36d16c1b5949e
* | Always log the releasing, even under failureJoshua Harlow2014-09-121-7/+9
| | | | | | | | Change-Id: I4b87b5d9e5c42a1ab4c837ebb4d45b86faf87c21
* | Merge "Use immutable arg rather mutable arg"Jenkins2014-09-121-1/+2
|\ \
| * | Use immutable arg rather mutable argliuqing2014-09-121-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | Passing mutable objects as default args is a known Python pitfall. We'd better avoid this. This commit changes mutable default args with None, then use 'arg = arg or []'. Change-Id: Ie036e8203deb9ab10ffb7bce1db6cda6c3672a0c
* | | Merge "Do not incur the cost of a second method call"Jenkins2014-09-121-1/+1
|\ \ \ | |/ / |/| |
| * | Do not incur the cost of a second method callIan Cordasco2014-09-111-1/+1
| | | | | | | | | | | | | | | | | | | | | The usage of dict.get here is unnecessary since dict.setdefault will not override an existing value. Change-Id: Ie1b360cc7dd657aafda9f7d9de6c87cdf6c3f97d
* | | Merge "warn against sorting requirements"Jenkins2014-09-124-0/+16
|\ \ \
| * | | warn against sorting requirementsDoug Hellmann2014-09-034-0/+16
| | | | | | | | | | | | | | | | | | | | Change-Id: I64ae9191863564e278a35d42ec9cd743a233028e Addresses-Bug: #1365061
* | | | Merge "Add contributing page to docs"Jenkins2014-09-123-0/+33
|\ \ \ \
| * | | | Add contributing page to docsDavanum Srinivas2014-09-083-0/+33
| | | | | | | | | | | | | | | | | | | | Change-Id: Id9cae741bde738ea85a94c0d987347017d12734e
* | | | | Clarify logging in lockutilsBen Nemec2014-09-111-2/+4
| |_|/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The old logging statements in lockutils made for some confusing log entries where it would appear a given lock was acquired multiple times by different threads at the same time. See referenced bug for details. In order to alleviate that confusion, this change does a few things: 1) Adds an explicit "acquired" message inside the lock so it is clear when the lock was actually acquired. 2) Moves the release message inside the semaphore so there's no chance of it being logged out of order. 3) Removes the "Got semaphore" message and splits it into two separate messages depending on whether the semaphore was found in the weakref dictionary. Making it clear which code path was followed should help with future debugging. This is the incubator port of olso.concurrency change I0fbb473c60d48c9704597d9e3634402857861a66 Change-Id: If863c9d3896bc786f3c9c46196ebb0766e57d863 Closes-Bug: 1367941
* | | | Merge "Switch to using pbr's autodoc capability"Jenkins2014-09-103-104/+22
|\ \ \ \ | |/ / /
| * | | Switch to using pbr's autodoc capabilityDavanum Srinivas2014-09-043-104/+22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Once we use the pbr based build to generate files, we prune the indexes to remove references to code we would like to hide like the common modules and private modules in conf.py. We reuse the same excluded_patterns variable that is already used in Sphinx and filter these modules from autoindex.rst Change-Id: I777bdeaee5332a73ee39bc5bdc832bd0140724ce
* | | | Merge "fix small typo"Jenkins2014-09-101-2/+2
|\ \ \ \
| * | | | fix small typoDavanum Srinivas2014-09-041-2/+2
| |/ / / | | | | | | | | | | | | Change-Id: Iac97581e59f6d9f46b43c4a4fc800313fb6cc1b0
* | | | Merge "Work toward Python 3.4 support and testing"Jenkins2014-09-101-1/+65
|\ \ \ \
| * | | | Work toward Python 3.4 support and testingJeremy Stanley2014-09-031-1/+65
| | |/ / | |/| | | | | | | | | | Change-Id: I9914f98b935e81e3735309986aa7e7d7554b0113
View Lorry Controller Status