| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|/ /
| |
| |
| | |
Change-Id: Ia49f626bb9ca16c4133519dd5c425a956ae4a447
|
| |
| |
| |
| | |
Change-Id: Ib841b7da7458dd77eadda3228463fa9db98bb2ff
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
In ContextFormatter.format(), for python2 it checks each arg to
determine whether unicode should be used for the format message.
The problem is the code assumes the args are a list, when they can
also be a dict, for example:
LOG.info('%(thing)s', {'thing': '...'})
and in that case, the dict keys were implicitly being used for the
checks. The checks will always pass on string dict keys, so the
format message gets converted to unicode even though the corresponding
args will ultimately fail decoding to unicode. Then, the logging fails
with:
UnicodeDecodeError: 'ascii' codec can't decode byte 0xc6 in
position 0: ordinal not in range(128)
when the unicode format message causes an implicit conversion attempt
of the args to unicode [1].
This adds a check for the args type and uses the dict values for the
unicode checks so that dict args with values that fail decoding will
have: should_use_unicode = False.
Closes-Bug: #1580728
[1] https://github.com/python/cpython/blob/2e576f5/Lib/logging/__init__.py#L338
Change-Id: I8c479e507efcf8acd3e3faa4a702fa6e1f18772f
|
|\ \ |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The namespace name (oslo.messaging) is set to INFO, but we don't do it
with the oslo_messaging package name. It logs with both prefix, so we
should set INFO on both.
Change-Id: Ia8e53b0b40dd546abecc73abe855939200167ee8
|
|/ /
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Upstream python-systemd has a journald logging handler that also adds
some exception information, as well as thread information.
https://github.com/systemd/python-systemd/blob/master/systemd/journal.py#L581-L589
While OpenStack doesn't use a lot of threads, we might as well support it
since it's no cost. Also, add PROCESS_NAME just to be compatible with
other programs that might use python journald logging. Not entirely sure
if record.processName and the results of our self.binary_name will be
different.
The exception info is the fun stuff though.
Change-Id: Ibf0d7dae7587639737e0327f0338f30cdfc6aba1
|
|\ \ |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The following change removed the platform check that was preventing
the syslog handler class from being defined on incompatible
platforms: d61af05ff10e92e73ec8745be5f1828e6b2effda
The only issue with that is the fact that one method default value
uses a syslog module constant that gets evaluated even if the class
itself is never instantiated.
This patch fixes the issue by moving that default value within the
init method.
Closes-Bug: #1682177
Change-Id: Ie88e367957c5739f335cb96fcefc8501a9bf4bcd
|
|\ \ \ |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Use https instead of http to ensure the safety without containing our
account/password information
Change-Id: Icf3c839f411b52d6d93ec42728486b6239a97a0d
|
| |/ /
|/| |
| | |
| | | |
Change-Id: I82bd97fb8d02da79e95fb1cb2a437d387f78dd7c
|
|\ \ \ |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Express the dependency on the systemd library through a setuptools
"extras" list.
Depends-On: I8d1cfeffafce810fb30db24d55aea43759291aad
Change-Id: I17cbc7fad84dd8ad9f420d4225d4c5ac059c9ad8
Signed-off-by: Doug Hellmann <doug@doughellmann.com>
|
|\ \ \ \
| |/ / /
|/| | | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This adds documentation and the release not for systemd journal
support in oslo.log.
Change-Id: I91157749ddc3029af0d4df101db4d09661a2cd2f
|
|\ \ \ \ |
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Previously we didn't define OSSysLogHandler at all if it was on a
platform without syslog, because we used syslog at a class level to
build the log priority map.
That now uses a static mapping, which means that OSSysLogHandler can
always be defined, and use the same RuntimeError on init that
OSJournalHandler does.
Change-Id: Id61af05ff10e92e73ec8745be5f1828e6b2effda
|
|\ \ \ \ \
| |/ / / /
| | | / /
| |_|/ /
|/| | | |
|
| |/ /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The systemd handler needs the syslog level values for its setup, but the
library is used on platforms where syslog is not present. Ignore the
situation when setting up the class, but throw an error if the class is
used at runtime.
This also converts the exception for the missing systemd library to a
RuntimeException so the two errors for missing libraries are consistent.
Change-Id: I76729503cb2ec9df878b19a1d76786c3efd9054e
Signed-off-by: Doug Hellmann <doug@doughellmann.com>
|
|\ \ \
| |/ / |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The systemd journal has a native facility for sending logging to it,
which allows for much richer metadata with log messages. These can be
queried later.
This introduces a new 'use_journal' flag, if used will log natively to
the systemd journal. In addition to the existing log messages getting
send to the journal, it also sends a number of additional variables
(when they exist on the context) like REQUEST_ID, which can be
searched with journalctl.
Basic mock testing is included.
Change-Id: If2591576a96d8ca6e36f4dc6600f5412f40509e2
|
|\ \ \
| |/ /
|/| | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Also included a unit test which will validate that scenario.
Error occured at oslo_privsep implementation, which is fixed upstream:
https://github.com/openstack/oslo.privsep/commit/3c47348ced0d3ace1113ba8de8dff015792b0b89
Change-Id: I6dd34f80662d2733b37f8d8d1b9f81eb6161f346
|
|\ \ \ |
|
| | | |
| | | |
| | | |
| | | | |
Change-Id: I95cf1a962bb2e1df05cb3a4b75a6ed7981793847
|
|\ \ \ \ |
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
We don't use testscenarios anywhere, need remove it.
Change-Id: I3128cc030587d167f4e903cf1951d29ac5fb9d5f
|
|\ \ \ \ \
| |/ / / /
|/| | | | |
|
| | |/ /
| |/| |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Log messages are no longer being translated. This removes all use of the
_LE, _LI, and _LW translation markers to simplify logging and to avoid
confusion with new contributions.
See:
http://lists.openstack.org/pipermail/openstack-i18n/2016-November/002574.html
http://lists.openstack.org/pipermail/openstack-dev/2017-March/113365.html
Change-Id: Icd0b501fe919d0857990302b4cc78d54248b8d22
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
With pbr 2.0 and Sphinx 1.5, the setting for treat sphinx warnings as
errors is setting warning-is-error in build_sphinx section. Migrate
the setting from the old warnerrors one.
Change-Id: I8887825011e91701638d207021f875ec74061ba8
|
| |/ /
|/| |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Probably the most common format for documenting arguments is reST field
lists [1]. This change updates some docstrings to comply with the field
lists syntax.
[1] http://sphinx-doc.org/domains.html#info-field-lists
Change-Id: I36413c6f1e44dc586c98228d6abd9f38952f6391
|
|\ \ \
| |/ /
|/| | |
|
| |/
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The deprecation for this was merged on aug 1, 2015 in review:
https://review.openstack.org/#/c/206437/
That was a long time ago so it should be possible to remove it now.
This was already merged once but had to be reverted because some
projects were still relying on it. Let's try again, this time using
INFO default not WARNING, thanks dtantsur!
Depends-On: I713e9e5107a64ec29c220d1150c1bf5fcf6f1135
Depends-On: I102e8c7bca508b17ce2987b33148e99c79d0c147
Change-Id: I9e2bf358a0b7a2413388007b33902b91de522b22
|
|/
|
|
| |
Change-Id: Ia5df2a4b98422f9fb3c92370c956b7c6309b5b3d
|
|
|
|
|
|
|
|
|
| |
This is to allow consuming projects to avoid direct access to debug
configuration option that is defined by the library. This is in line
with general oslo guidelines about accessing oslo options from inside
consuming projects' code.
Change-Id: Ic1ae2d3f0e198ac367c1ad785f3d8dc13335282f
|
|
|
|
| |
Change-Id: I831ed1b4d9b314eb0db6516d21cda8d504f1beb3
|
|
|
|
|
|
|
|
|
| |
Since pbr already landed and the old version of hacking seems not
work very well with pbr>=2, we should update it to match global
requirement.
Partial-Bug: #1668848
Change-Id: Id518983a40aba2ea7a11bfea0ac403073e6069bf
|
|\ |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This reverts commit 4d8e122878b7af1865ad6dbce05e59a7701978a2.
We still use config option verbose in many projects[1],
and this also breaks periodic-nova-py27-with-oslo-master job.
We can do this again once we clean up usages of it totally.
[1]http://codesearch.openstack.org/?q=verbose%3DTrue&i=nope&files=&repos=
Change-Id: I04f1e7446b00f6b23aec188ad56ac38dbb917817
|
|\ \ |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
After the patch 'Default use_stderr to False'[1] landed, the
color output from devstack logs does not follow the desired
standard, with differentiation of messages by LOG level, making
debug and tracing errors a nightmare. This brings the colors
to the correct behaviour.
Change-Id: Ie5a30e1c991cbd0aea34d83570e9bc7cc4a80ca2
Closes-bug: #1659077
|
| |/
|/|
| |
| | |
Change-Id: If2b23abb43851282e25b3cfe71024ff0a6512556
|
|\ \ |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The gating on python 3.4 is restricted to <= Mitaka. This is due
to the change from Ubuntu Trusty to Xenial, where only python3.5
is available. There is no need to continue to keep these settings.
Change-Id: I0be8f513e8432438a872c59dfbb0688a5c3e5bcc
|
|\ \ \ |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
The deprecation for this was merged on aug 1, 2015 in review:
https://review.openstack.org/#/c/206437/
That was a long time ago so it should be possible to remove it now.
This was already merged once but had to be reverted because some
projects were still relying on it. Let's try again, this time using
INFO default not WARNING, thanks dtantsur!
Change-Id: Iac62cb252db0e8d86c352210089d70405edb5c4d
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
We need to pass into VersionInfo what one would expect from running:
setup.py --name
Right now we pass in say oslo_context and pbr fails if there is no .git in
the python source tree
Closes-Bug: #1662266
Change-Id: Ief1b4cf71bb0830160ff91b0d359042618038931
|
|\ \ \ \ |
|
| | |_|/
| |/| |
| | | |
| | | | |
Change-Id: I81e928fb5222d055f248d50a5332ea39d4b9ebc1
|
|\ \ \ \ |
|