summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
* | Updated from global requirements3.29.0OpenStack Proposal Bot2017-07-051-1/+1
| | | | | | | | Change-Id: I9944f280fcca7ff76cd5ebbb7f21516af6cc7c22
* | Merge "only show error_summary for warning and error messages"Jenkins2017-07-052-8/+8
|\ \
| * | only show error_summary for warning and error messagesDoug Hellmann2017-06-272-8/+8
| | | | | | | | | | | | | | | | | | | | | | | | Further reduce the clutter from error_summary by only including it when the log message will be emitted for the warning level or above. Change-Id: Ia46a7e569b875cd75fec652dfe8a4d73661dfda8 Signed-off-by: Doug Hellmann <doug@doughellmann.com>
* | | Merge "Fix bug in log_method_call decorator"Jenkins2017-07-052-9/+43
|\ \ \
| * | | Fix bug in log_method_call decoratorKiseok Kim2017-05-252-9/+43
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | log_method_call decorator miss first argument of staticmethod and function. the cause of bug is wrong start position of argument array for staticmethod. This patch adds a bug fix and test code. Change-Id: Id83378ba5954a855f18a4fdcfd22d2c7887991b2 Closes-Bug: #1672283
* | | | switch from oslosphinx to openstackdocsthemeDoug Hellmann2017-06-273-6/+12
| | | | | | | | | | | | | | | | | | | | | | | | Depends-On: Ifc5512c0e2373cf3387e0e0498268eab092e52bb Change-Id: I890bc443bf07a4570c907668288176ff2411e4ed Signed-off-by: Doug Hellmann <doug@doughellmann.com>
* | | | rearrange content to fit the new standard layoutDoug Hellmann2017-06-2729-23/+43
| |/ / |/| | | | | | | | | | | | | | Change-Id: Ic218b63c96d43c3c08744f18e0e0d56dd381987c Depends-On: Ia750cb049c0f53a234ea70ce1f2bbbb7a2aa9454 Signed-off-by: Doug Hellmann <doug@doughellmann.com>
* | | Updated from global requirementsOpenStack Proposal Bot2017-06-271-1/+1
| |/ |/| | | | | Change-Id: I1fa74fa0f2188aa765210f1e455a7bfde0c84098
* | Updated from global requirementsOpenStack Proposal Bot2017-06-151-1/+1
| | | | | | | | Change-Id: I052c7f9df68be3e09e091ed4d937dce023cd6b95
* | do not add error_summary for debug log messages3.28.1Doug Hellmann2017-06-122-1/+6
| | | | | | | | | | | | | | | | | | | | We catch exceptions and log debug messages a lot, which results in extra occurrences of the exception when we don't need them. Change-Id: I4dd3bf65fb456afc07a8fa7d0c9869bcc266b800 Related-Bug: #1696213 Related-Bug: #1696855 Signed-off-by: Doug Hellmann <doug@doughellmann.com>
* | Merge "formatter: skip ImportError when adding error_summary"3.28.0Jenkins2017-06-052-2/+5
|\ \
| * | formatter: skip ImportError when adding error_summaryIhar Hrachyshka2017-06-022-2/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In some projects, we conditionally import modules that may be not installed, for example in Neutron where we import from ibm_db_alembic but ignore ImportError in alembic env.py. It turned out that ImportError is not cleared by except: pass in py2 (but is correctly cleared in py3), as can be seen in the snippet below (kudos to @dhellmann for providing it): apu:~$ cat testme.py import sys print('before:', sys.exc_info()[0]) try: import nonesuch except ImportError: pass print('after:', sys.exc_info()[0]) apu:~$ python2 ./testme.py ('before:', None) ('after:', <type 'exceptions.ImportError'>) apu:~$ python3 ./testme.py before: None after: None The patch makes the formatter skip ImportErrors. We could in theory limit it to py2 only but to simplify matters and to stick to identical behavior across python runtimes, we will just unconditionally skip it for all library consumers. This is a follow up to Ifecb831c0adf4086a9d39feb3eb7e3865db780e6 ("skip built-in exceptions when adding error_summary") that already skipped some builtin exceptions. Change-Id: Ia8f7e2501a49345b8d828ec3ee4a7cc870c8a0a8
* | | Updated from global requirementsOpenStack Proposal Bot2017-06-021-1/+1
|/ / | | | | | | Change-Id: I39a505e5947d243d3821676fa16adf6411313884
* | Updated from global requirementsOpenStack Proposal Bot2017-06-021-1/+1
| | | | | | | | Change-Id: I6d4cbefb369c15d2cfd3d3af44c6466c8736a702
* | Updated from global requirements3.27.0OpenStack Proposal Bot2017-05-261-1/+1
| | | | | | | | Change-Id: Ie4369896e11557f34fafb08b8af4b8a5ea59a10b
* | clarify release note for error summary handlingDoug Hellmann2017-05-241-5/+6
| | | | | | | | | | Change-Id: I1513ab1e1f4e1abf1ad8e968ab47cf043a6f29a7 Signed-off-by: Doug Hellmann <doug@doughellmann.com>
* | Merge "Updated from global requirements"Jenkins2017-05-241-1/+1
|\ \
| * | Updated from global requirementsOpenStack Proposal Bot2017-05-241-1/+1
| | | | | | | | | | | | Change-Id: If61303cceaec8a336fa39b23cfae89582f11a61a
* | | fix test description commentDoug Hellmann2017-05-241-3/+2
|/ / | | | | | | | | | | | | | | Update the comment to explain what the test does, rather than what the old test that was copied to create the new test did. Change-Id: I1a23d1134a3b0269bd2a61b8768a64fe6039fe85 Signed-off-by: Doug Hellmann <doug@doughellmann.com>
* | Merge "add line number information to fluentd formatter"Jenkins2017-05-232-0/+2
|\ \
| * | add line number information to fluentd formatterDoug Hellmann2017-05-152-0/+2
| | | | | | | | | | | | | | | Change-Id: Idfb6dda0749b5dfdb2746de8db223d2df5e97abb Signed-off-by: Doug Hellmann <doug@doughellmann.com>
* | | Merge "add error_summary support for fluentd formatter"Jenkins2017-05-232-1/+20
|\ \ \ | |/ /
| * | add error_summary support for fluentd formatterDoug Hellmann2017-05-152-1/+20
| | | | | | | | | | | | | | | Change-Id: Ia4b570bd29783540b90dd36a5d189ee6940f8ea6 Signed-off-by: Doug Hellmann <doug@doughellmann.com>
* | | Merge "add error_summary support to JSONFormatter"Jenkins2017-05-232-1/+22
|\ \ \ | |/ /
| * | add error_summary support to JSONFormatterDoug Hellmann2017-05-152-1/+22
| | | | | | | | | | | | | | | Change-Id: I177a9f1a127da8d7cbb4da5bccc315b5a7dbaaba Signed-off-by: Doug Hellmann <doug@doughellmann.com>
* | | Oslo i18n 3.15.2 has broken depsAndrea Frittoli2017-05-231-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Oslo i18n removed babel from requirements but it has a runtime dependency on it, so it fails to install. g-r change: Ib77b3271a4e9861e391623ba5f03e5303512096a Related-Bug: #1692773 Change-Id: I99afc304b2f0955a190ea5f298cdd1018bdf4ae4
* | | Merge "refactor error summary logic so it can be reused"Jenkins2017-05-221-49/+67
|\ \ \ | |/ /
| * | refactor error summary logic so it can be reusedDoug Hellmann2017-05-151-49/+67
| | | | | | | | | | | | | | | Change-Id: Ia5e55c035d087a27fa824f60a3a8aef19f6d485b Signed-off-by: Doug Hellmann <doug@doughellmann.com>
* | | Remove deprecated module loggersChangBo Guo(gcb)2017-05-221-29/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | The class WritableLogger was deprecated since liberty, and it's not used by other projects, just remove it. Depends-On: If8adae9807387fd32bad9923f5c7dab769572035 Depends-On: I1709f8a3f3ec50567b7f6217c3c1a2a61eecae62 Change-Id: I1ebed0855c5f9f410d8f6fbd786ce5b3409d8eb6
* | | Merge "improve the documentation for log format strings"Jenkins2017-05-211-0/+138
|\ \ \ | |/ /
| * | improve the documentation for log format stringsDoug Hellmann2017-05-151-0/+138
| | | | | | | | | | | | | | | | | | | | | | | | Incorporate some of the information from the upstream docs here and add information about a few of our custom message parameters. Change-Id: Ib6f934e7f5d6e43afa8021241f92000c644c5e6d Signed-off-by: Doug Hellmann <doug@doughellmann.com>
* | | Merge "skip built-in exceptions when adding error_summary"Jenkins2017-05-212-0/+26
|\ \ \ | |/ /
| * | skip built-in exceptions when adding error_summaryDoug Hellmann2017-05-152-0/+26
| | | | | | | | | | | | | | | | | | | | | | | | | | | We have a lot of cases where we catch a built-in exception then log. Those exceptions don't add useful information, so do not include them automatically in the log output. Change-Id: Ifecb831c0adf4086a9d39feb3eb7e3865db780e6 Signed-off-by: Doug Hellmann <doug@doughellmann.com>
* | | Merge "make handling of error_summary more flexible"Jenkins2017-05-213-21/+77
|\ \ \ | |/ /
| * | make handling of error_summary more flexibleDoug Hellmann2017-05-153-21/+77
| | | | | | | | | | | | | | | | | | | | | | | | Allow operators to override the location of the error summary within the format string, if they choose. Change-Id: I85fe5abaa0781d033638e3b6f120184726d205ac Signed-off-by: Doug Hellmann <doug@doughellmann.com>
* | | Merge "add exception summaries to the main log line"Jenkins2017-05-213-31/+64
|\ \ \ | |/ /
| * | add exception summaries to the main log lineDoug Hellmann2017-05-153-31/+64
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Normally when logging while there is an active exception, the exception is formatted as a traceback and the log message string ends up on a separate line. This change adds the 1-line summary of the exception, including the exception class name and the text of the exception, to the end of the log line. The traceback is retained, so that the full details are still logged. Adding the exception info in the formatter means that the default excepthook function no longer needs to do that (otherwise we end up with duplicate information on the lines logged by the excepthook). Fix the duplication by replacing the extra traceback formatting with a static message that there is an unhandled error. Depends-On: Icb2e1c6d9fe40229119467e9261055d9464d331d Change-Id: Ib29883a1b7aa665b5d3c728dd7bd53d449987191 Signed-off-by: Doug Hellmann <doug@doughellmann.com>
* | | Updated from global requirementsOpenStack Proposal Bot2017-05-171-1/+1
|/ / | | | | | | Change-Id: Ia49f626bb9ca16c4133519dd5c425a956ae4a447
* | Updated from global requirementsOpenStack Proposal Bot2017-05-151-1/+1
| | | | | | | | Change-Id: Ib841b7da7458dd77eadda3228463fa9db98bb2ff
* | Use dict arg values for unicode checks in ContextFormatter3.26.1melanie witt2017-05-042-1/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In ContextFormatter.format(), for python2 it checks each arg to determine whether unicode should be used for the format message. The problem is the code assumes the args are a list, when they can also be a dict, for example: LOG.info('%(thing)s', {'thing': '...'}) and in that case, the dict keys were implicitly being used for the checks. The checks will always pass on string dict keys, so the format message gets converted to unicode even though the corresponding args will ultimately fail decoding to unicode. Then, the logging fails with: UnicodeDecodeError: 'ascii' codec can't decode byte 0xc6 in position 0: ordinal not in range(128) when the unicode format message causes an implicit conversion attempt of the args to unicode [1]. This adds a check for the args type and uses the dict values for the unicode checks so that dict args with values that fail decoding will have: should_use_unicode = False. Closes-Bug: #1580728 [1] https://github.com/python/cpython/blob/2e576f5/Lib/logging/__init__.py#L338 Change-Id: I8c479e507efcf8acd3e3faa4a702fa6e1f18772f
* | Merge "Add oslo_messaging to the list of log levels"3.26.0Jenkins2017-04-211-1/+2
|\ \
| * | Add oslo_messaging to the list of log levelsThomas Herve2017-04-191-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | The namespace name (oslo.messaging) is set to INFO, but we don't do it with the oslo_messaging package name. It logs with both prefix, so we should set INFO on both. Change-Id: Ia8e53b0b40dd546abecc73abe855939200167ee8
* | | Add additional info like python-systemd doesMonty Taylor2017-04-193-2/+43
|/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Upstream python-systemd has a journald logging handler that also adds some exception information, as well as thread information. https://github.com/systemd/python-systemd/blob/master/systemd/journal.py#L581-L589 While OpenStack doesn't use a lot of threads, we might as well support it since it's no cost. Also, add PROCESS_NAME just to be compatible with other programs that might use python journald logging. Not entirely sure if record.processName and the results of our self.binary_name will be different. The exception info is the fun stuff though. Change-Id: Ibf0d7dae7587639737e0327f0338f30cdfc6aba1
* | Merge "Fix syslog module usage breaking Windows compatibility"3.25.0Jenkins2017-04-131-1/+4
|\ \
| * | Fix syslog module usage breaking Windows compatibilityLucian Petrut2017-04-121-1/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The following change removed the platform check that was preventing the syslog handler class from being defined on incompatible platforms: d61af05ff10e92e73ec8745be5f1828e6b2effda The only issue with that is the fact that one method default value uses a syslog module constant that gets evaluated even if the class itself is never instantiated. This patch fixes the issue by moving that default value within the init method. Closes-Bug: #1682177 Change-Id: Ie88e367957c5739f335cb96fcefc8501a9bf4bcd
* | | Merge "Optimize the link address"Jenkins2017-04-133-9/+9
|\ \ \
| * | | Optimize the link addressloooosy2017-04-083-9/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Use https instead of http to ensure the safety without containing our account/password information Change-Id: Icf3c839f411b52d6d93ec42728486b6239a97a0d
* | | | Updated from global requirementsOpenStack Proposal Bot2017-04-122-2/+3
| |/ / |/| | | | | | | | Change-Id: I82bd97fb8d02da79e95fb1cb2a437d387f78dd7c
* | | Merge "add an extras dependency for systemd"3.24.0Jenkins2017-04-101-1/+2
|\ \ \
| * | | add an extras dependency for systemdDoug Hellmann2017-04-101-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Express the dependency on the systemd library through a setuptools "extras" list. Depends-On: I8d1cfeffafce810fb30db24d55aea43759291aad Change-Id: I17cbc7fad84dd8ad9f420d4225d4c5ac059c9ad8 Signed-off-by: Doug Hellmann <doug@doughellmann.com>