diff options
| author | Gevorg Davoian <gdavoian@mirantis.com> | 2016-05-13 15:41:22 +0300 |
|---|---|---|
| committer | Gevorg Davoian <gdavoian@mirantis.com> | 2016-05-19 15:18:28 +0300 |
| commit | 39749c77a843a845c540c8afb1e5c7f617c33a22 (patch) | |
| tree | 7677522c5510a9f0b3758c6409bff50159b2da67 /oslo_messaging/_drivers/common.py | |
| parent | b8cafee601a8246e5f4ef18781f4de4d03160dc1 (diff) | |
| download | oslo-messaging-39749c77a843a845c540c8afb1e5c7f617c33a22.tar.gz | |
Remove logging from serialize_remote_exception
This patch removes log_failure argument from the function
serialize_remote_exception and from driver implementations
using it (because it is never used and always defaults to True)
and prevents error logging in this function (because these errors
are already logged by servers while processing incoming messages).
Change-Id: Ic01bb11d6c4f018a17f3219cdbd07ef4d30fa434
Closes-Bug: 1580352
Diffstat (limited to 'oslo_messaging/_drivers/common.py')
| -rw-r--r-- | oslo_messaging/_drivers/common.py | 7 |
1 files changed, 2 insertions, 5 deletions
diff --git a/oslo_messaging/_drivers/common.py b/oslo_messaging/_drivers/common.py index 7b446d7..7ac1e4d 100644 --- a/oslo_messaging/_drivers/common.py +++ b/oslo_messaging/_drivers/common.py @@ -162,18 +162,15 @@ class Connection(object): raise NotImplementedError() -def serialize_remote_exception(failure_info, log_failure=True): +def serialize_remote_exception(failure_info): """Prepares exception data to be sent over rpc. Failure_info should be a sys.exc_info() tuple. """ tb = traceback.format_exception(*failure_info) + failure = failure_info[1] - if log_failure: - LOG.error(_LE("Returning exception %s to caller"), - six.text_type(failure)) - LOG.error(tb) kwargs = {} if hasattr(failure, 'kwargs'): |