diff options
| author | Mehdi Abaakouk <sileht@redhat.com> | 2017-11-28 15:47:54 +0100 |
|---|---|---|
| committer | Mehdi Abaakouk <sileht@redhat.com> | 2017-11-29 21:13:50 +0100 |
| commit | c38857e1101027a734a35f4e80bc4084fabc034b (patch) | |
| tree | 65a5826558355f4fec329564e6724c2efd0f7eed /releasenotes | |
| parent | 7c65038e79850b878187feb366ad2db0bc960572 (diff) | |
| download | oslo-messaging-c38857e1101027a734a35f4e80bc4084fabc034b.tar.gz | |
rabbitmq: don't wait for message ack/requeue
I don't see any obvious reason why we should wait ack/requeue is done.
This waiter have already be removed from amqp1.
https://git.openstack.org/cgit/openstack/oslo.messaging/tree/oslo_messaging/_drivers/amqp1_driver/controller.py#n242
So, this change remove it from rabbitmq driver too.
Closes-bug: #1734788
Change-Id: I5ecedc762596181be19410b863851a0054fd6579
Diffstat (limited to 'releasenotes')
| -rw-r--r-- | releasenotes/notes/rabbit-no-wait-for-ack-9e5de3e1320d7660.yaml | 12 |
1 files changed, 12 insertions, 0 deletions
diff --git a/releasenotes/notes/rabbit-no-wait-for-ack-9e5de3e1320d7660.yaml b/releasenotes/notes/rabbit-no-wait-for-ack-9e5de3e1320d7660.yaml new file mode 100644 index 0000000..4b9d47a --- /dev/null +++ b/releasenotes/notes/rabbit-no-wait-for-ack-9e5de3e1320d7660.yaml @@ -0,0 +1,12 @@ +--- +other: + - | + On rabbitmq, in the past, acknownlegement of messages was done within the + application callback thread/greenlet. This thread was blocked until the + message was ack. In newton, we rewrote the message acknownlegement to + ensure we haven't two threads writting the the socket at the same times. + Now all pendings ack are done by the main thread. They are no more reason + to block the application callback thread until the message is ack. Other + driver already release the application callback threads before the message + is acknownleged. This is also the case for rabbitmq, now. + |