diff options
| author | Michael Krotscheck <krotscheck@gmail.com> | 2016-05-04 10:07:21 -0700 |
|---|---|---|
| committer | Michael Krotscheck <krotscheck@gmail.com> | 2016-05-09 07:18:47 -0700 |
| commit | 7e519d008f7743d75ec299095060a70d5fd00f99 (patch) | |
| tree | ee5a61195a35943126ff603683c8360879009261 | |
| parent | 399e94043fdf40f413f0335387b1d92f0dd215ce (diff) | |
| download | oslo-middleware-7e519d008f7743d75ec299095060a70d5fd00f99.tar.gz | |
Deprecate using String as valid value for allowed_origin.
This adds a deprecation note to users that pass strings to what
should be a list.
Change-Id: If1130b60679011d76d6452a57de31184eb6142f2
| -rw-r--r-- | oslo_middleware/cors.py | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/oslo_middleware/cors.py b/oslo_middleware/cors.py index 6826016..8857afc 100644 --- a/oslo_middleware/cors.py +++ b/oslo_middleware/cors.py @@ -12,7 +12,6 @@ # implied. See the License for the specific language governing permissions and # limitations under the License. -# Default allowed headers import copy import logging @@ -231,6 +230,9 @@ class CORS(base.ConfigurableMiddleware): # NOTE(dims): Support older code that still passes in # a string for allowed_origin instead of a list if isinstance(allowed_origin, six.string_types): + # TODO(krotscheck): https://review.openstack.org/#/c/312687/ + LOG.warn('DEPRECATED: The `allowed_origin` keyword argument in ' + '`add_origin()` should be a list, found String.') allowed_origin = [allowed_origin] if allowed_origin: |