| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
|
| |
Change-Id: I53005107bf4c05809182dc3865c5dc72c77b1054
Signed-off-by: Sean McGinnis <sean.mcginnis@gmail.com>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Webob >=1.7.0 change its way to check if body is readable [1],
The is_body_readable() method returns False now. request.content_length
will be set when set request.body automatically, and if
request.context_length is None request.body will return returns b''.[3]
So just set request.body in test.
[1] https://github.com/Pylons/webob/commit/0e6fcbfbc58af6fdd4e125543bf8f5fb91b984c6
[2] https://github.com/Pylons/webob/blame/master/webob/request.py#L699
[3] https://github.com/Pylons/webob/blame/master/webob/request.py#L692
Closes-Bug: #1679658
Change-Id: I4e0932dd8664d96b2733c5d3b1fa846af0c7d132
|
| |
|
|
|
|
|
|
|
|
|
|
| |
Many assertEqual sentences don't follow assertEqual(expected, actual),
These misplaces have 2 impacts:
1, giving confusing messages when some tests failed.
2, mislead other developers, new test modules may follow these wrong pattern.
This patch fix all of them.
Change-Id: I901e87c52aac317c5cd9942aa1cd35a067aaa94d
Closes-Bug: #1604213
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently application that doesn't use the global configuration object
have to rely on hack to setup the global oslo config object for each middleware
it want to use.
For example, gnocchi have its own middleware loader and add crap to load
keystonemiddleware:
https://github.com/openstack/gnocchi/blob/master/gnocchi/rest/app.py#L140
And it can't use oslo.middleware that relies on the global conf object.
Also aodh (use 'paste' for middleware) have to hack the global
configuration object for each middlewares it want to use by code...
https://review.openstack.org/#/c/208632/1/aodh/service.py
But middleware are optional deployer stuffs, we should not write any
code for them...
This change allows application to use paste-deploy (or any middleware
loader) without enforcing the application to use the global oslo.config object.
If the middleware want to use oslo.config it should load the
configuration file himself (and fallback to the global one if any)
The proposed paste configuration to allow this is:
[filter:cors]
paste.filter_factory = oslo.middleware:cors
oslo_config_project = aodh
So the cors middleware can find and load the aodh config and
what is it interested in.
Also, some of them use oslo.config local, some other the global object.
Some can be loaded by an middleware loader like paste, some other not.
This change make consistent the way we bootstrap all middlewares.
Closes-bug: #1482086
Change-Id: Iad197d1f3a386683d818b59718df34e14e15ca5c
|
| |
|
|
|
| |
Change-Id: I4ec9b2a310471e4e07867073e9577731ac34027d
Blueprint: drop-namespace-packages
|
|
|
Move the public API out of oslo.middleware to oslo_middleware. Retain
the ability to import from the old namespace package for backwards
compatibility for this release cycle.
bp/drop-namespace-packages
Change-Id: If88c65c82b64f096a02f7ec62e019aea4de2f9d3
|
