diff options
| author | Gary Kotton <gkotton@vmware.com> | 2019-03-03 06:52:30 -0800 |
|---|---|---|
| committer | Gary Kotton <gkotton@vmware.com> | 2019-03-03 07:02:01 -0800 |
| commit | 009c5e3bfe88594d791034f38a4b2dbf7219c16f (patch) | |
| tree | dfc57360d7911300b0f1813932dea132535f78bb | |
| parent | 507afb25b19ba8ba86dd97ee4aaa5fe0c16ceea6 (diff) | |
| download | oslo-vmware-009c5e3bfe88594d791034f38a4b2dbf7219c16f.tar.gz | |
Return None if no suitable datastore is found
In the case of a datastore cluster, if no datastor is found then
return None. Do not fail on a key exception for accessing a field
that does not exist
Change-Id: I036f8022e2b9f454f7cd10846b408153a18b7b60
| -rw-r--r-- | oslo_vmware/objects/datastore.py | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/oslo_vmware/objects/datastore.py b/oslo_vmware/objects/datastore.py index c927781..ef3bf7f 100644 --- a/oslo_vmware/objects/datastore.py +++ b/oslo_vmware/objects/datastore.py @@ -61,6 +61,9 @@ def get_recommended_datastore(session, sp_spec): "RecommendDatastores", session.vim.service_content.storageResourceManager, storageSpec=sp_spec) + if not hasattr(spr, 'recommendations'): + LOG.error("Unable to find suitable datastore") + return return spr.recommendations[0].key |