summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorVipin Balachandran <vbala@vmware.com>2019-05-13 15:56:25 -0700
committerVipin Balachandran <vbala@vmware.com>2019-05-13 16:03:29 -0700
commit42d240a2eb200d93fd1a1d9962f4a747eb31985b (patch)
treea25fd62c2f7ee860a84ae074596faf7eb4bf0de9
parent95d849ebe733c3748bdc293362d3a9a4b744b857 (diff)
downloadoslo-vmware-42d240a2eb200d93fd1a1d9962f4a747eb31985b.tar.gz
Set locale to english
oslo.vmware library does not need to emit localized messages from vCenter. Explicitly setting the locale to 'en' during session establishment to avoid UnicodeDecodeError while handling non- english vCenter messages. Change-Id: Ifb26a7832c15af3ed3227c94131fe0b22579e889
-rw-r--r--oslo_vmware/api.py3
-rw-r--r--oslo_vmware/tests/test_api.py6
2 files changed, 5 insertions, 4 deletions
diff --git a/oslo_vmware/api.py b/oslo_vmware/api.py
index 76cbeba..81c44ef 100644
--- a/oslo_vmware/api.py
+++ b/oslo_vmware/api.py
@@ -243,7 +243,8 @@ class VMwareAPISession(object):
LOG.debug("Logging into host: %s.", self._host)
session = self.vim.Login(session_manager,
userName=self._server_username,
- password=self._server_password)
+ password=self._server_password,
+ locale='en')
self._session_id = session.key
# We need to save the username in the session since we may need it
# later to check active session. The SessionIsActive method requires
diff --git a/oslo_vmware/tests/test_api.py b/oslo_vmware/tests/test_api.py
index e268b77..ad5bce4 100644
--- a/oslo_vmware/tests/test_api.py
+++ b/oslo_vmware/tests/test_api.py
@@ -173,7 +173,7 @@ class VMwareAPISessionTest(base.TestCase):
session_manager = vim_obj.service_content.sessionManager
vim_obj.Login.assert_called_once_with(
session_manager, userName=VMwareAPISessionTest.USERNAME,
- password=VMwareAPISessionTest.PASSWORD)
+ password=VMwareAPISessionTest.PASSWORD, locale='en')
self.assertFalse(vim_obj.TerminateSession.called)
self.assertEqual(session.key, api_session._session_id)
pbm.set_soap_cookie.assert_called_once_with(cookie)
@@ -197,7 +197,7 @@ class VMwareAPISessionTest(base.TestCase):
userName=VMwareAPISessionTest.USERNAME)
vim_obj.Login.assert_called_once_with(
session_manager, userName=VMwareAPISessionTest.USERNAME,
- password=VMwareAPISessionTest.PASSWORD)
+ password=VMwareAPISessionTest.PASSWORD, locale='en')
self.assertEqual(new_session_key, api_session._session_id)
def test_create_session_with_existing_active_session(self):
@@ -257,7 +257,7 @@ class VMwareAPISessionTest(base.TestCase):
session_manager = vim_obj.service_content.sessionManager
vim_obj.Login.assert_called_once_with(
session_manager, userName=VMwareAPISessionTest.USERNAME,
- password=VMwareAPISessionTest.PASSWORD)
+ password=VMwareAPISessionTest.PASSWORD, locale='en')
api_session.logout()
vim_obj.Logout.assert_called_once_with(
session_manager)