summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAnh Tran <anhtt@vn.fujitsu.com>2016-09-28 10:08:50 +0700
committerAnh Tran <anhtt@vn.fujitsu.com>2016-09-28 10:08:50 +0700
commitf5c7762bb072a48ba5cee62c5c3b587bf220bae6 (patch)
treeaa4eca4638371b9ebf403e12c1379c177bb6d94a
parent3afd2cf7e56a430155d51309df9a5df07b0981a9 (diff)
downloadpython-barbicanclient-f5c7762bb072a48ba5cee62c5c3b587bf220bae6.tar.gz
Using assertTrue/False() instead of assertEqual(True/False)
Change-Id: I0737e82751d905bb344398268cd5f1b76e5595ab
-rw-r--r--barbicanclient/tests/test_acls.py8
-rw-r--r--barbicanclient/tests/test_barbican.py2
2 files changed, 5 insertions, 5 deletions
diff --git a/barbicanclient/tests/test_acls.py b/barbicanclient/tests/test_acls.py
index 7f716e6..f3a468e 100644
--- a/barbicanclient/tests/test_acls.py
+++ b/barbicanclient/tests/test_acls.py
@@ -61,7 +61,7 @@ class WhenTestingACLManager(ACLTestCase):
api_resp = self.manager.get(entity_ref=self.secret_ref)
self.assertEqual(self.secret_acl_ref,
self.responses.last_request.url)
- self.assertEqual(False, api_resp.get('read').project_access)
+ self.assertFalse(api_resp.get('read').project_access)
self.assertEqual('read', api_resp.get('read').operation_type)
self.assertEqual(self.secret_acl_ref, api_resp.get('read').acl_ref)
@@ -80,7 +80,7 @@ class WhenTestingACLManager(ACLTestCase):
api_resp = self.manager.get(entity_ref=self.container_ref)
self.assertEqual(self.container_acl_ref,
self.responses.last_request.url)
- self.assertEqual(False, api_resp.get('read').project_access)
+ self.assertFalse(api_resp.get('read').project_access)
self.assertEqual('read', api_resp.get('read').operation_type)
self.assertEqual(self.container_acl_ref, api_resp.get('read').acl_ref)
@@ -110,7 +110,7 @@ class WhenTestingACLManager(ACLTestCase):
read_acl = entity.read
# entity ref is kept same as provided input.
self.assertEqual(self.secret_ref + '///', read_acl.entity_ref)
- self.assertEqual(True, read_acl.project_access)
+ self.assertTrue(read_acl.project_access)
self.assertEqual(self.users1, read_acl.users)
self.assertEqual(acls.DEFAULT_OPERATION_TYPE, read_acl.operation_type)
# acl ref removes extra trailing slashes if there
@@ -130,7 +130,7 @@ class WhenTestingACLManager(ACLTestCase):
self.assertEqual(self.container_ref + '///', entity.entity_ref)
read_acl = entity.read
- self.assertEqual(False, read_acl.project_access)
+ self.assertFalse(read_acl.project_access)
self.assertEqual(self.users2, read_acl.users)
self.assertEqual(acls.DEFAULT_OPERATION_TYPE, read_acl.operation_type)
# acl ref removes extra trailing slashes if there
diff --git a/barbicanclient/tests/test_barbican.py b/barbicanclient/tests/test_barbican.py
index da7381e..3baef03 100644
--- a/barbicanclient/tests/test_barbican.py
+++ b/barbicanclient/tests/test_barbican.py
@@ -117,7 +117,7 @@ class WhenTestingBarbicanCLI(test_client.BaseEntityResource):
api_version = argv.os_identity_api_version
barbican = Barbican()
response = barbican.check_auth_arguments(argv, api_version)
- self.assertEqual(True, response)
+ self.assertTrue(response)
def test_should_fail_check_auth_arguments_v2(self):
args = ("--os-username bob --os-password jan --os-auth-url boop"