summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSwapnil Kulkarni (coolsvap) <me@coolsvap.net>2016-01-07 12:37:26 +0530
committerSwapnil Kulkarni (coolsvap) <me@coolsvap.net>2016-01-07 12:38:00 +0530
commitc4abadfee8de8f64f91e4579b0f58fc7b4943462 (patch)
tree390c059861d01804260817ae3aeea45436f949a6
parent6097b0ce2ed80651f2e49c47adf7c0b5a11f5431 (diff)
downloadpython-ceilometerclient-c4abadfee8de8f64f91e4579b0f58fc7b4943462.tar.gz
Use assertTrue/False instead of assertEqual(T/F)
The usage of assertEqual(True/False, ***) should be changed to a meaningful format of assertTrue/False(***). Change-Id: Iabf8d017b47025309f186afb5e30b8ad990c2448 Closes-Bug:#1512207
-rw-r--r--ceilometerclient/tests/unit/test_shell.py8
-rw-r--r--ceilometerclient/tests/unit/v2/test_capabilities.py2
2 files changed, 5 insertions, 5 deletions
diff --git a/ceilometerclient/tests/unit/test_shell.py b/ceilometerclient/tests/unit/test_shell.py
index e40835b..47179f9 100644
--- a/ceilometerclient/tests/unit/test_shell.py
+++ b/ceilometerclient/tests/unit/test_shell.py
@@ -210,7 +210,7 @@ class ShellInsecureTest(ShellTestBase):
args = ['--debug', '--os-insecure', 'true', 'alarm-list']
self.assertIsNone(ceilometer_shell.main(args))
args, kwargs = mocked_client.call_args
- self.assertEqual(False, kwargs.get('verify'))
+ self.assertFalse(kwargs.get('verify'))
@mock.patch.object(ks_session, 'Session')
@mock.patch('ceilometerclient.client.AuthPlugin.redirect_to_aodh_endpoint')
@@ -220,7 +220,7 @@ class ShellInsecureTest(ShellTestBase):
args = ['--debug', '--os-insecure', 'true', 'alarm-list']
self.assertRaises(exc.CommandError, ceilometer_shell.main, args)
args, kwargs = mocked_session.call_args
- self.assertEqual(False, kwargs.get('verify'))
+ self.assertFalse(kwargs.get('verify'))
@mock.patch.object(api_client, 'HTTPClient')
@mock.patch('ceilometerclient.client.AuthPlugin.redirect_to_aodh_endpoint')
@@ -229,7 +229,7 @@ class ShellInsecureTest(ShellTestBase):
args = ['--debug', '--os-insecure', 'false', 'alarm-list']
self.assertIsNone(ceilometer_shell.main(args))
args, kwargs = mocked_client.call_args
- self.assertEqual(True, kwargs.get('verify'))
+ self.assertTrue(kwargs.get('verify'))
@mock.patch.object(ks_session, 'Session')
@mock.patch('ceilometerclient.client.AuthPlugin.redirect_to_aodh_endpoint')
@@ -239,7 +239,7 @@ class ShellInsecureTest(ShellTestBase):
args = ['--debug', '--os-insecure', 'false', 'alarm-list']
self.assertRaises(exc.CommandError, ceilometer_shell.main, args)
args, kwargs = mocked_session.call_args
- self.assertEqual(True, kwargs.get('verify'))
+ self.assertTrue(kwargs.get('verify'))
class ShellEndpointTest(ShellTestBase):
diff --git a/ceilometerclient/tests/unit/v2/test_capabilities.py b/ceilometerclient/tests/unit/v2/test_capabilities.py
index 32468cb..2442e0a 100644
--- a/ceilometerclient/tests/unit/v2/test_capabilities.py
+++ b/ceilometerclient/tests/unit/v2/test_capabilities.py
@@ -55,4 +55,4 @@ class CapabilitiesManagerTest(testtools.TestCase):
def test_capabilities_get(self):
capabilities = self.mgr.get()
self.http_client.assert_called('GET', '/v2/capabilities')
- self.assertEqual(True, capabilities.api['alarms:query:complex'])
+ self.assertTrue(capabilities.api['alarms:query:complex'])